Skip to contentSkip to conversation

[email protected]'s Cc list on reviews

DISCUSSION Sean Christopherson 2 participants 7 messages May 18 KVM

lore
Share & tools
lore

Sean Christopherson

author reviewer
#0 lore raw

Hey Roman!

Sashiko's choice of Cc is... odd. The original mail has a whole pile of folks in both the To: and Cc:, but sashiko-bot is only replying to myself and (very bizarrely) [email protected].

Oooh, is it perhaps because [email protected] is the only mailing list on the original Cc that has opted-in to getting emails? If that's the case, we might want to change that, even though it could result in people getting grumpy about unwanted bot mail, because IMO the alternative is worse. I've been responding to some (mostly very good!) good sashiko-bot feedback, but only just now noticed that the vast majority of folks on the To/Cc of the original patch won't see the reviews. That's bound to cause confusion, e.g. if someone reports the same issues and/or manually looks at sashiko.dev.

----- Forwarded message from [email protected] -----

Date: Fri, 15 May 2026 19:55:51 +0000
From: [email protected]
To: Sean Christopherson <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH v3 36/41] x86/kvmclock: Get local APIC bus frequency from PV CPUID Timing Info

...

----- End forwarded message -----

#1 lore raw
Quoted 7 lines · Sean Christopherson

Hey Roman!

Sashiko's choice of Cc is... odd. The original mail has a whole pile of folks in both the To: and Cc:, but sashiko-bot is only replying to myself and (very bizarrely) [email protected].

Quoted 8 lines

Oooh, is it perhaps because [email protected] is the only mailing list on the original Cc that has opted-in to getting emails? If that's the case, we might want to change that, even though it could result in people getting grumpy about unwanted bot mail, because IMO the alternative is worse. I've been responding to some (mostly very good!) good sashiko-bot feedback, but only just now noticed that the vast majority of folks on the To/Cc of the original patch won't see the reviews. That's bound to cause confusion, e.g. if someone reports the same issues and/or manually looks at sashiko.dev.

Hi Sean!

It's expected per configuration here:
https://github.com/sashiko-dev/sashiko/blob/main/sashiko.dev/email_policy.toml#L138
.
It can be configured to reply to all as well, but since there are some very vocal anti-AI folks in the community, this might create some friction. In any case, I'm relying on the corresponding maintainers' decision on how they want to configure Sashiko.

Thanks!

author reviewer
#2 lore raw
Quoted 17 lines · Roman Gushchin
Quoted 7 lines · Sean Christopherson

Hey Roman!

Sashiko's choice of Cc is... odd. The original mail has a whole pile of folks in both the To: and Cc:, but sashiko-bot is only replying to myself and (very bizarrely) [email protected].

Quoted 8 lines

Oooh, is it perhaps because [email protected] is the only mailing list on the original Cc that has opted-in to getting emails? If that's the case, we might want to change that, even though it could result in people getting grumpy about unwanted bot mail, because IMO the alternative is worse. I've been responding to some (mostly very good!) good sashiko-bot feedback, but only just now noticed that the vast majority of folks on the To/Cc of the original patch won't see the reviews. That's bound to cause confusion, e.g. if someone reports the same issues and/or manually looks at sashiko.dev.

Quoted 8 lines

Hi Sean!

It's expected per configuration here:
https://github.com/sashiko-dev/sashiko/blob/main/sashiko.dev/email_policy.toml#L138
.
It can be configured to reply to all as well, but since there are some very vocal anti-AI folks in the community, this might create some friction.

Heh, "might".

Quoted 2 lines

In any case, I'm relying on the corresponding maintainers' decision on how they want to configure Sashiko.

What level of configurability does the parser have? Specifically, can it key off the Cc/To in addition to the list? I ask because I really, really, want to enable auto-mailing for at least KVM x86, but [email protected] is wildly overloaded. I could try and drive consensus across all 30+ maintainers, but if there's a way to precisely enable it for just KVM x86...

E.g. is there a way to do something like:

[subsystems.kvm_x86]
lists = ["[email protected]" && <email is To: [email protected]>] reply_all = true

#3 lore raw
Quoted 21 lines · Sean Christopherson
Quoted 19 lines · Roman Gushchin
Quoted 7 lines · Sean Christopherson

Hey Roman!

Sashiko's choice of Cc is... odd. The original mail has a whole pile of folks in both the To: and Cc:, but sashiko-bot is only replying to myself and (very bizarrely) [email protected].

Quoted 8 lines

Oooh, is it perhaps because [email protected] is the only mailing list on the original Cc that has opted-in to getting emails? If that's the case, we might want to change that, even though it could result in people getting grumpy about unwanted bot mail, because IMO the alternative is worse. I've been responding to some (mostly very good!) good sashiko-bot feedback, but only just now noticed that the vast majority of folks on the To/Cc of the original patch won't see the reviews. That's bound to cause confusion, e.g. if someone reports the same issues and/or manually looks at sashiko.dev.

Hi Sean!

Quoted 8 lines
Quoted 6 lines

It's expected per configuration here:
https://github.com/sashiko-dev/sashiko/blob/main/sashiko.dev/email_policy.toml#L138
.
It can be configured to reply to all as well, but since there are some very vocal anti-AI folks in the community, this might create some friction.

Heh, "might".

:)

Quoted 9 lines
Quoted 2 lines

In any case, I'm relying on the corresponding maintainers' decision on how they want to configure Sashiko.

What level of configurability does the parser have? Specifically, can it key off the Cc/To in addition to the list? I ask because I really, really, want to enable auto-mailing for at least KVM x86, but [email protected] is wildly overloaded. I could try and drive consensus across all 30+ maintainers, but if there's a way to precisely enable it for just KVM x86...

Quoted 5 lines

E.g. is there a way to do something like:

[subsystems.kvm_x86]
lists = ["[email protected]" && <email is To: [email protected]>] reply_all = true

No, currently it's only per-mailing list. I did not expect that it would be that contentious.
Maybe it should be based on entries in the maintainers file instead. But even then,
what if a sub-subsystem wants emails and the top-level subsystem maintainers are against it? Or if a patchset touches multiple subsystems.

I mean if building a complex configuration system is the only way forward, ok, it's kinda silly,
but why not.

author reviewer
#4 lore raw
Quoted 12 lines · Roman Gushchin
Quoted 11 lines · Sean Christopherson
Quoted 3 lines · Roman Gushchin

On Mon, May 18, 2026 at 2:08 PM Sean Christopherson <[email protected]> wrote:
In any case, I'm relying on the corresponding maintainers' decision on how they want to configure Sashiko.

What level of configurability does the parser have? Specifically, can it key off the Cc/To in addition to the list? I ask because I really, really, want to enable auto-mailing for at least KVM x86, but [email protected] is wildly overloaded. I could try and drive consensus across all 30+ maintainers, but if there's a way to precisely enable it for just KVM x86...

Quoted 8 lines
Quoted 5 lines

E.g. is there a way to do something like:

[subsystems.kvm_x86]
lists = ["[email protected]" && <email is To: [email protected]>] reply_all = true

No, currently it's only per-mailing list. I did not expect that it would be that contentious.

Before you go add more configuration goo on your end, let me see what the other kvm@ maintainers think. Maybe we'll get lucky and everyone is on-board already.

Quoted 4 lines

Maybe it should be based on entries in the maintainers file instead. But even then, what if a sub-subsystem wants emails and the top-level subsystem maintainers are against it? Or if a patchset touches multiple subsystems.

Hmm, maybe use a page table walker approach, and only send emails if every node of the tree says yes? Only getting email some of the time would be pretty darn annoying though :-/

Quoted 2 lines

I mean if building a complex configuration system is the only way forward, ok, it's kinda silly, but why not.

s/kinda silly/flat out stupid, given how easy it is to filter/ignore email.

Crazy idea: as a stopgap, what if sashiko emails [email protected] if the list hasn't opted-in? It wouldn't be as good as getting mails sent directly to me, but subscribing to and filtering [email protected] mails is very doable. And even without subscribing to [email protected], for those of us that heavily utilize b4, it would better than clicking through a web site.

author reviewer
#5 lore raw
In reply to Sean Christopherson
Quoted 38 lines · Sean Christopherson
Quoted 17 lines · Roman Gushchin
Quoted 7 lines · Sean Christopherson

Hey Roman!

Sashiko's choice of Cc is... odd. The original mail has a whole pile of folks in both the To: and Cc:, but sashiko-bot is only replying to myself and (very bizarrely) [email protected].

Quoted 8 lines

Oooh, is it perhaps because [email protected] is the only mailing list on the original Cc that has opted-in to getting emails? If that's the case, we might want to change that, even though it could result in people getting grumpy about unwanted bot mail, because IMO the alternative is worse. I've been responding to some (mostly very good!) good sashiko-bot feedback, but only just now noticed that the vast majority of folks on the To/Cc of the original patch won't see the reviews. That's bound to cause confusion, e.g. if someone reports the same issues and/or manually looks at sashiko.dev.

Quoted 8 lines

Hi Sean!

It's expected per configuration here:
https://github.com/sashiko-dev/sashiko/blob/main/sashiko.dev/email_policy.toml#L138
.
It can be configured to reply to all as well, but since there are some very vocal anti-AI folks in the community, this might create some friction.

Heh, "might".

Quoted 2 lines

In any case, I'm relying on the corresponding maintainers' decision on how they want to configure Sashiko.

What level of configurability does the parser have? Specifically, can it key off the Cc/To in addition to the list? I ask because I really, really, want to enable auto-mailing for at least KVM x86, but [email protected] is wildly overloaded. I could try and drive consensus across all 30+ maintainers, but if there's a way to precisely enable it for just KVM x86...

Quoted 5 lines

E.g. is there a way to do something like:

[subsystems.kvm_x86]
lists = ["[email protected]" && <email is To: [email protected]>] reply_all = true

Actually, shouldn't this be a line item in MAINTAINERS? E.g. an "A:" section to describe the subsystem's preferences for AI reviews (and in the future, other things?).

#6 lore raw
Quoted 42 lines · Sean Christopherson
Quoted 40 lines · Sean Christopherson
Quoted 17 lines · Roman Gushchin
Quoted 7 lines · Sean Christopherson

Hey Roman!

Sashiko's choice of Cc is... odd. The original mail has a whole pile of folks in both the To: and Cc:, but sashiko-bot is only replying to myself and (very bizarrely) [email protected].

Quoted 8 lines

Oooh, is it perhaps because [email protected] is the only mailing list on the original Cc that has opted-in to getting emails? If that's the case, we might want to change that, even though it could result in people getting grumpy about unwanted bot mail, because IMO the alternative is worse. I've been responding to some (mostly very good!) good sashiko-bot feedback, but only just now noticed that the vast majority of folks on the To/Cc of the original patch won't see the reviews. That's bound to cause confusion, e.g. if someone reports the same issues and/or manually looks at sashiko.dev.

Quoted 8 lines

Hi Sean!

It's expected per configuration here:
https://github.com/sashiko-dev/sashiko/blob/main/sashiko.dev/email_policy.toml#L138
.
It can be configured to reply to all as well, but since there are some very vocal anti-AI folks in the community, this might create some friction.

Heh, "might".

Quoted 2 lines

In any case, I'm relying on the corresponding maintainers' decision on how they want to configure Sashiko.

What level of configurability does the parser have? Specifically, can it key off the Cc/To in addition to the list? I ask because I really, really, want to enable auto-mailing for at least KVM x86, but [email protected] is wildly overloaded. I could try and drive consensus across all 30+ maintainers, but if there's a way to precisely enable it for just KVM x86...

E.g. is there a way to do something like:

Quoted 7 lines
Quoted 3 lines

[subsystems.kvm_x86]
lists = ["[email protected]" && <email is To: [email protected]>] reply_all = true

Actually, shouldn't this be a line item in MAINTAINERS? E.g. an "A:" section to describe the subsystem's preferences for AI reviews (and in the future, other things?).

This would work too. But when people send patches (including LLM-generated patches) get_maintainers.pl
will produce a combined list of all relevant maintainers and mailing lists. There is no option for "I don't want to be cc'ed
on patches from mailing list X". It sounds like some folks are looking for this option for AI reviews...