vmalloc: Fix NULL pointer dereference in is_vm_area_hugepages()
Subsystems (2)
PATCH 1/1 vmalloc: Fix NULL pointer dereference in is_vm_area_hugepages()
From: Hui Zhu <[email protected]>
find_vm_area() can return NULL if the given address is not a valid vmalloc area. Check the return value before dereferencing it to avoid a kernel crash.
Fixes 121e6f3258fe ("mm/vmalloc: hugepage vmalloc mappings")
Signed-off-by Hui Zhu <[email protected]>
--- include/linux/vmalloc.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
include/linux/vmalloc.h +3 -1
@@ -265,7 +265,9 @@ static inline bool is_vm_area_hugepages(const void *addr)* allocated in the vmalloc layer. */ #ifdef CONFIG_HAVE_ARCH_HUGE_VMALLOC -return find_vm_area (addr)->page_order >0 ; +struct vm_struct *area =find_vm_area (addr); + +return area && area->page_order >0 ;#else return false;#endif
Signature · 1 line
2.43.0
Quoted 9 lines · Hui Zhu
From: Hui Zhu <[email protected]>
find_vm_area()can return NULL if the given address is not a valid vmalloc area. Check the return value before dereferencing it to avoid a kernel crash.Fixes 121e6f3258fe ("mm/vmalloc: hugepage vmalloc mappings")Signed-off-by Hui Zhu <[email protected]>---
I think this makes sense from API PoV.
Reviewed-by Dev Jain <[email protected]>
Quoted 18 lines
include/linux/vmalloc.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)include/linux/vmalloc.h +3
-1@@ -265,7 +265,9 @@ static inline bool is_vm_area_hugepages(const void *addr)* allocated in the vmalloc layer. */ #ifdef CONFIG_HAVE_ARCH_HUGE_VMALLOC -return find_vm_area (addr)->page_order >0 ; +struct vm_struct *area =find_vm_area (addr); + +return area && area->page_order >0 ;#else return false;#endif
Quoted 9 lines · Dev Jain
Quoted 6 lines · Hui Zhu
From: Hui Zhu <[email protected]>
find_vm_area()can return NULL if the given address is not a valid vmalloc area. Check the return value before dereferencing it to avoid a kernel crash.
Quoted 8 lines
Quoted 3 lines
Fixes 121e6f3258fe ("mm/vmalloc: hugepage vmalloc mappings")Signed-off-by Hui Zhu <[email protected]>---
I think this makes sense from API PoV.
Reviewed-by Dev Jain <[email protected]>
Reviewed-by Uladzislau Rezki (Sony) <[email protected]>
--
Uladzislau Rezki