Skip to contentSkip to conversation

stack-overflow in src/parser.c

BUG In review Ilia Kashintsev 3 participants 4 messages Mar 18 – Jun 13

lore
Share & tools
lore
#0 lore raw

Hello maintainers!

There is a stack-overflow caused by a huge number of opening parentheses.

Sanitizer output:

# AddressSanitizer:DEADLYSIGNAL
=================================================================
==1393234==ERROR: AddressSanitizer: stack-overflow on address 0x7fff8ea6fff8 (pc 0x5c982afe24b1 bp 0x7fff8ea70060 sp 0x7fff8ea6ffe0 T0)

    #0 0x5c982afe24b1 in __pgetc /orig_to_send/dash/src/input.c:227:14
    #1 0x5c982afe201e in pgetc /orig_to_send/dash/src/input.c:248:9
    #2 0x5c982aff80cc in pgetc_eatbnl /orig_to_send/dash/src/parser.c:854:14
    #3 0x5c982aff8b39 in xxreadtoken /orig_to_send/dash/src/parser.c:810:7
    #4 0x5c982aff82b5 in readtoken /orig_to_send/dash/src/parser.c:711:6
    #5 0x5c982aff30cc in list /orig_to_send/dash/src/parser.c:181:9
    #6 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #7 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #8 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #9 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #10 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #11 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #12 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #13 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #14 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #15 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #16 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #17 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #18 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #19 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #20 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #21 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #22 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #23 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #24 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #25 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #26 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #27 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #28 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #29 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #30 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #31 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #32 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #33 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #34 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #35 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #36 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #37 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #38 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #39 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #40 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #41 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #42 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #43 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #44 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #45 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #46 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #47 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #48 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #49 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #50 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #51 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #52 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #53 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #54 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #55 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #56 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #57 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #58 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #59 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #60 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #61 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #62 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #63 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #64 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #65 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #66 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #67 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #68 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #69 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #70 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #71 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #72 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #73 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #74 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #75 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #76 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #77 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #78 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #79 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #80 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #81 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #82 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #83 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #84 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #85 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #86 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #87 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #88 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #89 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #90 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #91 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #92 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #93 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #94 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #95 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #96 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #97 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #98 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #99 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #100 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #101 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #102 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #103 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #104 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #105 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #106 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #107 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #108 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #109 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #110 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #111 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #112 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #113 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #114 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #115 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #116 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #117 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #118 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #119 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #120 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #121 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #122 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #123 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #124 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #125 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #126 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #127 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #128 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #129 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #130 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #131 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #132 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #133 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #134 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #135 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #136 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #137 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #138 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #139 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #140 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #141 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #142 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #143 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #144 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #145 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #146 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #147 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #148 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #149 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #150 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #151 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #152 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #153 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #154 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #155 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #156 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #157 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #158 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #159 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #160 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #161 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #162 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #163 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #164 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #165 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #166 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #167 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #168 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #169 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #170 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #171 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #172 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #173 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #174 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #175 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #176 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #177 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #178 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #179 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #180 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #181 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #182 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #183 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #184 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #185 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #186 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #187 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #188 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #189 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #190 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #191 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #192 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #193 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #194 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #195 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #196 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #197 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #198 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #199 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #200 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #201 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #202 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #203 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #204 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #205 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #206 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #207 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #208 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #209 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #210 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #211 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #212 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #213 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #214 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #215 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #216 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #217 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #218 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #219 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #220 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #221 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #222 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #223 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #224 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #225 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #226 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #227 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #228 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #229 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #230 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #231 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #232 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #233 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #234 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #235 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #236 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #237 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #238 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #239 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #240 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #241 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #242 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18
    #243 0x5c982aff8e9c in pipeline /orig_to_send/dash/src/parser.c:289:7
    #244 0x5c982aff881c in andor /orig_to_send/dash/src/parser.c:253:7
    #245 0x5c982aff31c8 in list /orig_to_send/dash/src/parser.c:202:8
    #246 0x5c982affa44d in command /orig_to_send/dash/src/parser.c:475:18

SUMMARY: AddressSanitizer: stack-overflow
/orig_to_send/dash/src/input.c:227:14 in __pgetc
==1393234==ABORTING

The stacktrace itself is not always consistent, f.e. sometimes the crash occurs upon entering command() on line 321 or inside of xxreadtoken() on line 810.

Steps to reproduce:

export CC=clang
export CFLAGS=" -g -fsanitize=address "
./autogen.sh
./configure
make
#80000 might be excessive, even 10000 is enough for ulimit -s 8192 printf '%0.s(' {1..80000} > brackets.txt
./src/dash -i brackets.txt

#1 lore raw
Quoted 7 lines · Ilia Kashintsev

The stacktrace itself is not always consistent, f.e. sometimes the crash occurs upon entering command() on line 321 or inside of xxreadtoken() on line 810.

Steps to reproduce:

Quoted 8 lines

export CC=clang
export CFLAGS=" -g -fsanitize=address "
./autogen.sh
./configure
make
#80000 might be excessive, even 10000 is enough for ulimit -s 8192 printf '%0.s(' {1..80000} > brackets.txt
./src/dash -i brackets.txt

Hi Ilia, Maintainers,

I have a small fix for this bug, which is more direct. setting a recurse limit of '(' and '{'. I think 5000 should be fine. Although there can be a more proper fix using user m-allocated stack. But I am not sure how to implement that.

I'll send the patch as a reply to this message.

Thanks.
~Shivang

#2 lore raw

PATCH 1/1 parser: set recursion deapth limit for parens

Setting 5000 as limit for recursive parenthesis '()' or braces '{}'.

---
 src/parser.c | 9 +++++++++
 1 file changed, 9 insertions(+)
src/parser.c +9 -0
index 412e876..5198dc4 100644
@@ -110,7 +110,9 @@ struct nodelist *backquotelist;
 union node *redirnode;
 struct heredoc *heredoc;
 int quoteflag;			/* set if (part of) last token was quoted */
+static int paren_depth;		/* track parenthesis nesting depth */
 
+#define MAX_PAREN_DEPTH 5000
 
 STATIC union node *list(int);
 STATIC union node *andor(void);
@@ -164,6 +166,7 @@ parsecmd(int interact)
 	if (doprompt)
 		setprompt(doprompt);
 	needprompt = 0;
+	paren_depth = 0;
 	return list(1);
 }
 
@@ -471,15 +474,21 @@ next_case:
 		*cpp = NULL;
 		goto redir;
 	case TLP:
+		if (++paren_depth > MAX_PAREN_DEPTH)
+			synerror("too many nested parentheses");
 		n1 = (union node *)stalloc(sizeof (struct nredir));
 		n1->type = NSUBSHELL;
 		n1->nredir.linno = savelinno;
 		n1->nredir.n = list(0);
+		paren_depth--;
 		n1->nredir.redirect = NULL;
 		t = TRP;
 		break;
 	case TBEGIN:
+		if (++paren_depth > MAX_PAREN_DEPTH)
+			synerror("too many nested braces");
 		n1 = list(0);
+		paren_depth--;
 		t = TEND;
 		break;
 	case TWORD:
Signature · 1 line
2.53.0
#3 lore raw

Re: [PATCH] parser: set recursion deapth limit for parens

Quoted 16 lines · Shivang Upadhyay

Setting 5000 as limit for recursive parenthesis '()' or braces '{}'.

---
src/parser.c | 9 +++++++++

1 file changed, 9 insertions(+)
src/parser.c +0 -0
index 412e876..5198dc4 100644
@@ -110,7 +110,9 @@ struct nodelist *backquotelist;
 union node *redirnode;
 struct heredoc *heredoc;

int quoteflag; /* set if (part of) last token was quoted */

src/parser.c struct nodelist *backquotelist; · line 115

Quoted 3 lines
src/parser.c +2 -0
+static int paren_depth;                /* track parenthesis nesting depth */
 
+#define MAX_PAREN_DEPTH 5000

This is a completely arbitrary limit and removes the ability to increase recursion by setting ulimit -s.

I'm not taking this.

Thanks,

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt