Skip to contentSkip to conversation

staging: nvec: fix coding style issues in nvec.c

PATCH In review Dorian Catric 2 participants 2 messages Jun 2 – Jun 3

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: nvec: fix coding style issues in nvec.c

Fix three coding style issues detected by checkpatch.pl:

- Fix typo in URL: 'lauchpad.net' -> 'launchpad.net' in the copyright header (nvec.h already has the correct spelling)
- Remove extra space in 'enum nvec_msg_category {' declaration
- Convert EXPORT_SYMBOL() to EXPORT_SYMBOL_GPL() for nvec_write_async() and nvec_write_sync() to match the other exported symbols in this driver

---
 drivers/staging/nvec/nvec.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/nvec/nvec.c +4 -4
index 952c5a849a563..f14d9a1eb2ed5 100644
@@ -2,7 +2,7 @@
 /*
  * NVEC: NVIDIA compliant embedded controller interface
  *
- * Copyright (C) 2011 The AC100 Kernel Team <[email protected]>
+ * Copyright (C) 2011 The AC100 Kernel Team <[email protected]>
  *
  * Authors:  Pierre-Hugues Husson <[email protected]>
  *           Ilya Petrov <[email protected]>
@@ -57,7 +57,7 @@
  * @NVEC_MSG_RX: The message is an incoming message (from EC)
  * @NVEC_MSG_TX: The message is an outgoing message (to EC)
  */
-enum nvec_msg_category  {
+enum nvec_msg_category {
 	NVEC_MSG_RX,
 	NVEC_MSG_TX,
 };
@@ -275,7 +275,7 @@ int nvec_write_async(struct nvec_chip *nvec, const unsigned char *data,
 
 	return 0;
 }
-EXPORT_SYMBOL(nvec_write_async);
+EXPORT_SYMBOL_GPL(nvec_write_async);
 
 /**
  * nvec_write_sync - Write a message to nvec and read the response
@@ -331,7 +331,7 @@ int nvec_write_sync(struct nvec_chip *nvec,
 
 	return 0;
 }
-EXPORT_SYMBOL(nvec_write_sync);
+EXPORT_SYMBOL_GPL(nvec_write_sync);
 
 /**
  * nvec_toggle_global_events - enables or disables global event reporting
Signature · 1 line
2.34.1
#1 lore raw
Quoted 7 lines · Dorian Catric

Fix three coding style issues detected by checkpatch.pl:

- Fix typo in URL: 'lauchpad.net' -> 'launchpad.net' in the copyright header (nvec.h already has the correct spelling)
- Remove extra space in 'enum nvec_msg_category {' declaration
- Convert EXPORT_SYMBOL() to EXPORT_SYMBOL_GPL() for nvec_write_async() and nvec_write_sync() to match the other exported symbols in this driver

Probably needs all be separate patches. The EXPORT_SYMBOL() to EXPORT_SYMBOL_GPL() conversion is controversial and not a checkpatch issue.

regards,
dan carpenter