drm/tegra: dc: Fix device node reference leak in tegra_dc_has_output()
PATCH 1/1 drm/tegra: dc: Fix device node reference leak in tegra_dc_has_output()
The of_for_each_phandle() macro increments the reference count of the device node it iterates over. If the loop exits early, the reference must be released manually.
In tegra_dc_has_output(), the function returns true immediately when a match is found, failing to release the current node's reference.
Fix this by adding a call to of_node_put() before returning from the loop.
--- drivers/gpu/drm/tegra/dc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/tegra/dc.c +3 -1
@@ -101,8 +101,10 @@ bool tegra_dc_has_output(struct tegra_dc *dc, struct device *dev)int err;of_for_each_phandle (&it, err, np,"nvidia,outputs" ,NULL ,0 ) -if (it.node == dev->of_node) +if (it.node == dev->of_node) { +of_node_put (it.node);return true; + }return false; }
---
base-commit: 615aad0f61e0c7a898184a394dc895c610100d4f
change-id: 20260127-dc-e396ab5384da
Best regards,
Signature · 1 line
Felix Gu <[email protected]>
Quoted 36 lines · Felix Gu
The
of_for_each_phandle()macro increments the reference count of the device node it iterates over. If the loop exits early, the reference must be released manually.In
tegra_dc_has_output(), the function returns true immediately when a match is found, failing to release the current node's reference.Fix this by adding a call to
of_node_put()before returning from the loop.Fixes c57997bce423 ("drm/tegra: sor: Add Tegra186 support")Signed-off-by Felix Gu <[email protected]>--- drivers/gpu/drm/tegra/dc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/gpu/drm/tegra/dc.c +3
-2@@ -101,8 +101,10 @@ bool tegra_dc_has_output(struct tegra_dc *dc, struct device *dev)int err;of_for_each_phandle (&it, err, np,"nvidia,outputs" ,NULL ,0 ) -if (it.node == dev->of_node) +if (it.node == dev->of_node) { +of_node_put (it.node);return true; + }return false; } ---base-commit:
615aad0f61e0c7a898184a394dc895c610100d4f
change-id: 20260127-dc-e396ab5384da
Quoted 5 lines
Best regards,
Signature · 1 line
Felix Gu <[email protected]>
Thierry Reding
maintainerQuoted 7 lines · Felix Gu
The
of_for_each_phandle()macro increments the reference count of the device node it iterates over. If the loop exits early, the reference must be released manually.In
tegra_dc_has_output(), the function returns true immediately when a match is found, failing to release the current node's reference.
Quoted 7 lines
Fix this by adding a call to
of_node_put()before returning from the loop.Fixes c57997bce423 ("drm/tegra: sor: Add Tegra186 support")Signed-off-by Felix Gu <[email protected]>--- drivers/gpu/drm/tegra/dc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Sorry for missing this earlier. Applied now, thanks.
Thierry