Skip to contentSkip to conversation

soundwire: dmi-quirks: Disable ghost device on Lenovo Yoga 9i

PATCH In review Charles Keepax 3 participants 5 messages Jun 8 – Jun 18

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soundwire: dmi-quirks: Disable ghost device on Lenovo Yoga 9i

There is also a "non-pro" version of the Lenovo Yoga 9i (83SE) which also needs a quirk to disable a non-existent Realtek device. Add this missing quirk.

---
 drivers/soundwire/dmi-quirks.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/soundwire/dmi-quirks.c +7 -0
index 32a46a2d90f7c..c7e50873c8739 100644
@@ -192,6 +192,13 @@ static const struct dmi_system_id adr_remap_quirk_table[] = {
 		},
 		.driver_data = (void *)ghost_realtek,
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "83SE"),
+		},
+		.driver_data = (void *)ghost_realtek,
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
Signature · 1 line
2.47.3
maintainer
#1 lore raw
Quoted 5 lines · Charles Keepax

There is also a "non-pro" version of the Lenovo Yoga 9i (83SE) which also needs a quirk to disable a non-existent Realtek device. Add this missing quirk.

Need sob by Julian.

- Co-developed-by: states that the patch was co-created by several developers; it is a used to give attribution to co-authors (in addition to the author attributed by the From: tag) when multiple people work on a single patch. Every Co-developed-by: must be immediately followed by a Signed-off-by: of the associated co-author.

Quoted 25 lines
---
 drivers/soundwire/dmi-quirks.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/soundwire/dmi-quirks.c +7 -0
index 32a46a2d90f7c..c7e50873c8739 100644
@@ -192,6 +192,13 @@ static const struct dmi_system_id adr_remap_quirk_table[] = {
 		},
 		.driver_data = (void *)ghost_realtek,
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "83SE"),
+		},
+		.driver_data = (void *)ghost_realtek,
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
Signature · 1 line
2.47.3
Signature · 1 line
~Vinod
#2 lore raw
Quoted 7 lines · Vinod Koul
Quoted 5 lines · Charles Keepax

There is also a "non-pro" version of the Lenovo Yoga 9i (83SE) which also needs a quirk to disable a non-existent Realtek device. Add this missing quirk.

Quoted 7 lines

Need sob by Julian.

- Co-developed-by: states that the patch was co-created by several developers; it is a used to give attribution to co-authors (in addition to the author attributed by the From: tag) when multiple people work on a single patch. Every Co-developed-by: must be immediately followed by a Signed-off-by: of the associated co-author.

Julian, I assume your happy with me adding your signed off by?

Thanks,
Charles

#3 lore raw
Quoted 16 lines · Charles Keepax
Quoted 7 lines · Vinod Koul
Quoted 5 lines · Charles Keepax

There is also a "non-pro" version of the Lenovo Yoga 9i (83SE) which also needs a quirk to disable a non-existent Realtek device. Add this missing quirk.

Quoted 7 lines

Need sob by Julian.

- Co-developed-by: states that the patch was co-created by several developers; it is a used to give attribution to co-authors (in addition to the author attributed by the From: tag) when multiple people work on a single patch. Every Co-developed-by: must be immediately followed by a Signed-off-by: of the associated co-author.

Quoted 4 lines

Julian, I assume your happy with me adding your signed off by?

Thanks,
Charles

As discussions (https://github.com/thesofproject/linux/issues/5801) are still ongoing on if this is actually the best way to handle the issue, I'd hold off on merging right now. I'm adding my signed off anyways because I'm not the expert here.

Julian

#4 lore raw
Quoted 17 lines · Julian Haarmann
Quoted 16 lines · Charles Keepax
Quoted 14 lines · Vinod Koul
Quoted 5 lines · Charles Keepax

There is also a "non-pro" version of the Lenovo Yoga 9i (83SE) which also needs a quirk to disable a non-existent Realtek device. Add this missing quirk.

Need sob by Julian.

- Co-developed-by: states that the patch was co-created by several developers; it is a used to give attribution to co-authors (in addition to the author attributed by the From: tag) when multiple people work on a single patch. Every Co-developed-by: must be immediately followed by a Signed-off-by: of the associated co-author.

Quoted 8 lines
Quoted 4 lines

Julian, I assume your happy with me adding your signed off by?

Thanks,
Charles

As discussions (https://github.com/thesofproject/linux/issues/5801) are still ongoing on if this is actually the best way to handle the issue, I'd hold off on merging right now. I'm adding my signed off anyways because I'm not the expert here.

This patch is fine, its the other patch for the weird unknown device that we are still discussing.

Quoted 1 line

Thanks, I will get a resend out soon. Probably after the merge window closes at this point I guess.

Thanks,
Charles