Skip to contentSkip to conversation

powerpc/pseries/Kconfig: Enable CONFIG_VPA_PMU to be used with KVM

PATCH Superseded Gautam Menghani 4 participants 5 messages Jun 2 – Jun 15

Subsystems (2)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 powerpc/pseries/Kconfig: Enable CONFIG_VPA_PMU to be used with KVM

Currently, CONFIG_VPA_PMU is not enabled by default, and consequently cannot be used for KVM guests at all, unless explicitly enabled on host kernel.

Mark CONFIG_VPA_PMU as "default m" to ensure it is available when KVM is being used.

Fixes 176cda0619b6c ("powerpc/perf: Add perf interface to expose vpa counters")
Cc [email protected] # v6.13+

---
v3 -> v4:
1. Reword the patch description (Harsh)

v2 -> v3:
1. Make CONFIG_VPA_PMU as default m so that it can separately disabled (Sean)

v1 -> v2:
1. Rebased on latest master

 arch/powerpc/platforms/pseries/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/powerpc/platforms/pseries/Kconfig +1 -0
index f7052b131a4c..74910ce3a541 100644
@@ -154,6 +154,7 @@ config HV_PERF_CTRS
 config VPA_PMU
 	tristate "VPA PMU events"
 	depends on KVM_BOOK3S_64_HV && HV_PERF_CTRS
+	default m
 	help
 	  Enable access to the VPA PMU counters via perf. This enables
 	  code that support measurement for KVM on PowerVM(KoP) feature.
Signature · 1 line
2.53.0
Reviewed-by on v4 1/1
#1 lore raw
Quoted 7 lines · Gautam Menghani

Currently, CONFIG_VPA_PMU is not enabled by default, and consequently cannot be used for KVM guests at all, unless explicitly enabled on host kernel.

Mark CONFIG_VPA_PMU as "default m" to ensure it is available when KVM is being used.

Quoted 8 lines
Fixes 176cda0619b6c ("powerpc/perf: Add perf interface to expose vpa counters")
Cc [email protected] # v6.13+

---
v3 -> v4:
1. Reword the patch description (Harsh)

Quoted 22 lines

v2 -> v3:
1. Make CONFIG_VPA_PMU as default m so that it can separately disabled (Sean)

v1 -> v2:
1. Rebased on latest master

  arch/powerpc/platforms/pseries/Kconfig | 1 +
  1 file changed, 1 insertion(+)
arch/powerpc/platforms/pseries/Kconfig +1 -0
index f7052b131a4c..74910ce3a541 100644
@@ -154,6 +154,7 @@ config HV_PERF_CTRS
  config VPA_PMU
  	tristate "VPA PMU events"
  	depends on KVM_BOOK3S_64_HV && HV_PERF_CTRS
+	default m
  	help
  	  Enable access to the VPA PMU counters via perf. This enables
  	  code that support measurement for KVM on PowerVM(KoP) feature.
Reviewed-by on v4 1/1
#2 lore raw
In reply to Gautam Menghani
Quoted 30 lines · Gautam Menghani

Currently, CONFIG_VPA_PMU is not enabled by default, and consequently cannot be used for KVM guests at all, unless explicitly enabled on host kernel.

Mark CONFIG_VPA_PMU as "default m" to ensure it is available when KVM is being used.

Fixes 176cda0619b6c ("powerpc/perf: Add perf interface to expose vpa counters")
Cc [email protected] # v6.13+

---
v3 -> v4:
1. Reword the patch description (Harsh)

v2 -> v3:
1. Make CONFIG_VPA_PMU as default m so that it can separately disabled (Sean)

v1 -> v2:
1. Rebased on latest master

 arch/powerpc/platforms/pseries/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/powerpc/platforms/pseries/Kconfig +0 -0
index f7052b131a4c..74910ce3a541 100644

arch/powerpc/platforms/pseries/Kconfig config HV_PERF_CTRS · line 157

Quoted 4 lines
arch/powerpc/platforms/pseries/Kconfig +1 -0
@@ -154,6 +154,7 @@ config HV_PERF_CTRS
 config VPA_PMU
 	tristate "VPA PMU events"
 	depends on KVM_BOOK3S_64_HV && HV_PERF_CTRS
+	default m

LGTM.

Thanks,
Amit

#3 lore raw
In reply to Gautam Menghani
Quoted 8 lines · Gautam Menghani

Currently, CONFIG_VPA_PMU is not enabled by default, and consequently cannot be used for KVM guests at all, unless explicitly enabled on host kernel.

Mark CONFIG_VPA_PMU as "default m" to ensure it is available when KVM is being used.

Fixes 176cda0619b6c ("powerpc/perf: Add perf interface to expose vpa counters")

Not really a fix per-se. So we need not add this fixes tag.

Quoted 1 line
Cc [email protected] # v6.13+

I think the stable tag like above is sufficient for stable tree maintainers to pick this up.

-ritesh

#4 lore raw
Quoted 6 lines · Ritesh Harjani
Quoted 4 lines · Gautam Menghani

Currently, CONFIG_VPA_PMU is not enabled by default, and consequently cannot be used for KVM guests at all, unless explicitly enabled on host kernel.

Quoted 6 lines
Quoted 4 lines

Mark CONFIG_VPA_PMU as "default m" to ensure it is available when KVM is being used.

Fixes 176cda0619b6c ("powerpc/perf: Add perf interface to expose vpa counters")

Not really a fix per-se. So we need not add this fixes tag.

Ack, will send a v5.

Thanks,
Gautam