dmaengine: dw-edma: Add Xilinx CPM6-DMA DeviceID
Subsystems (3)
PATCH 1/1 dmaengine: dw-edma: Add Xilinx CPM6-DMA DeviceID
From: Devendra K Verma <[email protected]>
Add Device ID for AMD (Xilinx) CPM6 DMA IP.
This IP enables 64 Read and 64 Write Channels.
Adding the relevant dw_edma_pcie_data to use
8 Read and 8 Write Channels for initial commit.
--- drivers/dma/dw-edma/dw-edma-pcie.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
drivers/dma/dw-edma/dw-edma-pcie.c +16 -0
@@ -27,6 +27,7 @@/* AMD MDB (Xilinx) specific defines */ #define PCI_DEVICE_ID_XILINX_B054 0xb054 +#define PCI_DEVICE_ID_XILINX_B00F 0xb00f#define DW_PCIE_XILINX_MDB_VSEC_DMA_ID 0x6#define DW_PCIE_XILINX_MDB_VSEC_ID 0x20
@@ -125,6 +126,19 @@ static const struct dw_edma_pcie_data xilinx_mdb_data = { .rd_ch_cnt = 8, }; +static const struct dw_edma_pcie_data xilinx_cpm6_dma_data = { +/* MDB registers location */ + .rg.bar =BAR_0 , + .rg.off =SZ_4K ,/* 4 Kbytes */ + .rg.sz =SZ_8K ,/* 8 Kbytes */ + +/* Other */ + .mf =EDMA_MF_HDMA_NATIVE , + .irqs =1 , + .wr_ch_cnt =8 , + .rd_ch_cnt =8 , +}; + static void dw_edma_set_chan_region_offset(struct dw_edma_pcie_data *pdata, enum pci_barno bar, off_t start_off, off_t ll_off_gap, size_t ll_size,
@@ -547,6 +561,8 @@ static const struct pci_device_id dw_edma_pcie_id_table[] = { { PCI_DEVICE_DATA(SYNOPSYS, EDDA, &snps_edda_data) }, { PCI_VDEVICE(XILINX, PCI_DEVICE_ID_XILINX_B054), (kernel_ulong_t)&xilinx_mdb_data }, + { PCI_VDEVICE(XILINX, PCI_DEVICE_ID_XILINX_B00F), + (kernel_ulong_t)&xilinx_cpm6_dma_data }, { } };MODULE_DEVICE_TABLE (pci, dw_edma_pcie_id_table);
Signature · 1 line
2.43.0
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Missing pci_free_irq_vectors() cleanup on error paths in dw_edma_pcie_probe() leading to IRQ resource leaks. --
commit a523468dbe7999a5962895c3e0d73662a2938006
Author: Devendra K Verma <[email protected]>
dmaengine: dw-edma: Add Xilinx CPM6-DMA DeviceID
Add Device ID for AMD (Xilinx) CPM6 DMA IP to enable 64 Read and 64 Write Channels. Adds the relevant dw_edma_pcie_data to use 8 Read and 8 Write Channels for the initial commit.
Quoted 4 lines
drivers/dma/dw-edma/dw-edma-pcie.c +0
-0
[ ... ]
drivers/dma/dw-edma/dw-edma-pcie.c static const struct pci_device_id dw_edma_pcie_id_table[] = { · line 565
Quoted 6 lines
drivers/dma/dw-edma/dw-edma-pcie.c +2
-0@@ -547,6 +561,8 @@ static const struct pci_device_id dw_edma_pcie_id_table[] = { { PCI_DEVICE_DATA(SYNOPSYS, EDDA, &snps_edda_data) }, { PCI_VDEVICE(XILINX, PCI_DEVICE_ID_XILINX_B054), (kernel_ulong_t)&xilinx_mdb_data }, + { PCI_VDEVICE(XILINX, PCI_DEVICE_ID_XILINX_B00F), + (kernel_ulong_t)&xilinx_cpm6_dma_data },
[Severity: High]
This is a pre-existing issue, but adding this new device ID exposes the new device to an IRQ resource leak in dw_edma_pcie_probe().
When the device is probed, dw_edma_pcie_probe() successfully allocates IRQs via pci_alloc_irq_vectors(). However, several subsequent error paths return directly without calling pci_free_irq_vectors().
For example, if the pcim_iomap_table() lookup fails:
drivers/dma/dw-edma/dw-edma-pcie.c:dw_edma_pcie_probe() {
...
chip->reg_base = pcim_iomap_table(pdev)[vsec_data->rg.bar];
if (!chip->reg_base)
return -ENOMEM;
...
}Or if the main eDMA probe fails later on:
drivers/dma/dw-edma/dw-edma-pcie.c:dw_edma_pcie_probe() {
...
err = dw_edma_probe(chip);
if (err) {
pci_err(pdev, "eDMA probe failed\n");
return err;
}
...
}Does this code leak the allocated IRQ vectors in these error paths? Because IRQs are a strictly limited resource, repeated probe failures (such as deferred probe or unbind/rebind cycles) could silently exhaust the system's IRQ capacity.
Would it make sense to ensure pci_free_irq_vectors() is called on all error paths after successful allocation before enabling new devices?
Quoted 3 lines
drivers/dma/dw-edma/dw-edma-pcie.c +0
-0{ } };MODULE_DEVICE_TABLE (pci, dw_edma_pcie_id_table);
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Public
The pre-existing issues need to be taken up in a separate series. The changes require separate testing which is not related to the current patch.
Regards,
Devendra
Quoted 87 lines
-----Original Message-----
From: [email protected] <[email protected]>
Sent: Wednesday, June 3, 2026 20:15
To: Verma, Devendra <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v1] dmaengine: dw-edma: Add Xilinx CPM6-DMA DeviceIDThank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Missingpci_free_irq_vectors()cleanup on error paths indw_edma_pcie_probe()leading to IRQ resource leaks.
--commit
a523468dbe7999a5962895c3e0d73662a2938006
Author: Devendra K Verma <[email protected]>dmaengine: dw-edma: Add Xilinx CPM6-DMA DeviceID
Add Device ID for AMD (Xilinx) CPM6 DMA IP to enable 64 Read and 64 Write Channels. Adds the relevant
dw_edma_pcie_datato use 8 Read and 8 Write Channels for the initial commit.Quoted 5 lines
drivers/dma/dw-edma/dw-edma-pcie.c +0
-0[ ... ]
drivers/dma/dw-edma/dw-edma-pcie.c static const struct pci_device_id
Quoted 1 line
drivers/dma/dw-edma/dw-edma-pcie.c +0
-0@@ -547,6 +561,8 @@ static const struct pci_device_iddw_edma_pcie_id_table[] = {
drivers/dma/dw-edma/dw-edma-pcie.c static const struct pci_device_id dw_edma_pcie_id_table[] = { · line 565
Quoted 5 lines
drivers/dma/dw-edma/dw-edma-pcie.c +2
-0{ PCI_DEVICE_DATA(SYNOPSYS, EDDA, &snps_edda_data) }, { PCI_VDEVICE(XILINX, PCI_DEVICE_ID_XILINX_B054), (kernel_ulong_t)&xilinx_mdb_data }, + { PCI_VDEVICE(XILINX, PCI_DEVICE_ID_XILINX_B00F), + (kernel_ulong_t)&xilinx_cpm6_dma_data },[Severity: High]
This is a pre-existing issue, but adding this new device ID exposes the new device to an IRQ resource leak indw_edma_pcie_probe().When the device is probed,
dw_edma_pcie_probe()successfully allocates IRQs viapci_alloc_irq_vectors(). However, several subsequent error paths return directly without callingpci_free_irq_vectors().For example, if the
pcim_iomap_table()lookup fails:drivers/dma/dw-edma/dw-edma-pcie.c:dw_edma_pcie_probe() { ... chip->reg_base = pcim_iomap_table(pdev)[vsec_data->rg.bar]; if (!chip->reg_base) return -ENOMEM; ... }Or if the main eDMA probe fails later on:
drivers/dma/dw-edma/dw-edma-pcie.c:dw_edma_pcie_probe() { ... err = dw_edma_probe(chip); if (err) { pci_err(pdev, "eDMA probe failed\n"); return err; } ... }Does this code leak the allocated IRQ vectors in these error paths? Because IRQs are a strictly limited resource, repeated probe failures (such as deferred probe or unbind/rebind cycles) could silently exhaust the system's IRQ capacity.
Would it make sense to ensure
pci_free_irq_vectors()is called on all error paths after successful allocation before enabling new devices?drivers/dma/dw-edma/dw-edma-pcie.c static const struct pci_device_id dw_edma_pcie_id_table[] = { · line 568
Quoted 3 lines
drivers/dma/dw-edma/dw-edma-pcie.c +0
-0{ } };MODULE_DEVICE_TABLE (pci, dw_edma_pcie_id_table);--
Sashiko AI review · https://sashiko.dev/#/patchset/20260603143158.3243500-
[email protected]?part=1
Vinod Koul
maintainerQuoted 1 line · Devendra
Public
Pls do _not_ Top Post!
Quoted 4 lines
The pre-existing issues need to be taken up in a separate series. The changes require separate testing which is not related to the current patch.
While I agree to that and it wont block the review but would be good if you can fix that as well. Sure affects your users...
Quoted 91 lines
Regards,
DevendraQuoted 87 lines
-----Original Message-----
From: [email protected] <[email protected]>
Sent: Wednesday, June 3, 2026 20:15
To: Verma, Devendra <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v1] dmaengine: dw-edma: Add Xilinx CPM6-DMA DeviceIDThank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Missingpci_free_irq_vectors()cleanup on error paths indw_edma_pcie_probe()leading to IRQ resource leaks.
--commit
a523468dbe7999a5962895c3e0d73662a2938006
Author: Devendra K Verma <[email protected]>dmaengine: dw-edma: Add Xilinx CPM6-DMA DeviceID
Add Device ID for AMD (Xilinx) CPM6 DMA IP to enable 64 Read and 64 Write Channels. Adds the relevant
dw_edma_pcie_datato use 8 Read and 8 Write Channels for the initial commit.Quoted 5 lines
drivers/dma/dw-edma/dw-edma-pcie.c +0
-0[ ... ]
drivers/dma/dw-edma/dw-edma-pcie.c static const struct pci_device_id
Quoted 1 line
drivers/dma/dw-edma/dw-edma-pcie.c +0
-0@@ -547,6 +561,8 @@ static const struct pci_device_iddw_edma_pcie_id_table[] = {
drivers/dma/dw-edma/dw-edma-pcie.c static const struct pci_device_id dw_edma_pcie_id_table[] = { · line 565
Quoted 5 lines
drivers/dma/dw-edma/dw-edma-pcie.c +2
-0{ PCI_DEVICE_DATA(SYNOPSYS, EDDA, &snps_edda_data) }, { PCI_VDEVICE(XILINX, PCI_DEVICE_ID_XILINX_B054), (kernel_ulong_t)&xilinx_mdb_data }, + { PCI_VDEVICE(XILINX, PCI_DEVICE_ID_XILINX_B00F), + (kernel_ulong_t)&xilinx_cpm6_dma_data },[Severity: High]
This is a pre-existing issue, but adding this new device ID exposes the new device to an IRQ resource leak indw_edma_pcie_probe().When the device is probed,
dw_edma_pcie_probe()successfully allocates IRQs viapci_alloc_irq_vectors(). However, several subsequent error paths return directly without callingpci_free_irq_vectors().For example, if the
pcim_iomap_table()lookup fails:drivers/dma/dw-edma/dw-edma-pcie.c:dw_edma_pcie_probe() { ... chip->reg_base = pcim_iomap_table(pdev)[vsec_data->rg.bar]; if (!chip->reg_base) return -ENOMEM; ... }Or if the main eDMA probe fails later on:
drivers/dma/dw-edma/dw-edma-pcie.c:dw_edma_pcie_probe() { ... err = dw_edma_probe(chip); if (err) { pci_err(pdev, "eDMA probe failed\n"); return err; } ... }Does this code leak the allocated IRQ vectors in these error paths? Because IRQs are a strictly limited resource, repeated probe failures (such as deferred probe or unbind/rebind cycles) could silently exhaust the system's IRQ capacity.
Would it make sense to ensure
pci_free_irq_vectors()is called on all error paths after successful allocation before enabling new devices?drivers/dma/dw-edma/dw-edma-pcie.c static const struct pci_device_id dw_edma_pcie_id_table[] = { · line 568
Quoted 3 lines
drivers/dma/dw-edma/dw-edma-pcie.c +0
-0{ } };MODULE_DEVICE_TABLE (pci, dw_edma_pcie_id_table);--
Sashiko AI review · https://sashiko.dev/#/patchset/20260603143158.3243500-
[email protected]?part=1
Signature · 1 line
~Vinod
Public
Quoted 9 lines
-----Original Message-----
From: Vinod Koul <[email protected]>
Sent: Thursday, June 4, 2026 21:06
To: Verma, Devendra <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v1] dmaengine: dw-edma: Add Xilinx CPM6-DMA DeviceID
Quoted 5 lines
Quoted 1 line · Devendra
Public
Pls do _not_ Top Post!
Noted.
Quoted 8 lines
Quoted 4 lines
The pre-existing issues need to be taken up in a separate series. The changes require separate testing which is not related to the current patch.
While I agree to that and it wont block the review but would be good if you can fix that as well. Sure affects your users...
Thanks for the suggestion!
I would like to contribute, in fact for my other reviews I have taken it up for few of the issues reported. I need to evaluate the effort estimates and fix the issues. These issues are noted and will be taken up in due course without derailing the current upgrade to the code.
Quoted 96 lines
Quoted 53 lines
Regards,
DevendraQuoted 49 lines
-----Original Message-----
From: [email protected] <[email protected]>
Sent: Wednesday, June 3, 2026 20:15
To: Verma, Devendra <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v1] dmaengine: dw-edma: Add Xilinx CPM6-DMA DeviceIDThank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Missingpci_free_irq_vectors()cleanup on error paths indw_edma_pcie_probe()leading to IRQ resource leaks.
--commit
a523468dbe7999a5962895c3e0d73662a2938006
Author: Devendra K Verma <[email protected]>dmaengine: dw-edma: Add Xilinx CPM6-DMA DeviceID
Add Device ID for AMD (Xilinx) CPM6 DMA IP to enable 64 Read and 64 Write Channels. Adds the relevant
dw_edma_pcie_datato use 8 Read and 8 Write Channels for the initial commit.Quoted 5 lines
drivers/dma/dw-edma/dw-edma-pcie.c +0
-0[ ... ]
drivers/dma/dw-edma/dw-edma-pcie.c static const struct pci_device_id
Quoted 1 line
drivers/dma/dw-edma/dw-edma-pcie.c +0
-0@@ -547,6 +561,8 @@ static const struct pci_device_iddw_edma_pcie_id_table[] = {
drivers/dma/dw-edma/dw-edma-pcie.c static const struct pci_device_id dw_edma_pcie_id_table[] = { · line 565
Quoted 5 lines
drivers/dma/dw-edma/dw-edma-pcie.c +2
-0{ PCI_DEVICE_DATA(SYNOPSYS, EDDA, &snps_edda_data) }, { PCI_VDEVICE(XILINX, PCI_DEVICE_ID_XILINX_B054), (kernel_ulong_t)&xilinx_mdb_data }, + { PCI_VDEVICE(XILINX, PCI_DEVICE_ID_XILINX_B00F), + (kernel_ulong_t)&xilinx_cpm6_dma_data },[Severity: High]
This is a pre-existing issue, but adding this new device ID exposes the new device to an IRQ resource leak indw_edma_pcie_probe().When the device is probed,
dw_edma_pcie_probe()successfully allocates IRQs viapci_alloc_irq_vectors(). However, several subsequent error paths return directly without calling
pci_free_irq_vectors().Quoted 31 lines
Quoted 31 lines
For example, if the
pcim_iomap_table()lookup fails:drivers/dma/dw-edma/dw-edma-pcie.c:dw_edma_pcie_probe() { ... chip->reg_base = pcim_iomap_table(pdev)[vsec_data->rg.bar]; if (!chip->reg_base) return -ENOMEM; ... }Or if the main eDMA probe fails later on:
drivers/dma/dw-edma/dw-edma-pcie.c:dw_edma_pcie_probe() { ... err = dw_edma_probe(chip); if (err) { pci_err(pdev, "eDMA probe failed\n"); return err; } ... }Does this code leak the allocated IRQ vectors in these error paths? Because IRQs are a strictly limited resource, repeated probe failures (such as deferred probe or unbind/rebind cycles) could silently exhaust the system's IRQ capacity.
Would it make sense to ensure
pci_free_irq_vectors()is called on all error paths after successful allocation before enabling new devices?Quoted 8 lines
Quoted 8 lines
drivers/dma/dw-edma/dw-edma-pcie.c static const struct pci_device_id dw_edma_pcie_id_table[] = { · line 568
Quoted 3 lines
drivers/dma/dw-edma/dw-edma-pcie.c +0
-0{ } };MODULE_DEVICE_TABLE (pci, dw_edma_pcie_id_table);--
Sashiko AI review *
https://sashiko.dev/#/patchset/20260603143158.3243500-
[email protected]?part=1--
~Vinod
Quoted 7 lines · Devendra K Verma
From: Devendra K Verma <[email protected]>
Add Device ID for AMD (Xilinx) CPM6 DMA IP.
This IP enables 64 Read and 64 Write Channels.Adding the relevant
dw_edma_pcie_datato use
8 Read and 8 Write Channels for initial commit.
Nit: wrap at 75 char
Quoted 39 lines
Signed-off-by Devendra K Verma <[email protected]>--- drivers/dma/dw-edma/dw-edma-pcie.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)drivers/dma/dw-edma/dw-edma-pcie.c +14
-0@@ -27,6 +27,7 @@/* AMD MDB (Xilinx) specific defines */ #define PCI_DEVICE_ID_XILINX_B054 0xb054 +#define PCI_DEVICE_ID_XILINX_B00F 0xb00f#define DW_PCIE_XILINX_MDB_VSEC_DMA_ID 0x6#define DW_PCIE_XILINX_MDB_VSEC_ID 0x20@@ -125,6 +126,19 @@ static const struct dw_edma_pcie_data xilinx_mdb_data = { .rd_ch_cnt = 8, }; +static const struct dw_edma_pcie_data xilinx_cpm6_dma_data = { +/* MDB registers location */ + .rg.bar =BAR_0 , + .rg.off =SZ_4K ,/* 4 Kbytes */ + .rg.sz =SZ_8K ,/* 8 Kbytes */ + +/* Other */ + .mf =EDMA_MF_HDMA_NATIVE , + .irqs =1 , + .wr_ch_cnt =8 , + .rd_ch_cnt =8 , +}; + static void dw_edma_set_chan_region_offset(struct dw_edma_pcie_data *pdata, enum pci_barno bar, off_t start_off, off_t ll_off_gap, size_t ll_size,
drivers/dma/dw-edma/dw-edma-pcie.c static const struct pci_device_id dw_edma_pcie_id_table[] = { · line 565
Quoted 5 lines
drivers/dma/dw-edma/dw-edma-pcie.c +2
-0@@ -547,6 +561,8 @@ static const struct pci_device_id dw_edma_pcie_id_table[] = { { PCI_DEVICE_DATA(SYNOPSYS, EDDA, &snps_edda_data) }, { PCI_VDEVICE(XILINX, PCI_DEVICE_ID_XILINX_B054), (kernel_ulong_t)&xilinx_mdb_data }, + { PCI_VDEVICE(XILINX, PCI_DEVICE_ID_XILINX_B00F), + (kernel_ulong_t)&xilinx_cpm6_dma_data },
Please .driver_data = (kernel_ulong_t)&xilinx_cpm6_dma_data
Now Uwe Kleine-König is cleanup this.
See similar thread
https://lore.kernel.org/linux-i3c/[email protected]/
Frank
Quoted 6 lines
drivers/dma/dw-edma/dw-edma-pcie.c +0
-1{ } };MODULE_DEVICE_TABLE (pci, dw_edma_pcie_id_table); --2.43.0
AMD General
Quoted 13 lines
-----Original Message-----
From: Frank Li <[email protected]>
Sent: Friday, June 5, 2026 01:18
To: Verma, Devendra <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]; Simek, Michal <[email protected]>
Subject: Re: [PATCH v1] dmaengine: dw-edma: Add Xilinx CPM6-DMA DeviceIDQuoted 2 lines · Devendra K Verma
From: Devendra K Verma <[email protected]>
Quoted 7 lines
Quoted 5 lines
Add Device ID for AMD (Xilinx) CPM6 DMA IP.
This IP enables 64 Read and 64 Write Channels.Adding the relevant
dw_edma_pcie_datato use
8 Read and 8 Write Channels for initial commit.Nit: wrap at 75 char
Will be taken care in v2.
Quoted 52 lines
drivers/dma/dw-edma/dw-edma-pcie.c static const struct dw_edma_pcie_data
Quoted 21 lines
Signed-off-by Devendra K Verma <[email protected]>--- drivers/dma/dw-edma/dw-edma-pcie.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)drivers/dma/dw-edma/dw-edma-pcie.c +1
-0@@ -27,6 +27,7 @@/* AMD MDB (Xilinx) specific defines */ #define PCI_DEVICE_ID_XILINX_B054 0xb054 +#define PCI_DEVICE_ID_XILINX_B00F 0xb00f#define DW_PCIE_XILINX_MDB_VSEC_DMA_ID 0x6#define DW_PCIE_XILINX_MDB_VSEC_ID 0x20@@ -125,6 +126,19 @@ static const struct dw_edma_pcie_data
xilinx_mdb_data= {Quoted 7 lines
drivers/dma/dw-edma/dw-edma-pcie.c +4
-0.rd_ch_cnt = 8, }; +static const struct dw_edma_pcie_data xilinx_cpm6_dma_data = { +/* MDB registers location */ + .rg.bar =BAR_0 , + .rg.off =SZ_4K ,/* 4 Kbytes */ drivers/dma/dw-edma/dw-edma-pcie.c static const struct dw_edma_pcie_data xilinx_mdb_data = {
Quoted 10 lines
drivers/dma/dw-edma/dw-edma-pcie.c +9
-0+ .rg.sz = SZ_8K, /* 8 Kbytes */ + +/* Other */ + .mf = EDMA_MF_HDMA_NATIVE, + .irqs = 1, + .wr_ch_cnt = 8, + .rd_ch_cnt = 8, +}; + static void dw_edma_set_chan_region_offset(struct dw_edma_pcie_data*pdata,
drivers/dma/dw-edma/dw-edma-pcie.c static const struct dw_edma_pcie_data · line 144
Quoted 2 lines
drivers/dma/dw-edma/dw-edma-pcie.c +0
-0enum pci_barno bar, off_t start_off, off_t ll_off_gap, size_t ll_size, @@ -547,6 +561,8 @@ static
drivers/dma/dw-edma/dw-edma-pcie.c static const struct pci_device_id dw_edma_pcie_id_table[] = { · line 565
Quoted 6 lines
const struct pci_device_id dw_edma_pcie_id_table[] = { { PCI_DEVICE_DATA(SYNOPSYS, EDDA, &snps_edda_data) }, { PCI_VDEVICE(XILINX, PCI_DEVICE_ID_XILINX_B054), (kernel_ulong_t)&xilinx_mdb_data },drivers/dma/dw-edma/dw-edma-pcie.c +2
-0+ {PCI_VDEVICE (XILINX ,PCI_DEVICE_ID_XILINX_B00F ), + (kernel_ulong_t)&xilinx_cpm6_dma_data },Please .driver_data = (kernel_ulong_t)&xilinx_cpm6_dma_data
Quoted 8 lines
Now Uwe Kleine-König is cleanup this.
See similar thread
https://lore.kernel.org/linux-i3c/20260504143324.2122737-2-u.kleine-
[email protected]/Frank
Thanks for the suggestion. Will push the v2 with recommended changes.
Quoted 6 lines
Quoted 6 lines
{ }};
MODULE_DEVICE_TABLE(pci, dw_edma_pcie_id_table);
--
2.43.0