pinctrl: Export pinctrl_get_group_selector()
Subsystems (2)
Linus Walleij
maintainerPATCH 1/1 pinctrl: Export pinctrl_get_group_selector()
The recently added UltraRISC DP1000 is using this symbol, and in a reasonable way as well, so export it.
--- drivers/pinctrl/core.c | 1 + 1 file changed, 1 insertion(+)
drivers/pinctrl/core.c +1 -0
@@ -772,6 +772,7 @@ int pinctrl_get_group_selector(struct pinctrl_dev *pctldev,return -EINVAL ; } +EXPORT_SYMBOL_GPL (pinctrl_get_group_selector);bool pinctrl_gpio_can_use_line (struct gpio_chip *gc,unsigned int offset) {
---
base-commit: e3d967e6ef2f9605b132eabac64e984d884c81cf
change-id: 20260613-export-get-group-selector-d41bc33539c8
Best regards,
Signature · 1 line
Linus Walleij <[email protected]>
Hello,
Quoted 8 lines · Linus Walleij
The recently added UltraRISC DP1000 is using this symbol, and in a reasonable way as well, so export it.
Reported-by Nathan Chancellor <[email protected]>Reported-by kernel test robot <[email protected]>Fixes cb7037924836 ("pinctrl: ultrarisc: Add UltraRISC DP1000 pinctrl driver")Signed-off-by Linus Walleij <[email protected]>
I stumbled over this one, too, and see that
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git for-next
already has that patch. Checkpatch criticises:
WARNING: Reported-by: should be immediately followed by Closes: or Link: with a URL to the report #9:
. Not sure if you consider this relevant to fix (i.e. add:
Link: https://lore.kernel.org/linux-gpio/20260613164847.GA3152104@ax162/
), but if you do, feel free to also add:
Best regards
Uwe
Linus Walleij
maintainerQuoted 12 lines · Uwe Kleine-König
Quoted 8 lines · Linus Walleij
The recently added UltraRISC DP1000 is using this symbol, and in a reasonable way as well, so export it.
Reported-by Nathan Chancellor <[email protected]>Reported-by kernel test robot <[email protected]>Fixes cb7037924836 ("pinctrl: ultrarisc: Add UltraRISC DP1000 pinctrl driver")Signed-off-by Linus Walleij <[email protected]>I stumbled over this one, too, and see that
Quoted 8 lines
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git for-next
already has that patch. Checkpatch criticises:
WARNING: Reported-by: should be immediately followed by Closes: or Link: with a URL to the report #9:
Reported-by Nathan Chancellor <[email protected]>Reported-by kernel test robot <[email protected]>
Now that is just checkpatch being silly, because what in in next looks like this:
pinctrl driver")
Certainly it doesn't matter which order the tags are in. (And if it does, I don't feel it's important...)
Quoted 7 lines
. Not sure if you consider this relevant to fix (i.e. add:
Link: https://lore.kernel.org/linux-gpio/20260613164847.GA3152104@ax162/), but if you do, feel free to also add:
Acked-by Uwe Kleine-König <[email protected]>
I added it, the more the merrier!
Yours,
Linus Walleij
Quoted 12 lines · Linus Walleij
Quoted 6 lines · Uwe Kleine-König
Checkpatch criticises:
WARNING: Reported-by: should be immediately followed by Closes: or Link: with a URL to the report #9:
Reported-by Nathan Chancellor <[email protected]>Reported-by kernel test robot <[email protected]>Now that is just checkpatch being silly, because what in in next looks like this:
Quoted 6 lines
Reported-by Nathan Chancellor <[email protected]>Reported-by kernel test robot <[email protected]>Fixes cb7037924836 ("pinctrl: ultrarisc: Add UltraRISC DP1000pinctrl driver")
Signed-off-by Linus Walleij <[email protected]>
Yeah, so the kernel test robot report has a Closes, but Nathan's doesn't.
Best regards
Uwe
Linus Walleij
maintainerQuoted 20 lines · Uwe Kleine-König
Quoted 12 lines · Linus Walleij
Quoted 6 lines · Uwe Kleine-König
Checkpatch criticises:
WARNING: Reported-by: should be immediately followed by Closes: or Link: with a URL to the report #9:
Reported-by Nathan Chancellor <[email protected]>Reported-by kernel test robot <[email protected]>Now that is just checkpatch being silly, because what in in next looks like this:
Quoted 6 lines
Reported-by Nathan Chancellor <[email protected]>Reported-by kernel test robot <[email protected]>Fixes cb7037924836 ("pinctrl: ultrarisc: Add UltraRISC DP1000pinctrl driver")
Signed-off-by Linus Walleij <[email protected]>
Quoted 2 lines
Yeah, so the kernel test robot report has a Closes, but Nathan's doesn't.
Ah OK I'll put the Link: to Nathans report as a Closes: instead.
Thanks!
Linus Walleij