Skip to contentSkip to conversation

crypto: testmgr - allow authenc(hmac(sha{256,384}),cts(cbc(aes))) in FIPS mode

PATCH In review Ilya Dryomov 3 participants 3 messages Jun 3 – Jun 11

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: testmgr - allow authenc(hmac(sha{256,384}),cts(cbc(aes))) in FIPS mode

hmac(sha256), hmac(sha384) and cts(cbc(aes)) algorithms have been marked as FIPS allowed for years. Mark the respective authenc() constructions per RFC 8009 ("AES Encryption with HMAC-SHA2 for Kerberos 5") as such as well.

SP 800-57 Part 3 Rev. 1 from Jan 2015 [1] links the draft of what became RFC 8009 in Oct 2016 as approved in section 6.3 Procurement Guidance (item/recommendation 3).

[1] https://csrc.nist.gov/pubs/sp/800/57/pt3/r1/final

---
 crypto/testmgr.c | 2 ++
 1 file changed, 2 insertions(+)
crypto/testmgr.c +2 -0
index 4d86efae65b2..7788e6fa80ce 100644
@@ -4215,6 +4215,7 @@ static const struct alg_test_desc alg_test_descs[] = {
 		.alg = "authenc(hmac(sha256),cts(cbc(aes)))",
 		.generic_driver = "authenc(hmac-sha256-lib,cts(cbc(aes-lib)))",
 		.test = alg_test_aead,
+		.fips_allowed = 1,
 		.suite = {
 			.aead = __VECS(krb5_test_aes128_cts_hmac_sha256_128)
 		}
@@ -4256,6 +4257,7 @@ static const struct alg_test_desc alg_test_descs[] = {
 		.alg = "authenc(hmac(sha384),cts(cbc(aes)))",
 		.generic_driver = "authenc(hmac-sha384-lib,cts(cbc(aes-lib)))",
 		.test = alg_test_aead,
+		.fips_allowed = 1,
 		.suite = {
 			.aead = __VECS(krb5_test_aes256_cts_hmac_sha384_192)
 		}
Signature · 1 line
2.54.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 38 lines · Ilya Dryomov

hmac(sha256), hmac(sha384) and cts(cbc(aes)) algorithms have been marked as FIPS allowed for years.  Mark the respective authenc() constructions per RFC 8009 ("AES Encryption with HMAC-SHA2 for Kerberos 5") as such as well.

SP 800-57 Part 3 Rev. 1 from Jan 2015 [1] links the draft of what became RFC 8009 in Oct 2016 as approved in section 6.3 Procurement Guidance (item/recommendation 3).

[1] https://csrc.nist.gov/pubs/sp/800/57/pt3/r1/final

---
 crypto/testmgr.c | 2 ++

 1 file changed, 2 insertions(+)
crypto/testmgr.c +0 -0
index 4d86efae65b2..7788e6fa80ce 100644
@@ -4215,6 +4215,7 @@ static const struct alg_test_desc
 alg_test_descs[] = {
  		.alg = "authenc(hmac(sha256),cts(cbc(aes)))",

  .generic_driver = "authenc(hmac-sha256- lib,cts(cbc(aes-lib)))",
  .test = alg_test_aead,

crypto/testmgr.c +1 -0
+		.fips_allowed = 1,

  .suite = {
  .aead =
__VECS(krb5_test_aes128_cts_hmac_sha256_128)
  }

crypto/testmgr.c +0 -0
@@ -4256,6 +4257,7 @@ static const struct alg_test_desc
 alg_test_descs[] = {
  		.alg = "authenc(hmac(sha384),cts(cbc(aes)))",

  .generic_driver = "authenc(hmac-sha384- lib,cts(cbc(aes-lib)))",
  .test = alg_test_aead,

crypto/testmgr.c +1 -0
+		.fips_allowed = 1,
Quoted 4 lines

  .suite = {
  .aead =
__VECS(krb5_test_aes256_cts_hmac_sha384_192)
  }

Makes sense.

Thanks,
Slava.

maintainer
#2 lore raw
In reply to Ilya Dryomov
Quoted 9 lines · Ilya Dryomov

hmac(sha256), hmac(sha384) and cts(cbc(aes)) algorithms have been marked as FIPS allowed for years. Mark the respective authenc() constructions per RFC 8009 ("AES Encryption with HMAC-SHA2 for Kerberos 5") as such as well.

SP 800-57 Part 3 Rev. 1 from Jan 2015 [1] links the draft of what became RFC 8009 in Oct 2016 as approved in section 6.3 Procurement Guidance (item/recommendation 3).

Quoted 6 lines

[1] https://csrc.nist.gov/pubs/sp/800/57/pt3/r1/final

---
 crypto/testmgr.c | 2 ++
 1 file changed, 2 insertions(+)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt