staging: sm750fb: fix CamelCase variable name Bpp to bpp
PATCH 1/1 staging: sm750fb: fix CamelCase variable name Bpp to bpp
CamelCase variable names violate the kernel coding style guidelines. Rename all occurrences of 'Bpp' to 'bpp' to fix checkpatch warnings.
--- drivers/staging/sm750fb/sm750_accel.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)
drivers/staging/sm750fb/sm750_accel.c +11 -11
@@ -85,7 +85,7 @@ void sm750_hw_set2dformat(struct lynx_accel *accel, int fmt) }int sm750_hw_fillrect (struct lynx_accel *accel, -u32 base,u32 pitch,u32 Bpp, +u32 base,u32 pitch,u32 bpp,u32 x,u32 y,u32 width,u32 height,u32 color,u32 rop) {
@@ -102,14 +102,14 @@ int sm750_hw_fillrect(struct lynx_accel *accel,write_dpr (accel,DE_WINDOW_DESTINATION_BASE , base);/* dpr40 */ write_dpr (accel,DE_PITCH , - ((pitch / Bpp <<DE_PITCH_DESTINATION_SHIFT ) & + ((pitch / bpp <<DE_PITCH_DESTINATION_SHIFT ) &DE_PITCH_DESTINATION_MASK ) | - (pitch / Bpp &DE_PITCH_SOURCE_MASK ));/* dpr10 */ + (pitch / bpp &DE_PITCH_SOURCE_MASK ));/* dpr10 */ write_dpr (accel,DE_WINDOW_WIDTH , - ((pitch / Bpp <<DE_WINDOW_WIDTH_DST_SHIFT ) & + ((pitch / bpp <<DE_WINDOW_WIDTH_DST_SHIFT ) &DE_WINDOW_WIDTH_DST_MASK ) | - (pitch / Bpp &DE_WINDOW_WIDTH_SRC_MASK ));/* dpr44 */ + (pitch / bpp &DE_WINDOW_WIDTH_SRC_MASK ));/* dpr44 */ write_dpr (accel,DE_FOREGROUND , color);/* DPR14 */
@@ -138,7 +138,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel,* @sy: Starting y coordinate of source surface * @dest_base: Address of destination: offset in frame buffer * @dest_pitch: Pitch value of destination surface in BYTE -* @Bpp: Color depth of destination surface +* @bpp: Color depth of destination surface * @dx: Starting x coordinate of destination surface * @dy: Starting y coordinate of destination surface * @width: width of rectangle in pixel value
@@ -149,7 +149,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, unsigned int source_base, unsigned int source_pitch, unsigned int sx, unsigned int sy, unsigned int dest_base, unsigned int dest_pitch, - unsigned int Bpp, unsigned int dx, unsigned int dy, + unsigned int bpp, unsigned int dx, unsigned int dy, unsigned int width, unsigned int height, unsigned int rop2) {
@@ -249,9 +249,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel,* pixel values. Need Byte to pixel conversion. */ write_dpr (accel,DE_PITCH , - ((dest_pitch / Bpp <<DE_PITCH_DESTINATION_SHIFT ) & + ((dest_pitch / bpp <<DE_PITCH_DESTINATION_SHIFT ) &DE_PITCH_DESTINATION_MASK ) | - (source_pitch / Bpp &DE_PITCH_SOURCE_MASK ));/* dpr10 */ + (source_pitch / bpp &DE_PITCH_SOURCE_MASK ));/* dpr10 */ /* * Screen Window width in Pixels.
@@ -259,9 +259,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel,* for a given point. */ write_dpr (accel,DE_WINDOW_WIDTH , - ((dest_pitch / Bpp <<DE_WINDOW_WIDTH_DST_SHIFT ) & + ((dest_pitch / bpp <<DE_WINDOW_WIDTH_DST_SHIFT ) &DE_WINDOW_WIDTH_DST_MASK ) | - (source_pitch / Bpp &DE_WINDOW_WIDTH_SRC_MASK ));/* dpr3c */ + (source_pitch / bpp &DE_WINDOW_WIDTH_SRC_MASK ));/* dpr3c */ if (accel->de_wait () !=0 )return -1 ;
Signature · 1 line
2.54.0
Quoted 7 lines · Siddhesh Sable
CamelCase variable names violate the kernel coding style guidelines. Rename all occurrences of 'Bpp' to 'bpp' to fix checkpatch warnings.
Signed-off-by Siddhesh Sable <[email protected]>--- drivers/staging/sm750fb/sm750_accel.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)
Still not okay. You need to:
* Send a new revision as V2,V3,V4,etc for changes and describe them.
* Wait at least a day to send a new revision.
* Make sure that your patch actually applies. Currently it doesn't apply to Greg's latest staging-testing branch.
Even better, have a look at Dan Carpenter's blog post about this:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Regards,
Ahmet Sezgin Duran
Quoted 5 lines · Siddhesh Sable
CamelCase variable names violate the kernel coding style guidelines. Rename all occurrences of 'Bpp' to 'bpp' to fix checkpatch warnings.
Signed-off-by Siddhesh Sable <[email protected]>---
You're working against an old tree. Work against linux-next or staging-next.
regards,
dan carpenter