usb: dwc3: fix dwc3_readl() and dwc3_writel() calls in dwc3_ulpi_setup()
Subsystems (2)
PATCH v2 1/1 usb: dwc3: fix dwc3_readl() and dwc3_writel() calls in dwc3_ulpi_setup()
The dwc3_ulpi_setup() calls the register read and write calls with dwc3->regs when both these calls take the dwc3 structure directly.
Chnage these two calls to fix the following sparse warning, and possibly a nasty bug in the dwc3_ulpi_setup() code:
drivers/usb/dwc3/core.c:796:45: warning: incorrect type in argument 1 (different address spaces)drivers/usb/dwc3/core.c:796:45: expected struct dwc3 *dwcdrivers/usb/dwc3/core.c:796:45: got void [noderef] __iomem *regsdrivers/usb/dwc3/core.c:798:40: warning: incorrect type in argument 1 (different address spaces)drivers/usb/dwc3/core.c:798:40: expected struct dwc3 *dwcdrivers/usb/dwc3/core.c:798:40: got void [noderef] __iomem *regs
--- drivers/usb/dwc3/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/dwc3/core.c +2 -2
@@ -789,9 +789,9 @@ static void dwc3_ulpi_setup(struct dwc3 *dwc)if (dwc->enable_usb2_transceiver_delay) {for (index =0 ; index < dwc->num_usb2_ports; index++) { - reg =dwc3_readl (dwc->regs,DWC3_GUSB2PHYCFG (index)); + reg =dwc3_readl (dwc,DWC3_GUSB2PHYCFG (index)); reg |=DWC3_GUSB2PHYCFG_XCVRDLY ; -dwc3_writel (dwc->regs,DWC3_GUSB2PHYCFG (index), reg); +dwc3_writel (dwc,DWC3_GUSB2PHYCFG (index), reg); } } }
Signature · 1 line
2.37.2.352.g3c44437643
Quoted 37 lines · Ben Dooks
The
dwc3_ulpi_setup()calls the register read and write calls withdwc3->regswhen both these calls take the dwc3 structure directly.Chnage these two calls to fix the following sparse warning, and possibly a nasty bug in the
dwc3_ulpi_setup()code:
drivers/usb/dwc3/core.c:796:45: warning: incorrect type in argument 1 (different address spaces)drivers/usb/dwc3/core.c:796:45: expected struct dwc3 *dwcdrivers/usb/dwc3/core.c:796:45: got void [noderef]__iomem*regsdrivers/usb/dwc3/core.c:798:40: warning: incorrect type in argument 1 (different address spaces)drivers/usb/dwc3/core.c:798:40: expected struct dwc3 *dwcdrivers/usb/dwc3/core.c:798:40: got void [noderef]__iomem*regsSigned-off-by Ben Dooks <[email protected]>--- drivers/usb/dwc3/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/usb/dwc3/core.c +2
-2@@ -789,9 +789,9 @@ static void dwc3_ulpi_setup(struct dwc3 *dwc)if (dwc->enable_usb2_transceiver_delay) {for (index =0 ; index < dwc->num_usb2_ports; index++) { - reg =dwc3_readl (dwc->regs,DWC3_GUSB2PHYCFG (index)); + reg =dwc3_readl (dwc,DWC3_GUSB2PHYCFG (index)); reg |=DWC3_GUSB2PHYCFG_XCVRDLY ; -dwc3_writel (dwc->regs,DWC3_GUSB2PHYCFG (index), reg); +dwc3_writel (dwc,DWC3_GUSB2PHYCFG (index), reg); } } }Signature · 1 line
2.37.2.352.g3c44437643
Ah! How did we miss this. Thanks for the catch.
Please also add Fixes and Cc stable tags. Add my Ack after you include the tags:
Thanks!
Thinh
Quoted 25 lines · Thinh Nguyen
Quoted 24 lines · Ben Dooks
The
dwc3_ulpi_setup()calls the register read and write calls withdwc3->regswhen both these calls take the dwc3 structure directly.Chnage these two calls to fix the following sparse warning, and possibly a nasty bug in the
dwc3_ulpi_setup()code:
drivers/usb/dwc3/core.c:796:45: warning: incorrect type in argument 1 (different address spaces)drivers/usb/dwc3/core.c:796:45: expected struct dwc3 *dwcdrivers/usb/dwc3/core.c:796:45: got void [noderef]__iomem*regsdrivers/usb/dwc3/core.c:798:40: warning: incorrect type in argument 1 (different address spaces)drivers/usb/dwc3/core.c:798:40: expected struct dwc3 *dwcdrivers/usb/dwc3/core.c:798:40: got void [noderef]__iomem*regsSigned-off-by Ben Dooks <[email protected]>--- drivers/usb/dwc3/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/usb/dwc3/core.c +0
-0@@ -789,9 +789,9 @@ static void dwc3_ulpi_setup(struct dwc3 *dwc)
Quoted 15 lines
Quoted 13 lines
drivers/usb/dwc3/core.c +2
-2if (dwc->enable_usb2_transceiver_delay) {for (index =0 ; index < dwc->num_usb2_ports; index++) { - reg =dwc3_readl (dwc->regs,DWC3_GUSB2PHYCFG (index)); + reg =dwc3_readl (dwc,DWC3_GUSB2PHYCFG (index)); reg |=DWC3_GUSB2PHYCFG_XCVRDLY ; -dwc3_writel (dwc->regs,DWC3_GUSB2PHYCFG (index), reg); +dwc3_writel (dwc,DWC3_GUSB2PHYCFG (index), reg); } } }Signature · 1 line
2.37.2.352.g3c44437643Ah! How did we miss this. Thanks for the catch.
I think it is probably limited hardware as the commit it was introduced in was: dcdc3f399e3b ("usb: dwc3: Support USB3340x ULPI PHY high-speed negotiation.")
Signature · 4 lines
Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html