remoteproc: Use presence checks for syscon props
PATCH 1/1 remoteproc: Use presence checks for syscon props
The OMAP and Keystone remoteproc drivers only need to know whether "ti,bootreg" and "ti,syscon-dev" are present before parsing them. Reading those properties as booleans misrepresents their DT encoding.
Use of_property_present() for the presence tests and keep the existing phandle parsing for the actual property values.
--- drivers/remoteproc/keystone_remoteproc.c | 2 +- drivers/remoteproc/omap_remoteproc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/remoteproc/keystone_remoteproc.c +1 -1
@@ -317,7 +317,7 @@ static int keystone_rproc_of_get_dev_syscon(struct platform_device *pdev,struct device_node *np = pdev->dev.of_node;struct device *dev = &pdev->dev; -if (!of_property_read_bool (np,"ti,syscon-dev" )) { +if (!of_property_present (np,"ti,syscon-dev" )) {dev_err (dev,"ti,syscon-dev property is absent\n" );return -EINVAL ; }
drivers/remoteproc/omap_remoteproc.c +1 -1
@@ -1140,7 +1140,7 @@ static int omap_rproc_get_boot_data(struct platform_device *pdev,if (!data)return -ENODEV ; -if (!of_property_read_bool (np,"ti,bootreg" )) +if (!of_property_present (np,"ti,bootreg" ))return 0 ; oproc->boot_data = devm_kzalloc(&pdev->dev, sizeof(*oproc->boot_data),
Signature · 1 line
2.53.0
Mathieu Poirier
maintainerQuoted 32 lines · Rob Herring (Arm)
The OMAP and Keystone remoteproc drivers only need to know whether "ti,bootreg" and "ti,syscon-dev" are present before parsing them. Reading those properties as booleans misrepresents their DT encoding.
Use
of_property_present()for the presence tests and keep the existing phandle parsing for the actual property values.Assisted-by Codex:gpt-5-5Signed-off-by Rob Herring (Arm) <[email protected]>--- drivers/remoteproc/keystone_remoteproc.c | 2 +- drivers/remoteproc/omap_remoteproc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/remoteproc/keystone_remoteproc.c +1
-1@@ -317,7 +317,7 @@ static int keystone_rproc_of_get_dev_syscon(struct platform_device *pdev,struct device_node *np = pdev->dev.of_node;struct device *dev = &pdev->dev; -if (!of_property_read_bool (np,"ti,syscon-dev" )) { +if (!of_property_present (np,"ti,syscon-dev" )) {dev_err (dev,"ti,syscon-dev property is absent\n" );return -EINVAL ; }drivers/remoteproc/omap_remoteproc.c +0
-0
drivers/remoteproc/omap_remoteproc.c static int omap_rproc_get_boot_data(struct platform_device *pdev, · line 1145
Quoted 7 lines
drivers/remoteproc/omap_remoteproc.c +1
-1@@ -1140,7 +1140,7 @@ static int omap_rproc_get_boot_data(struct platform_device *pdev,if (!data)return -ENODEV ; -if (!of_property_read_bool (np,"ti,bootreg" )) +if (!of_property_present (np,"ti,bootreg" ))return 0 ;
I'll apply this when rc1 comes out next week.
Thanks,
Mathieu
Quoted 4 lines
drivers/remoteproc/omap_remoteproc.c +0
-0oproc->boot_data = devm_kzalloc(&pdev->dev, sizeof(*oproc->boot_data),Signature · 1 line
2.53.0
Quoted 7 lines · Rob Herring (Arm)
The OMAP and Keystone remoteproc drivers only need to know whether "ti,bootreg" and "ti,syscon-dev" are present before parsing them. Reading those properties as booleans misrepresents their DT encoding.
Use
of_property_present()for the presence tests and keep the existing phandle parsing for the actual property values.
Quoted 7 lines
Assisted-by Codex:gpt-5-5Signed-off-by Rob Herring (Arm) <[email protected]>--- drivers/remoteproc/keystone_remoteproc.c | 2 +- drivers/remoteproc/omap_remoteproc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Applied.
Thanks,
Mathieu
Quoted 29 lines
drivers/remoteproc/keystone_remoteproc.c +1
-1@@ -317,7 +317,7 @@ static int keystone_rproc_of_get_dev_syscon(struct platform_device *pdev,struct device_node *np = pdev->dev.of_node;struct device *dev = &pdev->dev; -if (!of_property_read_bool (np,"ti,syscon-dev" )) { +if (!of_property_present (np,"ti,syscon-dev" )) {dev_err (dev,"ti,syscon-dev property is absent\n" );return -EINVAL ; }drivers/remoteproc/omap_remoteproc.c +1
-1@@ -1140,7 +1140,7 @@ static int omap_rproc_get_boot_data(struct platform_device *pdev,if (!data)return -ENODEV ; -if (!of_property_read_bool (np,"ti,bootreg" )) +if (!of_property_present (np,"ti,bootreg" ))return 0 ; oproc->boot_data = devm_kzalloc(&pdev->dev, sizeof(*oproc->boot_data),Signature · 1 line
2.53.0