Skip to contentSkip to conversation

ASoC: SDCA: fix __leXX types in find_sdca_control_range

PATCH In review Ben Dooks 2 participants 3 messages Jun 22

Subsystems (3)
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 ASoC: SDCA: fix __leXX types in find_sdca_control_range

The find_sdca_control_range passes u16 and u32 values to the leXX_to_cpu() functions. Change this type and for the data loop use the le32_to_cpup() to convert the value using a pointer.

Fixes the following sparse warnings:
sound/soc/sdca/sdca_functions.c:868:23: warning: cast to restricted __le16 sound/soc/sdca/sdca_functions.c:869:23: warning: cast to restricted __le16 sound/soc/sdca/sdca_functions.c:877:34: warning: cast to restricted __le32

---
 sound/soc/sdca/sdca_functions.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
sound/soc/sdca/sdca_functions.c +3 -3
index 77940bd6b33c..2e0b0ac4fa13 100644
@@ -847,7 +847,7 @@ static int find_sdca_control_range(struct device *dev,
 {
 	u8 *range_list;
 	int num_range;
-	u16 *limits;
+	__le16 *limits;
 	int i;
 
 	num_range = fwnode_property_count_u8(control_node, "mipi-sdca-control-range");
@@ -863,7 +863,7 @@ static int find_sdca_control_range(struct device *dev,
 	fwnode_property_read_u8_array(control_node, "mipi-sdca-control-range",
 				      range_list, num_range);
 
-	limits = (u16 *)range_list;
+	limits = (__le16 *)range_list;
 
 	range->cols = le16_to_cpu(limits[0]);
 	range->rows = le16_to_cpu(limits[1]);
@@ -874,7 +874,7 @@ static int find_sdca_control_range(struct device *dev,
 		return -EINVAL;
 
 	for (i = 0; i < num_range; i++)
-		range->data[i] = le32_to_cpu(range->data[i]);
+		le32_to_cpup((__le32 *)&range->data[i]);
 
 	return 0;
 }
Signature · 1 line
2.37.2.352.g3c44437643
maintainer Reviewed-by Tested-by on v1 1/1
#1 lore raw
Quoted 5 lines · Ben Dooks

The find_sdca_control_range passes u16 and u32 values to the leXX_to_cpu() functions. Change this type and for the data loop use the le32_to_cpup() to convert the value using a pointer.

Quoted 7 lines

Fixes the following sparse warnings:
sound/soc/sdca/sdca_functions.c:868:23: warning: cast to restricted __le16 sound/soc/sdca/sdca_functions.c:869:23: warning: cast to restricted __le16 sound/soc/sdca/sdca_functions.c:877:34: warning: cast to restricted __le32

---

Thanks,
Charles

maintainer
#2 lore raw
In reply to Ben Dooks
Quoted 12 lines · Ben Dooks

The find_sdca_control_range passes u16 and u32 values to the leXX_to_cpu() functions. Change this type and for the data loop use the le32_to_cpup() to convert the value using a pointer.

Fixes the following sparse warnings:
sound/soc/sdca/sdca_functions.c:868:23: warning: cast to restricted __le16 sound/soc/sdca/sdca_functions.c:869:23: warning: cast to restricted __le16 sound/soc/sdca/sdca_functions.c:877:34: warning: cast to restricted __le32

---

sound/soc/sdca/sdca_functions.c static int find_sdca_control_range(struct device *dev, · line 877

Quoted 3 lines
sound/soc/sdca/sdca_functions.c +1 -1
 	for (i = 0; i < num_range; i++)
-		range->data[i] = le32_to_cpu(range->data[i]);
+		le32_to_cpup((__le32 *)&range->data[i]);

Sorry looking again is this bit right? I think this works because my system is little endian so this is a no op, but don't you still need to assign the value here? Or use le32_to_cpus()?

Thanks,
Charles