ksmbd: compute lease break-in-progress flag on response
Subsystems (2)
Hello Namjae Jeon,
Commit 2b6cbd34ed55 ("ksmbd: compute lease break-in-progress flag on response") from Jun 18, 2026 (linux-next), leads to the following Smatch static checker warning:
fs/smb/server/oplock.c:1446 smb_grant_oplock() warn: inconsistent indenting
fs/smb/server/oplock.c
1434 goto set_lev;
1435 }
1436
1437 if (lctx) {
1438 struct oplock_info *m_opinfo;
1439
1440 /* is lease already granted ? */
1441 m_opinfo = same_client_has_lease(ci, work->conn->ClientGUID,
1442 lctx);
1443 if (m_opinfo) {
1444 lease_put(opinfo->o_lease);
1445 lease_get(m_opinfo->o_lease);--> 1446 opinfo->o_lease = m_opinfo->o_lease;
The commit randomly added an extra tab to these lines...
1447 opinfo->level = m_opinfo->level;
1448 new_lease = false;
1449 opinfo_put(m_opinfo);
1450 goto out;
1451 }
1452 }
1453 prev_opinfo = opinfo_get_list(ci);This email is a free service from the Smatch-CI project [smatch.sf.net].
regards,
dan carpenter
Namjae Jeon
maintainerQuoted 2 lines · Dan Carpenter
Hello Namjae Jeon,
Hi Dan,
Quoted 7 lines
Commit
2b6cbd34ed55("ksmbd: compute lease break-in-progress flag on response") from Jun 18, 2026 (linux-next), leads to the following Smatch static checker warning:
fs/smb/server/oplock.c:1446smb_grant_oplock()
warn: inconsistent indenting
Okay, I will fix it. Thanks for the report.
Quoted 30 lines
fs/smb/server/oplock.c1434 goto set_lev; 1435 } 1436 1437 if (lctx) { 1438 struct oplock_info *m_opinfo; 1439 1440 /* is lease already granted ? */ 1441 m_opinfo = same_client_has_lease(ci, work->conn->ClientGUID, 1442 lctx); 1443 if (m_opinfo) { 1444 lease_put(opinfo->o_lease); 1445 lease_get(m_opinfo->o_lease);--> 1446
opinfo->o_lease=m_opinfo->o_lease;The commit randomly added an extra tab to these lines...
1447 opinfo->level = m_opinfo->level; 1448 new_lease = false; 1449 opinfo_put(m_opinfo); 1450 goto out; 1451 } 1452 } 1453 prev_opinfo = opinfo_get_list(ci);This email is a free service from the Smatch-CI project [smatch.sf.net].
regards,
dan carpenter