Documentation: net/smc: correct old value of smcr_max_recv_wr
Subsystems (4)
PATCH v2 1/1 Documentation: net/smc: correct old value of smcr_max_recv_wr
The smc-sysctl.rst documentation incorrectly stated that the previous hardcoded maximum number of WR buffers on the receive path (smcr_max_recv_wr) was 16. The correct historical value used before the introduction of the sysctl control was 48. Update the documentation to reflect the accurate historical value. Also fix a couple of minor typos.
---
v2: Addressed few minor comments from Alexandra Winter.
--- Documentation/networking/smc-sysctl.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Documentation/networking/smc-sysctl.rst +4 -4
@@ -86,7 +86,7 @@ smcr_max_send_wr - INTEGER Please be aware that all the buffers need to be allocated as a physically continuous array in which each element is a single buffer and has the size of SMC_WR_BUF_SIZE (48) bytes. If the allocation fails, we keep retrying - with half of the buffer count until it is ether successful or (unlikely) + with half of the buffer count until it is either successful or (unlikely) we dip below the old hard coded value which is 16 where we give up much like before having this control.
@@ -100,14 +100,14 @@ smcr_max_recv_wr - INTEGER depending on the workload it can be a bottleneck in a sense that threads have to wait for work request buffers to become available. Before the introduction of this control the maximal number of work request buffers - available on the receive path used to be hard coded to 16. With this control + available on the receive path used to be hard coded to 48. With this control it becomes configurable. The acceptable range is between 2 and 2048. Please be aware that all the buffers need to be allocated as a physically continuous array in which each element is a single buffer and has the size of SMC_WR_BUF_SIZE (48) bytes. If the allocation fails, we keep retrying - with half of the buffer count until it is ether successful or (unlikely) - we dip below the old hard coded value which is 16 where we give up much + with half of the buffer count until it is either successful or (unlikely) + we dip below the old hard coded value which is 48 where we give up much like before having this control. Default: 48
Signature · 1 line
2.51.0
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 6 lines · On Fri, 24 Apr 2026 07:23:36 +0200 you wrote:
The
smc-sysctl.rstdocumentation incorrectly stated that the previous hardcoded maximum number of WR buffers on the receive path (smcr_max_recv_wr) was 16. The correct historical value used before the introduction of the sysctl control was 48. Update the documentation to reflect the accurate historical value. Also fix a couple of minor typos.
Quoted 6 lines
Fixes aef3cdb47bbb net/smc: make wr buffer count configurableReviewed-by Halil Pasic <[email protected]>Reviewed-by Sidraya Jayagond <[email protected]>Signed-off-by Mahanta Jambigi <[email protected]>[...]
Here is the summary with links:
- [net-next,v2] Documentation: net/smc: correct old value of smcr_max_recv_wr
https://git.kernel.org/netdev/net-next/c/790ead939486
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Quoted 7 lines · Mahanta Jambigi
The
smc-sysctl.rstdocumentation incorrectly stated that the previous hardcoded maximum number of WR buffers on the receive path (smcr_max_recv_wr) was 16. The correct historical value used before the introduction of the sysctl control was 48. Update the documentation to reflect the accurate historical value. Also fix a couple of minor typos.Fixes aef3cdb47bbb net/smc: make wr buffer count configurable
This Fixes tag is broken. You probably want:
Other than that, it looks good, the corrected value checks out.
Quoted 7 lines · Breno Leitao
Quoted 6 lines · Mahanta Jambigi
The
smc-sysctl.rstdocumentation incorrectly stated that the previous hardcoded maximum number of WR buffers on the receive path (smcr_max_recv_wr) was 16. The correct historical value used before the introduction of the sysctl control was 48. Update the documentation to reflect the accurate historical value. Also fix a couple of minor typos.
Quoted 5 lines
Quoted 1 line
Fixes aef3cdb47bbb net/smc: make wr buffer count configurableThis Fixes tag is broken. You probably want:
Fixes aef3cdb47bbb ("net/smc: make wr buffer count configurable")
I believe you are talking about the missing parenthesis & double quotes around the commit subject line? I verified the 12-character commit hash points to the correct commit.
Quoted 2 lines
Other than that, it looks good, the corrected value checks out.