macsec: fix promiscuity refcount leak in macsec_dev_open()
Subsystems (4)
PATCH 1/1 macsec: fix promiscuity refcount leak in macsec_dev_open()
When a MACsec interface with IFF_PROMISC set is brought up on top of a device that has hardware offload enabled, macsec_dev_open() first calls dev_set_promiscuity(real_dev, 1) and then propagates the open to the offload device. If that propagation fails, the error path jumps to the clear_allmulti label, which only reverts allmulti and the unicast address. The promiscuity taken on the lower device is never dropped, so real_dev is left permanently stuck in promiscuous mode. Its promiscuity count can no longer be balanced from software.
Add a clear_promisc label that drops the promiscuity reference and route the two offload failure paths to it. The dev_set_promiscuity() failure itself still jumps to clear_allmulti, since on that failure the count was not incremented.
--- drivers/net/macsec.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/net/macsec.c +5 -2
@@ -3615,19 +3615,22 @@ static int macsec_dev_open(struct net_device *dev) ops =macsec_get_ops (netdev_priv (dev), &ctx);if (!ops) { err = -EOPNOTSUPP ; - goto clear_allmulti; + goto clear_promisc; } ctx.secy = &macsec->secy; err =macsec_offload (ops->mdo_dev_open, &ctx);if (err) - goto clear_allmulti; + goto clear_promisc; }if (netif_carrier_ok (real_dev))netif_carrier_on (dev);return 0 ; +clear_promisc: +if (dev->flags &IFF_PROMISC ) +dev_set_promiscuity (real_dev,-1 ); clear_allmulti:if (dev->flags &IFF_ALLMULTI )dev_set_allmulti (real_dev,-1 );
Signature · 1 line
2.43.0
Quoted 14 lines · James Raphael Tiovalen
When a MACsec interface with
IFF_PROMISCset is brought up on top of a device that has hardware offload enabled,macsec_dev_open()first callsdev_set_promiscuity(real_dev, 1)and then propagates the open to the offload device. If that propagation fails, the error path jumps to theclear_allmultilabel, which only reverts allmulti and the unicast address. The promiscuity taken on the lower device is never dropped, soreal_devis left permanently stuck in promiscuous mode. Its promiscuity count can no longer be balanced from software.Add a
clear_promisclabel that drops the promiscuity reference and route the two offload failure paths to it. Thedev_set_promiscuity()failure itself still jumps toclear_allmulti, since on that failure the count was not incremented.
Quoted 6 lines
Fixes 3cf3227a21d1 ("net: macsec: hardware offloading infrastructure")Signed-off-by James Raphael Tiovalen <[email protected]>--- drivers/net/macsec.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
Signature · 1 line
Sabrina
This patch was applied to netdev/net.git (main) by Paolo Abeni <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <[email protected]>:
Quoted 10 lines · On Sun, 5 Jul 2026 19:36:29 +0800 you wrote:
When a MACsec interface with
IFF_PROMISCset is brought up on top of a device that has hardware offload enabled,macsec_dev_open()first callsdev_set_promiscuity(real_dev, 1)and then propagates the open to the offload device. If that propagation fails, the error path jumps to theclear_allmultilabel, which only reverts allmulti and the unicast address. The promiscuity taken on the lower device is never dropped, soreal_devis left permanently stuck in promiscuous mode. Its promiscuity count can no longer be balanced from software.[...]
Here is the summary with links:
- [net] macsec: fix promiscuity refcount leak in macsec_dev_open()
https://git.kernel.org/netdev/net/c/7410d11460eb
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html