Input: maplemouse - set driver data before registering input device
Subsystems (2)
Dmitry Torokhov
maintainerPATCH 1/1 Input: maplemouse - set driver data before registering input device
Set maple driver data before calling input_register_device() to ensure that it is available if the device is opened immediately and the callback is triggered.
Assisted-by Antigravity:gemini-3.5-flash
Signed-off-by Dmitry Torokhov <[email protected]>
--- drivers/input/mouse/maplemouse.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/input/mouse/maplemouse.c +3 -1
@@ -88,6 +88,8 @@ static int probe_maple_mouse(struct device *dev) mse->dev = input_dev; mse->mdev = mdev; +maple_set_drvdata (mdev, mse); +input_set_drvdata (input_dev, mse); input_dev->evbit[0 ] =BIT_MASK (EV_KEY ) |BIT_MASK (EV_REL ); input_dev->keybit[BIT_WORD(BTN_MOUSE)] = BIT_MASK(BTN_LEFT) |
@@ -103,12 +105,12 @@ static int probe_maple_mouse(struct device *dev) goto fail_register; mdev->driver = mdrv; -maple_set_drvdata (mdev, mse);return error; fail_register:input_free_device (input_dev); +maple_set_drvdata (mdev,NULL ); fail_nomem:kfree (mse); fail:
Signature · 5 lines
2.55.0.rc0.799.gd6f94ed593-goog -- Dmitry
Quoted 44 lines · Dmitry Torokhov
Set maple driver data before calling
input_register_device()to ensure that it is available if the device is opened immediately and the callback is triggered.Assisted-by Antigravity:gemini-3.5-flashSigned-off-by Dmitry Torokhov <[email protected]>--- drivers/input/mouse/maplemouse.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/input/mouse/maplemouse.c +3
-1@@ -88,6 +88,8 @@ static int probe_maple_mouse(struct device *dev) mse->dev = input_dev; mse->mdev = mdev; +maple_set_drvdata (mdev, mse); +input_set_drvdata (input_dev, mse); input_dev->evbit[0 ] =BIT_MASK (EV_KEY ) |BIT_MASK (EV_REL ); input_dev->keybit[BIT_WORD(BTN_MOUSE)] = BIT_MASK(BTN_LEFT) |@@ -103,12 +105,12 @@ static int probe_maple_mouse(struct device *dev) goto fail_register; mdev->driver = mdrv; -maple_set_drvdata (mdev, mse);return error; fail_register:input_free_device (input_dev); +maple_set_drvdata (mdev,NULL ); fail_nomem:kfree (mse); fail:Signature · 5 lines
2.55.0.rc0.799.gd6f94ed593-goog -- Dmitry
Tested-by Florian Fuchs <[email protected]>
Regards
Florian