selftests/riscv: ptrace: Fix memory leak of regset_data in vector tests
PATCH 1/1 selftests/riscv: ptrace: Fix memory leak of regset_data in vector tests
The regset_data buffer allocated with calloc() in the parent process of several vector ptrace tests is never freed before returning, causing memory leaks in:
- ptrace_v_not_enabled
- ptrace_v_early_debug
- ptrace_v_syscall_clobbering
- v_csr_invalid/ptrace_v_invalid_values
- v_csr_valid/ptrace_v_valid_values
Add free(regset_data) before kill(pid, SIGKILL) to release the allocated buffer.
--- .../testing/selftests/riscv/vector/validate_v_ptrace.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
tools/testing/selftests/riscv/vector/validate_v_ptrace.c +5 -5
@@ -75,7 +75,7 @@ TEST(ptrace_v_not_enabled)ASSERT_EQ (-1 , ret);/* cleanup */ - +free (regset_data);ASSERT_EQ (0 ,kill (pid,SIGKILL )); } }
@@ -207,7 +207,7 @@ TEST(ptrace_v_early_debug)EXPECT_EQ (vl_csr, regset_data->vl);/* cleanup */ - +free (regset_data);ASSERT_EQ (0 ,kill (pid,SIGKILL )); } }
@@ -331,7 +331,7 @@ TEST(ptrace_v_syscall_clobbering)EXPECT_EQ (0UL , regset_data->vl);/* cleanup */ - +free (regset_data);ASSERT_EQ (0 ,kill (pid,SIGKILL )); } }
@@ -649,7 +649,7 @@ TEST_F(v_csr_invalid, ptrace_v_invalid_values)ASSERT_EQ (ret,-1 );/* cleanup */ - +free (regset_data);ASSERT_EQ (0 ,kill (pid,SIGKILL )); } }
@@ -911,7 +911,7 @@ TEST_F(v_csr_valid, ptrace_v_valid_values)EXPECT_EQ (regset_data->vlenb, vlenb);/* cleanup */ - +free (regset_data);ASSERT_EQ (0 ,kill (pid,SIGKILL )); } }
Signature · 1 line
2.25.1
Quoted 59 lines
The
regset_databuffer allocated withcalloc()in the parent process of several vector ptrace tests is never freed before returning, causing memory leaks in:-
ptrace_v_not_enabled
-ptrace_v_early_debug
-ptrace_v_syscall_clobbering
- v_csr_invalid/ptrace_v_invalid_values
- v_csr_valid/ptrace_v_valid_valuesAdd
free(regset_data)beforekill(pid, SIGKILL)to release the allocated buffer.Signed-off-by Wang Yan <[email protected]>--- .../testing/selftests/riscv/vector/validate_v_ptrace.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)tools/testing/selftests/riscv/vector/validate_v_ptrace.c +4
-4@@ -75,7 +75,7 @@ TEST(ptrace_v_not_enabled)ASSERT_EQ (-1 , ret);/* cleanup */ - +free (regset_data);ASSERT_EQ (0 ,kill (pid,SIGKILL )); } }@@ -207,7 +207,7 @@ TEST(ptrace_v_early_debug)EXPECT_EQ (vl_csr, regset_data->vl);/* cleanup */ - +free (regset_data);ASSERT_EQ (0 ,kill (pid,SIGKILL )); } }@@ -331,7 +331,7 @@ TEST(ptrace_v_syscall_clobbering)EXPECT_EQ (0UL , regset_data->vl);/* cleanup */ - +free (regset_data);ASSERT_EQ (0 ,kill (pid,SIGKILL )); } }@@ -649,7 +649,7 @@ TEST_F(v_csr_invalid, ptrace_v_invalid_values)ASSERT_EQ (ret,-1 );/* cleanup */ - +free (regset_data);ASSERT_EQ (0 ,kill (pid,SIGKILL )); } }
tools/testing/selftests/riscv/vector/validate_v_ptrace.c TEST_F(v_csr_valid, ptrace_v_valid_values) · line 917
Quoted 8 lines
tools/testing/selftests/riscv/vector/validate_v_ptrace.c +1
-1@@ -911,7 +911,7 @@ TEST_F(v_csr_valid, ptrace_v_valid_values)EXPECT_EQ (regset_data->vlenb, vlenb);/* cleanup */ - +free (regset_data);ASSERT_EQ (0 ,kill (pid,SIGKILL )); } }
Thanks !
Regards,
Sergey
Paul Walmsley
maintainerQuoted 10 lines · Wang Yan
The
regset_databuffer allocated withcalloc()in the parent process of several vector ptrace tests is never freed before returning, causing memory leaks in:-
ptrace_v_not_enabled
-ptrace_v_early_debug
-ptrace_v_syscall_clobbering
- v_csr_invalid/ptrace_v_invalid_values
- v_csr_valid/ptrace_v_valid_values
Quoted 4 lines
Add
free(regset_data)beforekill(pid, SIGKILL)to release the allocated buffer.Signed-off-by Wang Yan <[email protected]>
Thanks, queued for v7.2-rc.
- Paul