Skip to contentSkip to conversation

regulator: adp5055: Fix error code in adp5055_of_parse_cb()

PATCH In review Dan Carpenter 2 participants 2 messages Jul 10 – Jul 15

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regulator: adp5055: Fix error code in adp5055_of_parse_cb()

This code accidentally returned the wrong variable instead of a negative error code. Return -EINVAL.

Fixes 147b2a96f24e ("regulator: adp5055: Add driver for adp5055")
---
 drivers/regulator/adp5055-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/adp5055-regulator.c +1 -1
index a79274d530df..194dcfe4f527 100644
@@ -224,7 +224,7 @@ static int adp5055_of_parse_cb(struct device_node *np,
 		adp5055->dvs_limit_upper[id] = pval;
 
 	if (adp5055->dvs_limit_upper[id] > 192000 || adp5055->dvs_limit_upper[id] < 12000)
-		return dev_err_probe(config->dev, adp5055->dvs_limit_upper[id],
+		return dev_err_probe(config->dev, -EINVAL,
 			"Out of range - dvs-limit-upper-microvolt value.");
 
 	ret = of_property_read_u32(np, "adi,dvs-limit-lower-microvolt", &pval);
Signature · 1 line
2.53.0
maintainer
#1 lore raw
Quoted 1 line · Dan Carpenter

regulator: adp5055: Fix error code in adp5055_of_parse_cb()

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-7.3

Thanks!

[1/1] regulator: adp5055: Fix error code in adp5055_of_parse_cb()

      https://git.kernel.org/broonie/regulator/c/153bc959ce0f

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark