wifi: mt76: fix MAC address for non OF pcie cards
Subsystems (2)
PATCH v2 1/1 wifi: mt76: fix MAC address for non OF pcie cards
If seems the check for err is wrong as the proper macaddr gets written to from the EEPROM itself. Meaning checking err from of_get_mac_address is wrong as the proper macaddr has been written by this point.
Closes:
https://lore.kernel.org/linux-wireless/[email protected]/
---
v2: add extra tags and target wireless
drivers/net/wireless/mediatek/mt76/eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/mediatek/mt76/eeprom.c +1 -1
@@ -181,7 +181,7 @@ mt76_eeprom_override(struct mt76_phy *phy)if (err == -EPROBE_DEFER )return err; -if (err) { +if (!is_valid_ether_addr (phy->macaddr)) {eth_random_addr (phy->macaddr); dev_info(dev->dev, "Invalid MAC address, using random address %pM\n",
Signature · 1 line
2.55.0
Hi,
Quoted 34 lines · Rosen Penev
If seems the check for err is wrong as the proper macaddr gets written to from the EEPROM itself. Meaning checking err from
of_get_mac_addressis wrong as the proper macaddr has been written by this point.Reported-by Klara Modin <[email protected]>Reported-by Tobias Klausmann <[email protected]>Closes:
https://lore.kernel.org/linux-wireless/[email protected]/Fixes 31ee1582717e ("wifi: mt76: fix of_get_mac_address error handling")Signed-off-by Rosen Penev <[email protected]>Tested-by Tobias Klausmann <[email protected]>Tested-by Klara Modin <[email protected]>---
v2: add extra tags and target wirelessdrivers/net/wireless/mediatek/mt76/eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/wireless/mediatek/mt76/eeprom.c +1
-1@@ -181,7 +181,7 @@ mt76_eeprom_override(struct mt76_phy *phy)if (err == -EPROBE_DEFER )return err; -if (err) { +if (!is_valid_ether_addr (phy->macaddr)) {eth_random_addr (phy->macaddr); dev_info(dev->dev, "Invalid MAC address, using random address %pM\n",Signature · 1 line
2.55.0
Ping. No one seems to have picked this up yet, but I suppose it is holiday season.
Regards,
Klara Modin
Felix Fietkau
maintainerHi,
Quoted 27 lines · Klara Modin
Quoted 26 lines · Rosen Penev
If seems the check for err is wrong as the proper macaddr gets written to from the EEPROM itself. Meaning checking err from
of_get_mac_addressis wrong as the proper macaddr has been written by this point.Reported-by Klara Modin <[email protected]>Reported-by Tobias Klausmann <[email protected]>Closes:
https://lore.kernel.org/linux-wireless/[email protected]/Fixes 31ee1582717e ("wifi: mt76: fix of_get_mac_address error handling")Signed-off-by Rosen Penev <[email protected]>Tested-by Tobias Klausmann <[email protected]>Tested-by Klara Modin <[email protected]>---
v2: add extra tags and target wirelessdrivers/net/wireless/mediatek/mt76/eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/wireless/mediatek/mt76/eeprom.c +0
-0@@ -181,7 +181,7 @@ mt76_eeprom_override(struct mt76_phy *phy)if (err == -EPROBE_DEFER )return err;
Quoted 11 lines
Quoted 8 lines
drivers/net/wireless/mediatek/mt76/eeprom.c +1
-1-if (err) { +if (!is_valid_ether_addr (phy->macaddr)) {eth_random_addr (phy->macaddr); dev_info(dev->dev, "Invalid MAC address, using random address %pM\n",Signature · 1 line
2.55.0Ping. No one seems to have picked this up yet, but I suppose it is holiday season.
It's in the mt76-fixes pull request that I just sent.
- Felix
Quoted 40 lines · Felix Fietkau
Hi,
Quoted 29 lines · Klara Modin
Quoted 28 lines · Rosen Penev
If seems the check for err is wrong as the proper macaddr gets written to from the EEPROM itself. Meaning checking err from
of_get_mac_addressis wrong as the proper macaddr has been written by this point.Reported-by Klara Modin <[email protected]>Reported-by Tobias Klausmann <[email protected]>Closes:
https://lore.kernel.org/linux-wireless/[email protected]/Fixes 31ee1582717e ("wifi: mt76: fix of_get_mac_address error handling")Signed-off-by Rosen Penev <[email protected]>Tested-by Tobias Klausmann <[email protected]>Tested-by Klara Modin <[email protected]>---
v2: add extra tags and target wirelessdrivers/net/wireless/mediatek/mt76/eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/wireless/mediatek/mt76/eeprom.c +1
-1@@ -181,7 +181,7 @@ mt76_eeprom_override(struct mt76_phy *phy)if (err == -EPROBE_DEFER )return err; -if (err) { +if (!is_valid_ether_addr (phy->macaddr)) {eth_random_addr (phy->macaddr);Quoted 8 lines
Quoted 5 lines
drivers/net/wireless/mediatek/mt76/eeprom.c +0
-0dev_info(dev->dev, "Invalid MAC address, using random address %pM\n",Signature · 1 line
2.55.0Ping. No one seems to have picked this up yet, but I suppose it is holiday season.
Quoted 3 lines
It's in the mt76-fixes pull request that I just sent.
- Felix
Thanks!