Skip to contentSkip to conversation

hw/9pfs: fix O_TRUNC bypass on read-only export

PATCH In review Christian Schoenebeck 2 participants 3 messages Jul 15 – Jul 17

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/9pfs: fix O_TRUNC bypass on read-only export

Guest 9p client opening a file with O_TRUNC on a read-only 9p file system using 9p2000.u protocol version, allowed to bypass 9p server's read-only check, eventually causing file(s) being truncated to empty file(s) on host's read-only export.

Root cause is that 9p server's read-only check is using Linux open flags like O_WRONLY, O_RDWR, O_TRUNC, but checking them against the 9p Topen request's "mode" parameter, which has a different encoding (Otrunc = 0x10 vs. O_TRUNC = 0x200).

Fix this by checking against the "flags" variable instead of the protocol's "mode" option. Because the "flags" variable is already converted to Linux encoding by omode_to_uflags() for 9p2000.u and by get_dotl_openflags() for 9p2000.L protocol version.

Only 9p2000.u was affected by this bypass, 9p2000.L uses the Linux format on protocol level already.

Fixes 2c74c2cb4b ("hw/9pfs: Read-only support for 9p export")

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/4000

---
 hw/9pfs/9p.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
hw/9pfs/9p.c +2 -2
index 3119f01117..474ac6cc40 100644
@@ -2181,8 +2181,8 @@ static void coroutine_fn v9fs_open(void *opaque)
             flags = omode_to_uflags(mode);
         }
         if (is_ro_export(&s->ctx)) {
-            if (mode & O_WRONLY || mode & O_RDWR ||
-                mode & O_APPEND || mode & O_TRUNC) {
+            if (flags & O_WRONLY || flags & O_RDWR ||
+                flags & O_APPEND || flags & O_TRUNC) {
                 err = -EROFS;
                 goto out;
             }
Signature · 1 line
2.47.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 18 lines · Christian Schoenebeck

Guest 9p client opening a file with O_TRUNC on a read-only 9p file system using 9p2000.u protocol version, allowed to bypass 9p server's read-only check, eventually causing file(s) being truncated to empty file(s) on host's read-only export.

Root cause is that 9p server's read-only check is using Linux open flags like O_WRONLY, O_RDWR, O_TRUNC, but checking them against the 9p Topen request's "mode" parameter, which has a different encoding (Otrunc = 0x10 vs. O_TRUNC = 0x200).

Fix this by checking against the "flags" variable instead of the protocol's "mode" option. Because the "flags" variable is already converted to Linux encoding by omode_to_uflags() for 9p2000.u and by get_dotl_openflags() for 9p2000.L protocol version.

Only 9p2000.u was affected by this bypass, 9p2000.L uses the Linux format on protocol level already.

Quoted 6 lines
Fixes 2c74c2cb4b ("hw/9pfs: Read-only support for 9p export")

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/4000

---
 hw/9pfs/9p.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Once a CVE is assigned to this in the gitlab issue, just include that CVE ID in the commit message when doing a pull request.

With regards,
Daniel

Signature · 3 lines
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|
#2 lore raw
In reply to Christian Schoenebeck
Quoted 15 lines · On Wednesday, 15 July 2026 18:10:00 CEST Christian Schoenebeck wrote:

Guest 9p client opening a file with O_TRUNC on a read-only 9p file system using 9p2000.u protocol version, allowed to bypass 9p server's read-only check, eventually causing file(s) being truncated to empty file(s) on host's read-only export.

Root cause is that 9p server's read-only check is using Linux open flags like O_WRONLY, O_RDWR, O_TRUNC, but checking them against the 9p Topen request's "mode" parameter, which has a different encoding (Otrunc = 0x10 vs. O_TRUNC = 0x200).

Fix this by checking against the "flags" variable instead of the protocol's "mode" option. Because the "flags" variable is already converted to Linux encoding by omode_to_uflags() for 9p2000.u and by get_dotl_openflags() for 9p2000.L protocol version.

Quoted 7 lines

Only 9p2000.u was affected by this bypass, 9p2000.L uses the Linux format on protocol level already.

Fixes 2c74c2cb4b ("hw/9pfs: Read-only support for 9p export")

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/4000

---

Queued on 9p.next:
https://github.com/cschoenebeck/qemu/commits/9p.next

Thanks!

/Christian