gpiolib: kill gpio_request_one()
Subsystems (9)
cover gpiolib: kill gpio_request_one()
This is the finilazation of the work announced in the commit 61e1fd2abca4 ("gpiolib: legacy: Make sure we kill gpio_request_one() first"). With this small series we kill gpio_request_one() and leave only two legacy calls devm_gpio_request_one() and gpio_request(), where the managed one has only a few users and high chances to be killed soon as well.
The series is supposed to go via GPIO tree (due to nature of the last patch) with possible immutable branch for others. Please, ack.
Andy Shevchenko (7):
ARM: pxa: spitz: Open code gpio_request_one()
media: em28xx: Split em28xx_pctv_290e_set_lna_gpio() helper
media: em28xx: Open code gpio_request_one()
MIPS: BCM47XX: Open code gpio_request_one()
MIPS: BCM63XX: Remove one time use ephy_reset_gpio_flags
MIPS: BCM63XX: Open code gpio_request_one()
gpiolib: Get rid of not used anymore gpio_request_one()
Documentation/driver-api/gpio/consumer.rst | 2 +- arch/arm/mach-pxa/spitz_pm.c | 3 +- arch/mips/bcm47xx/workarounds.c | 8 ++- arch/mips/bcm63xx/boards/board_bcm963xx.c | 10 ++-- .../include/asm/mach-bcm63xx/board_bcm963xx.h | 3 - drivers/gpio/gpiolib-legacy.c | 31 ---------- drivers/media/usb/em28xx/em28xx-dvb.c | 57 ++++++++----------- include/linux/gpio/legacy.h | 8 --- 8 files changed, 39 insertions(+), 83 deletions(-)
Signature · 1 line
2.50.1
PATCH 1/7 ARM: pxa: spitz: Open code gpio_request_one()
Open code the gpio_request_one() call to be able to kill that API in the follow changes.
--- arch/arm/mach-pxa/spitz_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/mach-pxa/spitz_pm.c +2 -1
@@ -108,7 +108,8 @@ static void spitz_presuspend(void)PGSR2 |=GPIO_bit (SPITZ_GPIO_KEY_STROBE0 );pxa2xx_mfp_config (&gpio18_config,1 ); -gpio_request_one (18 ,GPIOF_OUT_INIT_HIGH ,"Unknown" ); +gpio_request (18 ,"Unknown" ); +gpio_direction_output (18 ,1 );gpio_free (18 );PRER =GPIO_bit (SPITZ_GPIO_KEY_INT );
Signature · 1 line
2.50.1
PATCH 2/7 media: em28xx: Split em28xx_pctv_290e_set_lna_gpio() helper
In reply to Andy ShevchenkoSplit em28xx_pctv_290e_set_lna_gpio() helper in order to deduplicate the GPIO request and setting.
--- drivers/media/usb/em28xx/em28xx-dvb.c | 31 ++++++++++++--------------- 1 file changed, 14 insertions(+), 17 deletions(-)
drivers/media/usb/em28xx/em28xx-dvb.c +14 -17
@@ -737,17 +737,14 @@ static void pctv_520e_init(struct em28xx *dev) regs[i].r, regs[i].len); }; -static int em28xx_pctv_290e_set_lna (struct dvb_frontend *fe) +static int em28xx_pctv_290e_set_lna_gpio (struct em28xx *dev,u32 lna) { -struct dtv_frontend_properties *c = &fe->dtv_property_cache; -struct em28xx_i2c_bus *i2c_bus = fe->dvb->priv; -struct em28xx *dev = i2c_bus->dev;#ifdef CONFIG_GPIOLIB_LEGACY struct em28xx_dvb *dvb = dev->dvb;int ret;unsigned long flags; -if (c->lna ==1 ) +if (lna ==1 ) flags =GPIOF_OUT_INIT_HIGH ;/* enable LNA */ else flags =GPIOF_OUT_INIT_LOW ;/* disable LNA */
@@ -761,11 +758,20 @@ static int em28xx_pctv_290e_set_lna(struct dvb_frontend *fe)return ret;#else dev_warn (&dev->intf->dev,"%s: LNA control is disabled (lna=%u)\n" , -KBUILD_MODNAME , c->lna); +KBUILD_MODNAME , lna);return 0 ;#endif } +static int em28xx_pctv_290e_set_lna (struct dvb_frontend *fe) +{ +struct dtv_frontend_properties *c = &fe->dtv_property_cache; +struct em28xx_i2c_bus *i2c_bus = fe->dvb->priv; +struct em28xx *dev = i2c_bus->dev; + +return em28xx_pctv_290e_set_lna_gpio (dev, c->lna); +} +static int em28xx_pctv_292e_set_lna (struct dvb_frontend *fe) {struct dtv_frontend_properties *c = &fe->dtv_property_cache;
@@ -1920,19 +1926,10 @@ static int em28xx_dvb_init(struct em28xx *dev) goto out_free; } -#ifdef CONFIG_GPIOLIB_LEGACY /* enable LNA for DVB-T, DVB-T2 and DVB-C */ - result =gpio_request_one (dvb->lna_gpio, -GPIOF_OUT_INIT_LOW ,NULL ); -if (result) -dev_err (&dev->intf->dev, -"gpio request failed %d\n" , - result); -else -gpio_free (dvb->lna_gpio); +em28xx_pctv_290e_set_lna_gpio (dev,0 ); - result =0 ;/* continue even set LNA fails */ -#endif +/* continue even set LNA fails */ dvb->fe[0 ]->ops.set_lna = em28xx_pctv_290e_set_lna; }
Signature · 1 line
2.50.1
Re: [PATCH v1 2/7] media: em28xx: Split em28xx_pctv_290e_set_lna_gpio() helper
Quoted 4 lines · Andy Shevchenko
Split
em28xx_pctv_290e_set_lna_gpio()helper in order to deduplicate the GPIO request and setting.Signed-off-by Andy Shevchenko <[email protected]>
Regards,
Hans
Quoted 72 lines
--- drivers/media/usb/em28xx/em28xx-dvb.c | 31 ++++++++++++--------------- 1 file changed, 14 insertions(+), 17 deletions(-)drivers/media/usb/em28xx/em28xx-dvb.c +14
-17@@ -737,17 +737,14 @@ static void pctv_520e_init(struct em28xx *dev) regs[i].r, regs[i].len); }; -static int em28xx_pctv_290e_set_lna (struct dvb_frontend *fe) +static int em28xx_pctv_290e_set_lna_gpio (struct em28xx *dev,u32 lna) { -struct dtv_frontend_properties *c = &fe->dtv_property_cache; -struct em28xx_i2c_bus *i2c_bus = fe->dvb->priv; -struct em28xx *dev = i2c_bus->dev;#ifdef CONFIG_GPIOLIB_LEGACY struct em28xx_dvb *dvb = dev->dvb;int ret;unsigned long flags; -if (c->lna ==1 ) +if (lna ==1 ) flags =GPIOF_OUT_INIT_HIGH ;/* enable LNA */ else flags =GPIOF_OUT_INIT_LOW ;/* disable LNA */ @@ -761,11 +758,20 @@ static int em28xx_pctv_290e_set_lna(struct dvb_frontend *fe)return ret;#else dev_warn (&dev->intf->dev,"%s: LNA control is disabled (lna=%u)\n" , -KBUILD_MODNAME , c->lna); +KBUILD_MODNAME , lna);return 0 ;#endif } +static int em28xx_pctv_290e_set_lna (struct dvb_frontend *fe) +{ +struct dtv_frontend_properties *c = &fe->dtv_property_cache; +struct em28xx_i2c_bus *i2c_bus = fe->dvb->priv; +struct em28xx *dev = i2c_bus->dev; + +return em28xx_pctv_290e_set_lna_gpio (dev, c->lna); +} +static int em28xx_pctv_292e_set_lna (struct dvb_frontend *fe) {struct dtv_frontend_properties *c = &fe->dtv_property_cache;@@ -1920,19 +1926,10 @@ static int em28xx_dvb_init(struct em28xx *dev) goto out_free; } -#ifdef CONFIG_GPIOLIB_LEGACY /* enable LNA for DVB-T, DVB-T2 and DVB-C */ - result =gpio_request_one (dvb->lna_gpio, -GPIOF_OUT_INIT_LOW ,NULL ); -if (result) -dev_err (&dev->intf->dev, -"gpio request failed %d\n" , - result); -else -gpio_free (dvb->lna_gpio); +em28xx_pctv_290e_set_lna_gpio (dev,0 ); - result =0 ;/* continue even set LNA fails */ -#endif +/* continue even set LNA fails */ dvb->fe[0 ]->ops.set_lna = em28xx_pctv_290e_set_lna; }
PATCH 3/7 media: em28xx: Open code gpio_request_one()
In reply to Andy ShevchenkoOpen code the gpio_request_one() call to be able to kill that API in the follow changes.
--- drivers/media/usb/em28xx/em28xx-dvb.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-)
drivers/media/usb/em28xx/em28xx-dvb.c +5 -9
@@ -742,18 +742,14 @@ static int em28xx_pctv_290e_set_lna_gpio(struct em28xx *dev, u32 lna)#ifdef CONFIG_GPIOLIB_LEGACY struct em28xx_dvb *dvb = dev->dvb;int ret; -unsigned long flags; -if (lna ==1 ) - flags =GPIOF_OUT_INIT_HIGH ;/* enable LNA */ -else - flags =GPIOF_OUT_INIT_LOW ;/* disable LNA */ - - ret =gpio_request_one (dvb->lna_gpio, flags,NULL ); -if (ret) + ret =gpio_request (dvb->lna_gpio,NULL ); +if (ret) {dev_err (&dev->intf->dev,"gpio request failed %d\n" , ret); -else + }else { +gpio_direction_output (dvb->lna_gpio, !!(lna ==1 ));gpio_free (dvb->lna_gpio); + }return ret;#else
Signature · 1 line
2.50.1
Re: [PATCH v1 3/7] media: em28xx: Open code gpio_request_one()
Quoted 4 lines · Andy Shevchenko
Open code the
gpio_request_one()call to be able to kill that API in the follow changes.Signed-off-by Andy Shevchenko <[email protected]>
Regards,
Hans
Quoted 32 lines
--- drivers/media/usb/em28xx/em28xx-dvb.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-)drivers/media/usb/em28xx/em28xx-dvb.c +5
-9@@ -742,18 +742,14 @@ static int em28xx_pctv_290e_set_lna_gpio(struct em28xx *dev, u32 lna)#ifdef CONFIG_GPIOLIB_LEGACY struct em28xx_dvb *dvb = dev->dvb;int ret; -unsigned long flags; -if (lna ==1 ) - flags =GPIOF_OUT_INIT_HIGH ;/* enable LNA */ -else - flags =GPIOF_OUT_INIT_LOW ;/* disable LNA */ - - ret =gpio_request_one (dvb->lna_gpio, flags,NULL ); -if (ret) + ret =gpio_request (dvb->lna_gpio,NULL ); +if (ret) {dev_err (&dev->intf->dev,"gpio request failed %d\n" , ret); -else + }else { +gpio_direction_output (dvb->lna_gpio, !!(lna ==1 ));gpio_free (dvb->lna_gpio); + }return ret;#else
PATCH 4/7 MIPS: BCM47XX: Open code gpio_request_one()
In reply to Andy ShevchenkoOpen code the gpio_request_one() call to be able to kill that API in the follow changes.
--- arch/mips/bcm47xx/workarounds.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
arch/mips/bcm47xx/workarounds.c +5 -3
@@ -9,11 +9,13 @@ static void __init bcm47xx_workarounds_enable_usb_power(int usb_power) {int err; - err =gpio_request_one (usb_power,GPIOF_OUT_INIT_HIGH ,"usb_power" ); -if (err) + err =gpio_request (usb_power,"usb_power" ); +if (err) {pr_err ("Failed to request USB power gpio: %d\n" , err); -else + }else { +gpio_direction_output (usb_power,1 );gpio_free (usb_power); + } }void __init bcm47xx_workarounds (void )
Signature · 1 line
2.50.1
Re: [PATCH v1 4/7] MIPS: BCM47XX: Open code gpio_request_one()
Quoted 31 lines · Andy Shevchenko
Open code the
gpio_request_one()call to be able to kill that API in the follow changes.Signed-off-by Andy Shevchenko <[email protected]>--- arch/mips/bcm47xx/workarounds.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)arch/mips/bcm47xx/workarounds.c +5
-3@@ -9,11 +9,13 @@ static void __init bcm47xx_workarounds_enable_usb_power(int usb_power) {int err; - err =gpio_request_one (usb_power,GPIOF_OUT_INIT_HIGH ,"usb_power" ); -if (err) + err =gpio_request (usb_power,"usb_power" ); +if (err) {pr_err ("Failed to request USB power gpio: %d\n" , err); -else + }else { +gpio_direction_output (usb_power,1 );gpio_free (usb_power); + } }void __init bcm47xx_workarounds (void )Signature · 1 line
2.50.1
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
PATCH 5/7 MIPS: BCM63XX: Remove one time use ephy_reset_gpio_flags
In reply to Andy Shevchenkoephy_reset_gpio_flags exists solely to supply polarity to the reset GPIO. But in practice it's kept all the same and currently only a single user present. Drop the member and use hard coded GPIO flags instead.
--- arch/mips/bcm63xx/boards/board_bcm963xx.c | 7 +++---- arch/mips/include/asm/mach-bcm63xx/board_bcm963xx.h | 3 --- 2 files changed, 3 insertions(+), 7 deletions(-)
arch/mips/bcm63xx/boards/board_bcm963xx.c +3 -4
@@ -42,7 +42,7 @@ static struct board_info __initdata board_cvg834g = { .expected_cpu_id = 0x3368, .ephy_reset_gpio = 36, - .ephy_reset_gpio_flags = GPIOF_OUT_INIT_HIGH, + .has_pci = 1, .has_uart0 = 1, .has_uart1 = 1,
@@ -903,9 +903,8 @@ int __init board_register_devices(void)platform_device_register (&bcm63xx_gpio_leds); -if (board.ephy_reset_gpio && board.ephy_reset_gpio_flags) -gpio_request_one (board.ephy_reset_gpio, - board.ephy_reset_gpio_flags,"ephy-reset" ); +if (board.ephy_reset_gpio) +gpio_request_one (board.ephy_reset_gpio,GPIOF_OUT_INIT_HIGH ,"ephy-reset" );return 0 ; }
arch/mips/include/asm/mach-bcm63xx/board_bcm963xx.h +0 -3
@@ -46,9 +46,6 @@ struct board_info {/* External PHY reset GPIO */ unsigned int ephy_reset_gpio; - -/* External PHY reset GPIO flags from gpio.h */ - unsigned long ephy_reset_gpio_flags; };#endif /* ! BOARD_BCM963XX_H_ */
Signature · 1 line
2.50.1
Re: [PATCH v1 5/7] MIPS: BCM63XX: Remove one time use ephy_reset_gpio_flags
Quoted 51 lines · Andy Shevchenko
ephy_reset_gpio_flagsexists solely to supply polarity to the reset GPIO. But in practice it's kept all the same and currently only a single user present. Drop the member and use hard coded GPIO flags instead.Signed-off-by Andy Shevchenko <[email protected]>--- arch/mips/bcm63xx/boards/board_bcm963xx.c | 7 +++---- arch/mips/include/asm/mach-bcm63xx/board_bcm963xx.h | 3 --- 2 files changed, 3 insertions(+), 7 deletions(-)arch/mips/bcm63xx/boards/board_bcm963xx.c +3
-4@@ -42,7 +42,7 @@ static struct board_info __initdata board_cvg834g = { .expected_cpu_id = 0x3368, .ephy_reset_gpio = 36, - .ephy_reset_gpio_flags = GPIOF_OUT_INIT_HIGH, + .has_pci = 1, .has_uart0 = 1, .has_uart1 = 1,@@ -903,9 +903,8 @@ int __init board_register_devices(void)platform_device_register (&bcm63xx_gpio_leds); -if (board.ephy_reset_gpio && board.ephy_reset_gpio_flags) -gpio_request_one (board.ephy_reset_gpio, - board.ephy_reset_gpio_flags,"ephy-reset" ); +if (board.ephy_reset_gpio) +gpio_request_one (board.ephy_reset_gpio,GPIOF_OUT_INIT_HIGH ,"ephy-reset" );return 0 ; }arch/mips/include/asm/mach-bcm63xx/board_bcm963xx.h +0
-3@@ -46,9 +46,6 @@ struct board_info {/* External PHY reset GPIO */ unsigned int ephy_reset_gpio; - -/* External PHY reset GPIO flags from gpio.h */ - unsigned long ephy_reset_gpio_flags; };#endif /* ! BOARD_BCM963XX_H_ */ Signature · 1 line
2.50.1
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
PATCH 6/7 MIPS: BCM63XX: Open code gpio_request_one()
In reply to Andy ShevchenkoOpen code the gpio_request_one() call to be able to kill that API in the follow changes.
--- arch/mips/bcm63xx/boards/board_bcm963xx.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
arch/mips/bcm63xx/boards/board_bcm963xx.c +5 -2
@@ -903,8 +903,11 @@ int __init board_register_devices(void)platform_device_register (&bcm63xx_gpio_leds); -if (board.ephy_reset_gpio) -gpio_request_one (board.ephy_reset_gpio,GPIOF_OUT_INIT_HIGH ,"ephy-reset" ); +if (board.ephy_reset_gpio) { +gpio_request (board.ephy_reset_gpio,"ephy-reset" ); +gpio_direction_output (board.ephy_reset_gpio,1 ); +gpio_free (board.ephy_reset_gpio); + }return 0 ; }
Signature · 1 line
2.50.1
Re: [PATCH v1 6/7] MIPS: BCM63XX: Open code gpio_request_one()
Quoted 28 lines · Andy Shevchenko
Open code the
gpio_request_one()call to be able to kill that API in the follow changes.Signed-off-by Andy Shevchenko <[email protected]>--- arch/mips/bcm63xx/boards/board_bcm963xx.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)arch/mips/bcm63xx/boards/board_bcm963xx.c +5
-2@@ -903,8 +903,11 @@ int __init board_register_devices(void)platform_device_register (&bcm63xx_gpio_leds); -if (board.ephy_reset_gpio) -gpio_request_one (board.ephy_reset_gpio,GPIOF_OUT_INIT_HIGH ,"ephy-reset" ); +if (board.ephy_reset_gpio) { +gpio_request (board.ephy_reset_gpio,"ephy-reset" ); +gpio_direction_output (board.ephy_reset_gpio,1 ); +gpio_free (board.ephy_reset_gpio); + }return 0 ; }Signature · 1 line
2.50.1
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
PATCH 7/7 gpiolib: Get rid of not used anymore gpio_request_one()
In reply to Andy ShevchenkoNo more users.
--- Documentation/driver-api/gpio/consumer.rst | 2 +- drivers/gpio/gpiolib-legacy.c | 31 ---------------------- include/linux/gpio/legacy.h | 8 ------ 3 files changed, 1 insertion(+), 40 deletions(-)
Documentation/driver-api/gpio/consumer.rst +1 -1
@@ -463,7 +463,7 @@ and vice-versa:: The GPIO number returned by desc_to_gpio() can safely be used as a parameter of the gpio\_*() functions for as long as the GPIO descriptor `desc` is not freed. All the same, a GPIO number passed to gpio_to_desc() must first be properly -acquired using e.g. gpio_request_one(), and the returned GPIO descriptor is only +acquired using e.g. gpio_request(), and the returned GPIO descriptor is only considered valid until that GPIO number is released using gpio_free(). Freeing a GPIO obtained by one API with the other API is forbidden and an
drivers/gpio/gpiolib-legacy.c +0 -31
@@ -21,37 +21,6 @@ void gpio_free(unsigned gpio) }EXPORT_SYMBOL_GPL (gpio_free); -/** -* gpio_request_one - request a single GPIO with initial configuration -* @gpio: the GPIO number -* @flags: GPIO configuration as specified by GPIOF_* -* @label: a literal description string of this GPIO -* -* **DEPRECATED** This function is deprecated and must not be used in new code. -* -* Returns: -* 0 on success, or negative errno on failure. -*/ -int gpio_request_one (unsigned gpio,unsigned long flags,const char *label) -{ -int err; - - err =gpio_request (gpio, label); -if (err) -return err; - -if (flags &GPIOF_IN ) - err =gpio_direction_input (gpio); -else - err =gpio_direction_output (gpio, !!(flags &GPIOF_OUT_INIT_HIGH )); - -if (err) -gpio_free (gpio); - -return err; -} -EXPORT_SYMBOL_GPL (gpio_request_one); -/* * **DEPRECATED** This function is deprecated and must not be used in new code. */
include/linux/gpio/legacy.h +0 -8
@@ -82,8 +82,6 @@ static inline int gpio_to_irq(unsigned gpio)return gpiod_to_irq (gpio_to_desc (gpio)); } -int gpio_request_one (unsigned gpio,unsigned long flags,const char *label); -int devm_gpio_request_one (struct device *dev,unsigned gpio,unsigned long flags,const char *label);
@@ -104,12 +102,6 @@ static inline int gpio_request(unsigned gpio, const char *label)return -ENOSYS ; } -static inline int gpio_request_one (unsigned gpio, -unsigned long flags,const char *label) -{ -return -ENOSYS ; -} -static inline void gpio_free (unsigned gpio) {might_sleep ();
Signature · 1 line
2.50.1
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 14 lines · Patchwork Integration
Dear Andy Shevchenko:
Thanks for your patches! Unfortunately the Media CI robot detected some issues:
# Test media-patchstyle:rc core
fatal: Not a valid object name8dac27bfa2f9
/builds/linux-media/users/patchwork/include/media/rc-map.h:265: duplicate value for rc-hauppaugerc-videomate-m1f.c: name #defineRC_MAP_VIDEOMATE_K100does not match rc-videomate-k100 /builds/linux-media/users/patchwork/Documentation/devicetree/bindings/media/rc.yaml:125: expecting rc-rc6-mce found rc-rc5-tv /builds/linux-media/users/patchwork/Documentation/devicetree/bindings/media/rc.yaml:126: expecting rc-real-audio-220-32-keys found rc-rc6-mce /builds/linux-media/users/patchwork/Documentation/devicetree/bindings/media/rc.yaml:127: expecting rc-reddo found rc-real-audio-220-32-keys /builds/linux-media/users/patchwork/Documentation/devicetree/bindings/media/rc.yaml:128: expecting rc-siemens-gigaset-rc20 found rc-reddo /builds/linux-media/users/patchwork/Documentation/devicetree/bindings/media/rc.yaml:150: expecting rc-vega-s9x found rc-videomate-k100
Quoted 8 lines
/builds/linux-media/users/patchwork/Documentation/devicetree/bindings/media/rc.yaml:151: expecting rc-videomate-m1f found rc-videomate-s350 /builds/linux-media/users/patchwork/Documentation/devicetree/bindings/media/rc.yaml:152: expecting rc-videomate-s350 found rc-videomate-tv-pvr /builds/linux-media/users/patchwork/Documentation/devicetree/bindings/media/rc.yaml:153: expecting rc-videomate-tv-pvr found rc-videostrong-kii-pro /builds/linux-media/users/patchwork/Documentation/devicetree/bindings/media/rc.yaml:154: expecting rc-videostrong-kii-pro found rc-vega-s9x /builds/linux-media/users/patchwork/include/media/rc-map.h:312: rc-rc5-tv does not exist /builds/linux-media/users/patchwork/include/media/rc-map.h:339: rc-videomate-k100 does not exist /builds/linux-media/users/patchwork/include/media/rc-map.h: missing entry for rc-videomate-m1f
errors: 14
What is this?
Quoted 13 lines
Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.
For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/105065189/artifacts/report.htm .---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.htmlIf you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all to this message.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Hi Andy
Quoted 25 lines · Andy Shevchenko
Quoted 14 lines · Patchwork Integration
Dear Andy Shevchenko:
Thanks for your patches! Unfortunately the Media CI robot detected some issues:
# Test media-patchstyle:rc core
fatal: Not a valid object name8dac27bfa2f9
/builds/linux-media/users/patchwork/include/media/rc-map.h:265: duplicate value for rc-hauppaugerc-videomate-m1f.c: name #defineRC_MAP_VIDEOMATE_K100does not match rc-videomate-k100 /builds/linux-media/users/patchwork/Documentation/devicetree/bindings/media/rc.yaml:125: expecting rc-rc6-mce found rc-rc5-tv /builds/linux-media/users/patchwork/Documentation/devicetree/bindings/media/rc.yaml:126: expecting rc-real-audio-220-32-keys found rc-rc6-mce /builds/linux-media/users/patchwork/Documentation/devicetree/bindings/media/rc.yaml:127: expecting rc-reddo found rc-real-audio-220-32-keys /builds/linux-media/users/patchwork/Documentation/devicetree/bindings/media/rc.yaml:128: expecting rc-siemens-gigaset-rc20 found rc-reddo /builds/linux-media/users/patchwork/Documentation/devicetree/bindings/media/rc.yaml:150: expecting rc-vega-s9x found rc-videomate-k100Quoted 8 lines
/builds/linux-media/users/patchwork/Documentation/devicetree/bindings/media/rc.yaml:151: expecting rc-videomate-m1f found rc-videomate-s350 /builds/linux-media/users/patchwork/Documentation/devicetree/bindings/media/rc.yaml:152: expecting rc-videomate-s350 found rc-videomate-tv-pvr /builds/linux-media/users/patchwork/Documentation/devicetree/bindings/media/rc.yaml:153: expecting rc-videomate-tv-pvr found rc-videostrong-kii-pro /builds/linux-media/users/patchwork/Documentation/devicetree/bindings/media/rc.yaml:154: expecting rc-videostrong-kii-pro found rc-vega-s9x /builds/linux-media/users/patchwork/include/media/rc-map.h:312: rc-rc5-tv does not exist /builds/linux-media/users/patchwork/include/media/rc-map.h:339: rc-videomate-k100 does not exist /builds/linux-media/users/patchwork/include/media/rc-map.h: missing entry for rc-videomate-m1f
errors: 14
Quoted 1 line
What is this?
Please ignore. Media-CI applied your patch to the fixes tree instead of the next tree and "fixes" has some issues with the rc-checks
Sorry about that.
Quoted 21 lines
Quoted 7 lines
Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.
For more details, check the full report at:
https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/105065189/artifacts/report.htm .Quoted 7 lines
---
Check the latest rules for contributing your patches at:
https://docs.kernel.org/driver-api/media/maintainer-entry-profile.htmlIf you believe that the CI is wrong, kindly open an issue at
https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all to this message.--
With Best Regards,
Andy Shevchenko
Signature · 1 line
Ricardo Ribalda
Quoted 3 lines · Ricardo Ribalda Delgado
Quoted 1 line · Andy Shevchenko
On Wed, Jul 15, 2026 at 02:29:38PM -0700, Patchwork Integration wrote:
...
Quoted 9 lines
Quoted 4 lines
Quoted 2 lines
Thanks for your patches! Unfortunately the Media CI robot detected some issues:
What is this?
Please ignore. Media-CI applied your patch to the fixes tree instead of the next tree and "fixes" has some issues with the rc-checks
Sorry about that.
I see, thanks for explanation. Can somebody Review/Ack the media patches, please?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 8 lines · Andy Shevchenko
This is the finilazation of the work announced in the commit
61e1fd2abca4("gpiolib: legacy: Make sure we killgpio_request_one()first"). With this small series we killgpio_request_one()and leave only two legacy callsdevm_gpio_request_one()andgpio_request(), where the managed one has only a few users and high chances to be killed soon as well.The series is supposed to go via GPIO tree (due to nature of the last patch) with possible immutable branch for others. Please, ack.
The kernel is clearly a better place after these patches than before it, so:
Yours,
Linus Walleij
Quoted 9 lines · Linus Walleij
Quoted 6 lines · Andy Shevchenko
This is the finilazation of the work announced in the commit
61e1fd2abca4("gpiolib: legacy: Make sure we killgpio_request_one()first"). With this small series we killgpio_request_one()and leave only two legacy callsdevm_gpio_request_one()andgpio_request(), where the managed one has only a few users and high chances to be killed soon as well.
Quoted 5 lines
Quoted 2 lines
The series is supposed to go via GPIO tree (due to nature of the last patch) with possible immutable branch for others. Please, ack.
The kernel is clearly a better place after these patches than before it, so:
Reviewed-by Linus Walleij <[email protected]>
Thanks!
Bart, anything needs to be done for this series to go in?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Bartosz Golaszewski
maintainerQuoted 10 lines · Andy Shevchenko
Quoted 9 lines · Linus Walleij
Quoted 6 lines · Andy Shevchenko
This is the finilazation of the work announced in the commit
61e1fd2abca4("gpiolib: legacy: Make sure we killgpio_request_one()first"). With this small series we killgpio_request_one()and leave only two legacy callsdevm_gpio_request_one()andgpio_request(), where the managed one has only a few users and high chances to be killed soon as well.
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines
The series is supposed to go via GPIO tree (due to nature of the last patch) with possible immutable branch for others. Please, ack.
The kernel is clearly a better place after these patches than before it, so:
Reviewed-by Linus Walleij <[email protected]>Thanks!
Bart, anything needs to be done for this series to go in?
We don't have Acks from MIPS maintainers. :(
Bart
Quoted 15 lines · Bartosz Golaszewski
Quoted 13 lines · Andy Shevchenko
Quoted 12 lines · Linus Walleij
Quoted 8 lines · Andy Shevchenko
This is the finilazation of the work announced in the commit
61e1fd2abca4("gpiolib: legacy: Make sure we killgpio_request_one()first"). With this small series we killgpio_request_one()and leave only two legacy callsdevm_gpio_request_one()andgpio_request(), where the managed one has only a few users and high chances to be killed soon as well.The series is supposed to go via GPIO tree (due to nature of the last patch) with possible immutable branch for others. Please, ack.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
The kernel is clearly a better place after these patches than before it, so:
Reviewed-by Linus Walleij <[email protected]>Thanks!
Bart, anything needs to be done for this series to go in?We don't have Acks from MIPS maintainers. :(
Hmm... Usually Thomas is quick. Thomas, can you give your Ack if you agree with the changes, please?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Thomas Bogendoerfer
maintainerQuoted 19 lines · Andy Shevchenko
Quoted 18 lines · Bartosz Golaszewski
Quoted 16 lines · Andy Shevchenko
Quoted 14 lines · Linus Walleij
Quoted 8 lines · Andy Shevchenko
This is the finilazation of the work announced in the commit
61e1fd2abca4("gpiolib: legacy: Make sure we killgpio_request_one()first"). With this small series we killgpio_request_one()and leave only two legacy callsdevm_gpio_request_one()andgpio_request(), where the managed one has only a few users and high chances to be killed soon as well.The series is supposed to go via GPIO tree (due to nature of the last patch) with possible immutable branch for others. Please, ack.
The kernel is clearly a better place after these patches than before it, so:
Reviewed-by Linus Walleij <[email protected]>
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Thanks!
Bart, anything needs to be done for this series to go in?We don't have Acks from MIPS maintainers. :(
Hmm... Usually Thomas is quick. Thomas, can you give your Ack if you agree with the changes, please?
sorry, I was on vacation.
I'm fine with the changes, but I'm not, if they still apply cleanly...
Thomas.
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
Quoted 23 lines · Thomas Bogendoerfer
Quoted 22 lines · Andy Shevchenko
Quoted 21 lines · Bartosz Golaszewski
Quoted 18 lines · Andy Shevchenko
Quoted 9 lines · Linus Walleij
Quoted 6 lines · Andy Shevchenko
This is the finilazation of the work announced in the commit
61e1fd2abca4("gpiolib: legacy: Make sure we killgpio_request_one()first"). With this small series we killgpio_request_one()and leave only two legacy callsdevm_gpio_request_one()andgpio_request(), where the managed one has only a few users and high chances to be killed soon as well.Quoted 5 lines
Quoted 2 lines
The series is supposed to go via GPIO tree (due to nature of the last patch) with possible immutable branch for others. Please, ack.
The kernel is clearly a better place after these patches than before it, so:
Reviewed-by Linus Walleij <[email protected]>Thanks!
Bart, anything needs to be done for this series to go in?
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
We don't have Acks from MIPS maintainers. :(
Hmm... Usually Thomas is quick. Thomas, can you give your Ack if you agree with the changes, please?
sorry, I was on vacation.
No problem, we now have more time :-)
Quoted 1 line
I'm fine with the changes, but I'm not, if they still apply cleanly...
Can you provide your formal Acked-by?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 6 lines · Andy Shevchenko
Quoted 5 lines · Thomas Bogendoerfer
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Bartosz Golaszewski
Quoted 1 line · Andy Shevchenko
On Fri, Jul 24, 2026 at 11:40:59PM +0200, Linus Walleij wrote:
...
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Bart, anything needs to be done for this series to go in?
We don't have Acks from MIPS maintainers. :(
Hmm... Usually Thomas is quick. Thomas, can you give your Ack if you agree with the changes, please?
Quoted 7 lines
Quoted 1 line
sorry, I was on vacation.
No problem, we now have more time :-)
Quoted 1 line
I'm fine with the changes, but I'm not, if they still apply cleanly...
Can you provide your formal Acked-by?
Maybe I misunderstood you, but FWIW I have applied it on top of today's Linux Next and there is no conflicts.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Thomas Bogendoerfer
maintainerQuoted 19 lines · Andy Shevchenko
Quoted 6 lines · Andy Shevchenko
Quoted 5 lines · Thomas Bogendoerfer
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Bartosz Golaszewski
Quoted 1 line · Andy Shevchenko
On Fri, Jul 24, 2026 at 11:40:59PM +0200, Linus Walleij wrote:
...
Quoted 9 lines
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Bart, anything needs to be done for this series to go in?
We don't have Acks from MIPS maintainers. :(
Hmm... Usually Thomas is quick. Thomas, can you give your Ack if you agree with the changes, please?
sorry, I was on vacation.
Quoted 8 lines
Quoted 5 lines
No problem, we now have more time :-)
Quoted 1 line
I'm fine with the changes, but I'm not, if they still apply cleanly...
Can you provide your formal Acked-by?
Maybe I misunderstood you, but FWIW I have applied it on top of today's Linux Next and there is no conflicts.
ok good, I probably mixed things up :-/
Thomas.
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
Quoted 8 lines · Thomas Bogendoerfer
Quoted 7 lines · Andy Shevchenko
Quoted 6 lines · Andy Shevchenko
Quoted 5 lines · Thomas Bogendoerfer
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Bartosz Golaszewski
Quoted 1 line · Andy Shevchenko
On Fri, Jul 24, 2026 at 11:40:59PM +0200, Linus Walleij wrote:
...
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Bart, anything needs to be done for this series to go in?
We don't have Acks from MIPS maintainers. :(
Hmm... Usually Thomas is quick. Thomas, can you give your Ack if you agree with the changes, please?
sorry, I was on vacation.
No problem, we now have more time :-)
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
I'm fine with the changes, but I'm not, if they still apply cleanly...
Can you provide your formal Acked-by?
Maybe I misunderstood you, but FWIW I have applied it on top of today's Linux Next and there is no conflicts.
ok good, I probably mixed things up :-/
Thanks for tagging the relevant changes!
Bart, I guess now we all set for this series to go in.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Bartosz Golaszewski
AppliedQuoted 10 lines · Andy Shevchenko
This is the finilazation of the work announced in the commit
61e1fd2abca4("gpiolib: legacy: Make sure we killgpio_request_one()first"). With this small series we killgpio_request_one()and leave only two legacy callsdevm_gpio_request_one()andgpio_request(), where the managed one has only a few users and high chances to be killed soon as well.The series is supposed to go via GPIO tree (due to nature of the last patch) with possible immutable branch for others. Please, ack.
[...]
Applied, thanks!
[1/7] ARM: pxa: spitz: Open code gpio_request_one()
https://git.kernel.org/brgl/c/e4c5145a8c42b1ff8c36d209b265d65005fb2a8e [2/7] media: em28xx: Split em28xx_pctv_290e_set_lna_gpio() helper https://git.kernel.org/brgl/c/aa6a84558231f61264bd09c8ef013c7bca63db1e [3/7] media: em28xx: Open code gpio_request_one() https://git.kernel.org/brgl/c/492c8f997533acc550bc23be73b847f5e7bf3e75 [4/7] MIPS: BCM47XX: Open code gpio_request_one() https://git.kernel.org/brgl/c/878804621d798dc9eff6148732f74adbc45e99de [5/7] MIPS: BCM63XX: Remove one time use ephy_reset_gpio_flags https://git.kernel.org/brgl/c/6eeba9dc60aa6a5e2a617c7e08a6ad4da325c1f9 [6/7] MIPS: BCM63XX: Open code gpio_request_one() https://git.kernel.org/brgl/c/1805476b1a49aea62787072b28d7a2d5880c53da [7/7] gpiolib: Get rid of not used anymore gpio_request_one() https://git.kernel.org/brgl/c/dbc9f76c3ce301c76991574e1944a0d2a8717062
Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>