Skip to contentSkip to conversation

certificate subject parsing bug in extract_x509_field_ssl. against 2.1_rc7

PATCH New upb 1 participant 1 message Feb 5, 2009

lore
Share & tools
lore

upb

author
#0 lore raw

PATCH 1/1 certificate subject parsing bug in extract_x509_field_ssl. against 2.1_rc7

This bug causes cert subjects where common name is the first component of the subject, to be parsed incorrectly, resulting in no common name being returned at all.

Observed effects include incorrect client configuration being read (the UNDEF one) etc.

Patch is attached.

Regards,
upb

League of local jewish enterpreneurs.

ssl.c renamed from ssl.c.buggy +1 -1
@@ -402,7 +402,7 @@
   do {
     lastpos = tmp;
     tmp = X509_NAME_get_index_by_NID(x509, nid, lastpos);
-  } while (tmp > 0);
+  } while (tmp != -1);
 
   /* Nothing found */
   if (lastpos == -1)