Skip to contentSkip to conversation

mISDN: potential null dereference in dsp_cmx_send_member()

DISCUSSION Dan Carpenter 1 participant 1 message Aug 7, 2009

lore
Share & tools
lore
#0 lore raw

Hello,

I am testing a source analysis tool (http://repo.or.cz/w/smatch.git)
and it generates a warning in dsp_cmx_send_member().

The problem is that on line 1327 we verify that dsp->conf is non null but on line 1329 we assume that it is non null and dereference it without checking.

drivers/isdn/mISDN/dsp_cmx.c
1327 if (dsp->conf && dsp->conf->software && dsp->conf->hardware)
1328 tx_data_only = 1;
1329 if (dsp->conf->software && dsp->echo.hardware)
1330 tx_data_only = 1;

regards,
dan carpenter