Skip to contentSkip to conversation

off by one error in rioctrl.c

PATCH New Dan Carpenter 1 participant 1 message Aug 7, 2009 Char and misc drivers

lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 off by one error in rioctrl.c

I'm not sure who to send this to.

If DownLoad.ProductCode == MAX_PRODUCT, that would be a problem when we do RIOBootTable[DownLoad.ProductCode] a couple lines down.

Found by smatch (http://repo.or.cz/w/smatch.git).

regards,
dan carpenter

Signed-off-by Dan Carpenter <[email protected]>
drivers/char/rio/rioctrl.c +1 -1
@@ -873,7 +873,7 @@
 		/*
 		 ** It is important that the product code is an unsigned object!
 		 */
-		if (DownLoad.ProductCode > MAX_PRODUCT) {
+		if (DownLoad.ProductCode >= MAX_PRODUCT) {
 			rio_dprintk(RIO_DEBUG_CTRL, "RIO_DOWNLOAD: Bad product code %d passed\n", DownLoad.ProductCode);
 			p->RIOError.Error = NO_SUCH_PRODUCT;
 			return -ENXIO;