Skip to contentSkip to conversation

drivers/gpu/drm/gma500:fix build failure for 3.9-rc5

PATCH Superseded Xiong Zhou 2 participants 3 messages Apr 9, 2013 – Apr 10, 2013

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Xiong Zhou

author
#0 lore raw

PATCH 1/1 drivers/gpu/drm/gma500:fix build failure for 3.9-rc5

From: Xiong Zhou <[email protected]>

This patch fixes build failure of v3.9-rc5.
When config ACPI_VIDEO as m, DRM_GMA500 as y, here comes the failure. gma5/600 needs acpi_video just like nouveau.

Failure message:
drivers/built-in.o: In function `psb_driver_load':
kernel-3.9-rc5/drivers/gpu/drm/gma500/psb_drv.c:340: \
undefined reference to `acpi_video_register'
make: *** [vmlinux] Error 1

---
drivers/gpu/drm/gma500/Kconfig | 1 +

1 file changed, 1 insertion(+)
drivers/gpu/drm/gma500/Kconfig +1 -0
index 1188f0f..d64fc45 100644
@@ -6,6 +6,7 @@ config DRM_GMA500
         select FB_CFB_IMAGEBLIT
         select DRM_KMS_HELPER
         select DRM_TTM
+        select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT
 	help
 	  Say yes for an experimental 2D KMS framebuffer driver for the
 	  Intel GMA500 ('Poulsbo') and other Intel IMG based graphics
maintainer
#1 lore raw
Quoted 22 lines · Xiong Zhou

From: Xiong Zhou <[email protected]>

This patch fixes build failure of v3.9-rc5.
When config ACPI_VIDEO as m, DRM_GMA500 as y, here comes the failure. gma5/600 needs acpi_video just like nouveau.

Failure message:
drivers/built-in.o: In function `psb_driver_load':
kernel-3.9-rc5/drivers/gpu/drm/gma500/psb_drv.c:340: \
undefined reference to `acpi_video_register'
make: *** [vmlinux] Error 1

---
drivers/gpu/drm/gma500/Kconfig | 1 +

1 file changed, 1 insertion(+)
drivers/gpu/drm/gma500/Kconfig +0 -0
index 1188f0f..d64fc45 100644

drivers/gpu/drm/gma500/Kconfig config DRM_GMA500

Quoted 8 lines
drivers/gpu/drm/gma500/Kconfig +1 -1
@@ -6,6 +6,7 @@ config DRM_GMA500
         select FB_CFB_IMAGEBLIT
         select DRM_KMS_HELPER
         select DRM_TTM
+        select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT
        help
          Say yes for an experimental 2D KMS framebuffer driver for the
          Intel GMA500 ('Poulsbo') and other Intel IMG based graphics
--

Hi

Thanks for catching this, but if I can be picky, I'd prefer if you wrote it like i915 does. E.g.

select ACPI_VIDEO if ACPI
select BACKLIGHT_CLASS_DEVICE if ACPI
...

And you can skip X86 since we already 'depend' on it.

Thanks
Patrik

author
#2 lore raw
Quoted 37 lines · Patrik Jakobsson
Quoted 22 lines · Xiong Zhou

From: Xiong Zhou <[email protected]>

This patch fixes build failure of v3.9-rc5.
When config ACPI_VIDEO as m, DRM_GMA500 as y, here comes the failure. gma5/600 needs acpi_video just like nouveau.

Failure message:
drivers/built-in.o: In function `psb_driver_load':
kernel-3.9-rc5/drivers/gpu/drm/gma500/psb_drv.c:340: \
undefined reference to `acpi_video_register'
make: *** [vmlinux] Error 1

---
drivers/gpu/drm/gma500/Kconfig | 1 +

1 file changed, 1 insertion(+)
drivers/gpu/drm/gma500/Kconfig +0 -0
index 1188f0f..d64fc45 100644

drivers/gpu/drm/gma500/Kconfig config DRM_GMA500

Quoted 8 lines
drivers/gpu/drm/gma500/Kconfig +1 -1
@@ -6,6 +6,7 @@ config DRM_GMA500
         select FB_CFB_IMAGEBLIT
         select DRM_KMS_HELPER
         select DRM_TTM
+        select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT
        help
          Say yes for an experimental 2D KMS framebuffer driver for the
          Intel GMA500 ('Poulsbo') and other Intel IMG based graphics
--

Hi

Thanks for catching this, but if I can be picky, I'd prefer if you wrote it like i915 does. E.g.

Quoted 9 lines

select ACPI_VIDEO if ACPI
select BACKLIGHT_CLASS_DEVICE if ACPI
...

And you can skip X86 since we already 'depend' on it.

Thanks
Patrik

Nice advices, Thanks!

Xiong