Skip to contentSkip to conversation

Fix FILESEXTRAPATHS, dir is "netbase-5.0"

PATCH In review Robert P. J. Day 5 participants 11 messages Apr 19, 2013 – Apr 22, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix FILESEXTRAPATHS, dir is "netbase-5.0"

The actual files subdirectory name is "netbase-5.0", not "netbase".

---

same fix was once applied to exactly the same recipe bbappend file
under meta-ti layer.

recipes-core/netbase/netbase_5.0.bbappend +1 -1
index 36432f5..a3fbd33 100644
@@ -1,3 +1,3 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
 # Don't forget to bump PRINC if you update the extra files.
 PRINC = "1"
Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#1 lore raw
Quoted 15 lines · Robert P. J. Day

The actual files subdirectory name is "netbase-5.0", not "netbase".

---

same fix was once applied to exactly the same recipe bbappend file
under meta-ti layer.

recipes-core/netbase/netbase_5.0.bbappend +0 -0
index 36432f5..a3fbd33 100644

recipes-core/netbase/netbase_5.0.bbappend line 3

Quoted 4 lines
recipes-core/netbase/netbase_5.0.bbappend +1 -1
@@ -1,3 +1,3 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
 # Don't forget to bump PRINC if you update the extra files.
 PRINC = "1"

that's P or use BP, and fix PRINC when you're there..

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw
Quoted 11 lines · Martin Jansa
Quoted 10 lines · Robert P. J. Day

The actual files subdirectory name is "netbase-5.0", not "netbase".

---

same fix was once applied to exactly the same recipe bbappend file
under meta-ti layer.

Quoted 11 lines

recipes-core/netbase/netbase_5.0.bbappend line 3

Quoted 9 lines
recipes-core/netbase/netbase_5.0.bbappend +1 -1
index 36432f5..a3fbd33 100644
@@ -1,3 +1,3 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
 # Don't forget to bump PRINC if you update the extra files.
 PRINC = "1"

that's P or use BP, and fix PRINC when you're there..

ok, but i was just working off of *exactly* the same patch format
that went into meta-ti.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#3 lore raw
In reply to Martin Jansa
Quoted 11 lines · Martin Jansa
Quoted 10 lines · Robert P. J. Day

The actual files subdirectory name is "netbase-5.0", not "netbase".

---

same fix was once applied to exactly the same recipe bbappend file
under meta-ti layer.

Quoted 11 lines

recipes-core/netbase/netbase_5.0.bbappend line 3

Quoted 9 lines
recipes-core/netbase/netbase_5.0.bbappend +1 -1
index 36432f5..a3fbd33 100644
@@ -1,3 +1,3 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
 # Don't forget to bump PRINC if you update the extra files.
 PRINC = "1"

that's P or use BP, and fix PRINC when you're there..

ok, pedantic question -- the comment suggests you're supposed to
increment PRINC "if you update the extra files". but i didn't, i just made sure they're now being included. i guess that still counts, yes?

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#4 lore raw
Quoted 25 lines · Robert P. J. Day
Quoted 11 lines · Martin Jansa
Quoted 10 lines · Robert P. J. Day

The actual files subdirectory name is "netbase-5.0", not "netbase".

---

same fix was once applied to exactly the same recipe bbappend file
under meta-ti layer.

Quoted 11 lines

recipes-core/netbase/netbase_5.0.bbappend line 3

Quoted 9 lines
recipes-core/netbase/netbase_5.0.bbappend +1 -1
index 36432f5..a3fbd33 100644
@@ -1,3 +1,3 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
 # Don't forget to bump PRINC if you update the extra files.
 PRINC = "1"

that's P or use BP, and fix PRINC when you're there..

Quoted 3 lines

ok, pedantic question -- the comment suggests you're supposed to
increment PRINC "if you update the extra files". but i didn't, i just made sure they're now being included. i guess that still counts, yes?

I was talking about PRINC := "${@int(PRINC) + 1}"

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#5 lore raw
Quoted 26 lines · Martin Jansa
Quoted 25 lines · Robert P. J. Day
Quoted 22 lines · Martin Jansa
Quoted 15 lines · Robert P. J. Day

The actual files subdirectory name is "netbase-5.0", not "netbase".

---

same fix was once applied to exactly the same recipe bbappend file
under meta-ti layer.

recipes-core/netbase/netbase_5.0.bbappend +0 -0
index 36432f5..a3fbd33 100644

recipes-core/netbase/netbase_5.0.bbappend line 3

Quoted 4 lines
recipes-core/netbase/netbase_5.0.bbappend +1 -1
@@ -1,3 +1,3 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}-${PV}:"
 # Don't forget to bump PRINC if you update the extra files.
 PRINC = "1"

that's P or use BP, and fix PRINC when you're there..

Quoted 5 lines
Quoted 3 lines

ok, pedantic question -- the comment suggests you're supposed to
increment PRINC "if you update the extra files". but i didn't, i just made sure they're now being included. i guess that still counts, yes?

I was talking about PRINC := "${@int(PRINC) + 1}"

i think i'll just leave this to the rpi folks. :-)

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#7 lore raw
Quoted 7 lines · Paul Barker
Quoted 3 lines · Robert P. J. Day

i think i'll just leave this to the rpi folks. :-)

I'm building for raspberrypi so I'll add this to my queue of things to look at.

Just another note about the netbase, for 1.4 the interfaces file moved to init-ifupdown, so that file should move to a new recipe with bbappends for init-ifupdown-1.0.

We just fixed meta-yocto for the beagleboard in the final 1.4 release.

Sau!

Quoted 11 lines

--
Paul Barker

Email: [email protected]
http://www.paulbarker.me.uk
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

#8 lore raw
Quoted 6 lines · Saul Wold

Just another note about the netbase, for 1.4 the interfaces file moved to init-ifupdown, so that file should move to a new recipe with bbappends for init-ifupdown-1.0.

We just fixed meta-yocto for the beagleboard in the final 1.4 release.

Ok, had a look at this now.

As originally pointed out by Robert, the hosts and interfaces files are not picked up as the wrong directory is named in netbase_5.0.bbappend. However, the image I've just built works fine with the stock files in openembedded-core. Both eth0 and lo interfaces come up fine. Other interfaces listed in the stock files don't have an "auto" line so no attempt is made to bring them up at boot.

If we look at the interfaces file in meta-raspberrypi
(http://git.yoctoproject.org/cgit/cgit.cgi/meta-raspberrypi/tree/recipes-core/netbase/netbase-5.0/raspberrypi/interfaces),
it doesn't even list eth0 so I can't see how it would work.

The hosts file (http://git.yoctoproject.org/cgit/cgit.cgi/meta-raspberrypi/tree/recipes-core/netbase/netbase-5.0/raspberrypi/hosts)
just adds the names 'raspberrypi' and 'rpi' as aliases for localhost,
which I don't see the purpose of myself.

So I'd recommend dropping these from meta-raspberrypi completely. Just my opinion though, anyone else got any thoughts on this?

--
Paul Barker

Email: [email protected]
http://www.paulbarker.me.uk

#9 lore raw
Quoted 24 lines · Paul Barker
Quoted 2 lines · Saul Wold

Just another note about the netbase, for 1.4 the interfaces file moved to init-ifupdown, so that file should move to a new recipe with bbappends

for

Quoted 4 lines

init-ifupdown-1.0.

We just fixed meta-yocto for the beagleboard in the final 1.4 release.

Ok, had a look at this now.

As originally pointed out by Robert, the hosts and interfaces files are not picked up as the wrong directory is named in netbase_5.0.bbappend. However, the image I've just built works fine with the stock files in openembedded-core. Both eth0 and lo interfaces come up fine. Other interfaces listed in the stock files don't have an "auto" line so no attempt is made to bring them up at boot.

If we look at the interfaces file in meta-raspberrypi (
http://git.yoctoproject.org/cgit/cgit.cgi/meta-raspberrypi/tree/recipes-core/netbase/netbase-5.0/raspberrypi/interfaces
),
it doesn't even list eth0 so I can't see how it would work.

Quoted 10 lines

The hosts file (
http://git.yoctoproject.org/cgit/cgit.cgi/meta-raspberrypi/tree/recipes-core/netbase/netbase-5.0/raspberrypi/hosts
)
just adds the names 'raspberrypi' and 'rpi' as aliases for localhost, which I don't see the purpose of myself.

So I'd recommend dropping these from meta-raspberrypi completely. Just my opinion though, anyone else got any thoughts on this?

Hello guys. Probably dropping would be the best thing here. I don't think that the issue is reproduced anymore with netbase on rpi. If you submit patch I can give it a try.

Signature · 2 lines
*Andrei Gherzan*
m: +40.744.478.414 |  f: +40.31.816.28.12
#10 lore raw
Quoted 10 lines · Andrei Gherzan
Quoted 4 lines · Paul Barker

So I'd recommend dropping these from meta-raspberrypi completely. Just my opinion though, anyone else got any thoughts on this?

Hello guys. Probably dropping would be the best thing here. I don't think that the issue is reproduced anymore with netbase on rpi. If you submit patch I can give it a try.

I've thrown a patch together, will send it to the list. Not sure if you want to elaborate on the commit message a little though before it goes into the main repo, I'm not quite up to speed with the history of some of these recipes.

(I must learn to check my reply/reply-all selection!)

Thanks,

--
Paul Barker

Email: [email protected]
http://www.paulbarker.me.uk