Staging: emxx_udc: Convert from __attribute__((aligned(size))) to __aligned(size).
PATCH 1/1 Staging: emxx_udc: Convert from __attribute__((aligned(size))) to __aligned(size).
This patch addresses the checkpatch.pl warning
WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))
--- drivers/staging/emxx_udc/emxx_udc.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/emxx_udc/emxx_udc.h +1 -2
@@ -535,8 +535,7 @@ typedef struct _T_FC_REGS {u8 Reserved1200[0x1000 -0x200 ];/* Reserved */ -} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS; - +}__aligned(32) T_FC_REGS , *PT_FC_REGS ;
Signature · 1 line
1.9.1
Quoted 3 lines · Vatika Harlalka
This patch addresses the checkpatch.pl warning
WARNING:
__aligned(size)is preferred over __attribute__((aligned(size)))
You could try to find out why it is preferred and explain that. I don't know if there is an interesting reason, but you might find some comments in git logs.
Quoted 10 lines
Signed-off-by Vatika Harlalka <[email protected]>--- drivers/staging/emxx_udc/emxx_udc.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/staging/emxx_udc/emxx_udc.h +0
-0
drivers/staging/emxx_udc/emxx_udc.h typedef struct _T_FC_REGS { · line 538
Quoted 6 lines
drivers/staging/emxx_udc/emxx_udc.h +1
-2@@ -535,8 +535,7 @@ typedef struct _T_FC_REGS {u8 Reserved1200[0x1000 -0x200 ];/* Reserved */ -} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS; - +}__aligned(32) T_FC_REGS , *PT_FC_REGS ;
It looks like an extra line has disappeared? Was that intentional?
julia
Quoted 12 lines
drivers/staging/emxx_udc/emxx_udc.h +0
-1--1.9.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150217131048.GA5235%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Quoted 13 lines · Julia Lawall
Quoted 3 lines · Vatika Harlalka
This patch addresses the checkpatch.pl warning
WARNING:
__aligned(size)is preferred over__attribute__((aligned(size)))
You could try to find out why it is preferred and explain that. I don't know if there is an interesting reason, but you might find some comments in git logs.
Quoted 1 line
Quoted 1 line
Thanks for the input. I checked git logs and it seems that aligned(x)
is a macro :
Quoted 14 lines
Quoted 1 line
#define __aligned(x) __attribute__((aligned(x)))Signed-off-by Vatika Harlalka <[email protected] <javascript:>>Review
Quoted 5 lines
---
drivers/staging/emxx_udc/emxx_udc.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)(quoted diff) +0
-0
b/drivers/staging/emxx_udc/emxx_udc.hQuoted 5 lines
index ee1b80d..90c5d1d 100644
drivers/staging/emxx_udc/emxx_udc.h +0
-0@@ -535,8 +535,7 @@ typedef struct _T_FC_REGS {
Quoted 10 lines
drivers/staging/emxx_udc/emxx_udc.h typedef struct _T_FC_REGS { · line 538
Quoted 5 lines
drivers/staging/emxx_udc/emxx_udc.h +1
-2u8 Reserved1200[0x1000 -0x200 ];/* Reserved */ -} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS; - +}__aligned(32) T_FC_REGS , *PT_FC_REGS ;It looks like an extra line has disappeared? Was that intentional?
Quoted 1 line
The extra line was not a part of the original code. I had added and
then removed it.
Quoted 20 lines
julia
Quoted 7 lines
Signature · 5 lines
-- 1.9.1 -- You received this message because you are subscribed to the GoogleGroups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected] <javascript:>.
Quoted 1 line
To post to this group, send email to [email protected]
<javascript:>.
Quoted 1 line
To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/20150217131048.GA5235%40gmail.com.
Quoted 2 lines
For more options, visit https://groups.google.com/d/optout.
Quoted 6 lines
It looks like an extra line has disappeared? Was that intentional?
>> The extra line was not a part of the original code. I had added and then removed it.
OK, you should start over with the file and send a patch against the original state.
julia