Skip to contentSkip to conversation

Staging: rts5208: Fix code indent warning style

PATCH In review Haneen Mohammed 2 participants 2 messages Feb 18, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rts5208: Fix code indent warning style

Patch to the rtsx_scsi.c file for the following checkpatch.pl warning:
WARNING: suspect code indent for conditional statements (8, 8)

---
 drivers/staging/rts5208/rtsx_scsi.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/rts5208/rtsx_scsi.c +0 -2
index 1161082..42645834 100644
@@ -519,10 +519,8 @@ static int inquiry(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 #else
 	if (chip->mspro_formatter_enable)
 #endif
-	{
 		if (!card || (card == MS_CARD))
 			pro_formatter_flag = 1;
-	}
 
 	if (pro_formatter_flag) {
 		if (scsi_bufflen(srb) < 56)
Signature · 1 line
1.9.1
#1 lore raw
Quoted 2 lines · Haneen Mohammed

Patch to the rtsx_scsi.c file for the following checkpatch.pl warning:
WARNING: suspect code indent for conditional statements (8, 8)

Actually, your fix has nothing to do with indentation, even though indentation is what checkpatch noticed. It would be better to describe what you have done. In this case, it would be something like, remove unneeded braces around a single-statement if branch.

The commit message also doesn't need to mention the file name, because that can be found directly in the diffstat.

julia

Quoted 31 lines
---
 drivers/staging/rts5208/rtsx_scsi.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/rts5208/rtsx_scsi.c +0 -3
index 1161082..42645834 100644
@@ -519,10 +519,8 @@ static int inquiry(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 #else
 	if (chip->mspro_formatter_enable)
 #endif
-	{
 		if (!card || (card == MS_CARD))
 			pro_formatter_flag = 1;
-	}
 
 	if (pro_formatter_flag) {
 		if (scsi_bufflen(srb) < 56)
--

1.9.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1424191566-22467-1-git-send-email-hamohammed.sa%40gmail.com.
For more options, visit https://groups.google.com/d/optout.