Skip to contentSkip to conversation

Staging: media: Remove unneeded void return

PATCH In review Vatika Harlalka 2 participants 2 messages Feb 19, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: media: Remove unneeded void return

This patch is to remove return statement from void function.

---
 drivers/staging/media/tlg2300/pd-alsa.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/media/tlg2300/pd-alsa.c +0 -1
index e23f437..7a07a1d 100644
@@ -195,7 +195,6 @@ static void complete_handler_audio(struct urb *urb)
 	ret = usb_submit_urb(urb, GFP_ATOMIC);
 	if (ret < 0)
 		log("audio urb failed (errcod = %i)", ret);
-	return;
 }
 
 static int fire_audio_urb(struct poseidon *p)
Signature · 1 line
1.9.1
#1 lore raw
Quoted 12 lines · Vatika Harlalka

This patch is to remove return statement from void function.

---
 drivers/staging/media/tlg2300/pd-alsa.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/media/tlg2300/pd-alsa.c +0 -0
index e23f437..7a07a1d 100644

drivers/staging/media/tlg2300/pd-alsa.c static void complete_handler_audio(struct urb *urb) · line 198

Quoted 4 lines
drivers/staging/media/tlg2300/pd-alsa.c +0 -1
@@ -195,7 +195,6 @@ static void complete_handler_audio(struct urb *urb)
 	ret = usb_submit_urb(urb, GFP_ATOMIC);
 	if (ret < 0)
 		log("audio urb failed (errcod = %i)", ret);
-	return;

You could consider getting rid of all of the uses of the non-standard log macro in this driver.

Some cases are for just indicating the entry or exit from a function. These could be just dropped competely, as the kernel provides other mechanisms for function tracing.

julia