Staging: rtl8188eu: Remove unnecessary variable
PATCH 1/1 Staging: rtl8188eu: Remove unnecessary variable
Remove unneccessary variable and replace its uses with another variable which is previously defined.
--- drivers/staging/rtl8188eu/hal/phy.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/rtl8188eu/hal/phy.c +1 -3
@@ -72,12 +72,10 @@ static u32 rf_serial_read(struct adapter *adapt,u32 ret =0 ;struct hal_data_8188e *hal_data =GET_HAL_DATA (adapt);struct bb_reg_def *phyreg = &hal_data->PHYRegDef[rfpath]; -u32 newoffset;u32 tmplong, tmplong2;u8 rfpi_enable =0 ; offset &=0xff ; - newoffset = offset; tmplong =phy_query_bb_reg (adapt, rFPGA0_XA_HSSIParameter2, bMaskDWord);if (rfpath ==RF_PATH_A )
@@ -87,7 +85,7 @@ static u32 rf_serial_read(struct adapter *adapt, bMaskDWord); tmplong2 = (tmplong2 & (~bLSSIReadAddress)) | - (newoffset<<23 ) | bLSSIReadEdge; + (offset<<23 ) | bLSSIReadEdge;phy_set_bb_reg (adapt, rFPGA0_XA_HSSIParameter2, bMaskDWord, tmplong&(~bLSSIReadEdge));
Signature · 1 line
1.9.1
Quoted 2 lines · Vatika Harlalka
Remove unneccessary variable and replace its uses with another variable which is previously defined.
The code is a bit strange. You could consider making the same change in the write function.
julia
Quoted 41 lines
Signed-off-by Vatika Harlalka <[email protected]>--- drivers/staging/rtl8188eu/hal/phy.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/staging/rtl8188eu/hal/phy.c +1
-4@@ -72,12 +72,10 @@ static u32 rf_serial_read(struct adapter *adapt,u32 ret =0 ;struct hal_data_8188e *hal_data =GET_HAL_DATA (adapt);struct bb_reg_def *phyreg = &hal_data->PHYRegDef[rfpath]; -u32 newoffset;u32 tmplong, tmplong2;u8 rfpi_enable =0 ; offset &=0xff ; - newoffset = offset; tmplong =phy_query_bb_reg (adapt, rFPGA0_XA_HSSIParameter2, bMaskDWord);if (rfpath ==RF_PATH_A )@@ -87,7 +85,7 @@ static u32 rf_serial_read(struct adapter *adapt, bMaskDWord); tmplong2 = (tmplong2 & (~bLSSIReadAddress)) | - (newoffset<<23 ) | bLSSIReadEdge; + (offset<<23 ) | bLSSIReadEdge;phy_set_bb_reg (adapt, rFPGA0_XA_HSSIParameter2, bMaskDWord, tmplong&(~bLSSIReadEdge)); --1.9.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150223085030.GA1602%40gmail.com.
For more options, visit https://groups.google.com/d/optout.