Skip to contentSkip to conversation

question about drivers/mailbox/pcc.c

DISCUSSION Julia Lawall 2 participants 3 messages Mar 13, 2015

lore
Share & tools
lore
#0 lore raw

Hello,

The patch 86c22f8c9a3b from Wed Nov 12 19:59:38 2014 in linux-next introduces a file that contains two exported functions:
pcc_mbox_request_channel and pcc_mbox_free_channel. As far as I can see, these functions are not used by any modules in the kernel source tree. Is there some code coming that will use them, or should they be removed?

thanks,
julia

#1 lore raw
Quoted 7 lines · Julia Lawall

Hello,

The patch 86c22f8c9a3b from Wed Nov 12 19:59:38 2014 in linux-next introduces a file that contains two exported functions:
pcc_mbox_request_channel and pcc_mbox_free_channel. As far as I can see, these functions are not used by any modules in the kernel source tree. Is there some code coming that will use them, or should they be removed?

There is code that depends on these functions being reviewed. CPPC is one client that is publicly being reviewed[1]. I know there are others (RASF), but I do not know their upstreaming status.

Thanks,
Ashwin.

[1] - https://www.marc.info/?t=142239274200005&r=1&w=1

#2 lore raw
Quoted 9 lines · Ashwin Chaugule
Quoted 7 lines · Julia Lawall

Hello,

The patch 86c22f8c9a3b from Wed Nov 12 19:59:38 2014 in linux-next introduces a file that contains two exported functions:
pcc_mbox_request_channel and pcc_mbox_free_channel. As far as I can see, these functions are not used by any modules in the kernel source tree. Is there some code coming that will use them, or should they be removed?

Quoted 3 lines

There is code that depends on these functions being reviewed. CPPC is one client that is publicly being reviewed[1]. I know there are others (RASF), but I do not know their upstreaming status.

OK, thanks for the clarification.

julia

Quoted 6 lines

Thanks,
Ashwin.

[1] - https://www.marc.info/?t=142239274200005&r=1&w=1