test/gem_mocs_settings: Testing MOCS register settings
PATCH v2 1/1 test/gem_mocs_settings: Testing MOCS register settings
The MOCS registers were added in Gen9 and define the caching policy. The registers are split into two sets. The first set controls the EDRAM policy and have a set for each engine, the second set controls the L3 policy. The two sets use the same index.
The RCS registers and the L3CC registers are stored in the RCS context.
The test checks that the registers are correct by checking the values by directly reading them via MMIO, then again it tests them by reading them from within a batch buffer. RCS engine is tested last as it programs the registers via a batch buffer and this will invalidate the test for workloads that don't use the render ring or don't run a render batch first.
v2: Reorganised the structure.
Added more tests. (Chris Wilson)
--- tests/Makefile.sources | 1 + tests/gem_mocs_settings.c | 566 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 567 insertions(+) create mode 100644 tests/gem_mocs_settings.c
tests/Makefile.sources +1 -0
@@ -148,6 +148,7 @@ TESTS_progs = \ gem_lut_handle \ gem_mmap_offset_exhaustion \ gem_media_fill \ + gem_mocs_settings \ gem_gpgpu_fill \ gem_pin \ gem_reg_read \
tests/gem_mocs_settings.c new file +566 -0
566 lines not on this page · raw message
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
tests/gem_mocs_settings.c line 201
Quoted 10 lines · Peter Antoine
tests/gem_mocs_settings.c new file +10
-0+static int create_read_batch (struct drm_i915_gem_relocation_entry *reloc, +uint32_t *batch, +uint32_t dst_handle, +uint32_t size, +uint32_t reg_base) +{ +unsigned int index; +unsigned int offset =0 ; + +for (index =0 , offset =0 ; index < size; index++, offset +=4 )
offset = 0 twice
tests/gem_mocs_settings.c line 210
Quoted 9 lines
tests/gem_mocs_settings.c new file +9
-0+ { + batch[offset] =MI_STORE_REGISTER_MEM_64_BIT_ADDR ; + batch[offset+1 ] = reg_base + (index *sizeof (uint32_t )); + batch[offset+2 ] = index *sizeof (uint32_t );/* reloc */ + batch[offset+3 ] =0 ; + + reloc[index].offset = (offset +2 ) *sizeof (uint32_t ); + reloc[index].delta = index *sizeof (uint32_t ); + reloc[index].target_handle = dst_handle;
Missed something.
Quoted 17 lines
tests/gem_mocs_settings.c new file +17
-0+ } + + batch[offset++] =MI_BATCH_BUFFER_END ; + batch[offset++] =0 ; + +return offset *sizeof (uint32_t ); +} + +static void do_read_registers (int fd, +uint32_t ctx_id, +uint32_t dst_handle, +uint32_t reg_base, +uint32_t size, +uint32_t engine_id) +{ +struct drm_i915_gem_execbuffer2 execbuf; +struct drm_i915_gem_exec_object2 gem_exec[2 ];
tests/gem_mocs_settings.c line 237
Quoted 10 lines
tests/gem_mocs_settings.c new file +10
-0+struct drm_i915_gem_relocation_entry reloc[MAX_NUMBER_MOCS_REGISTERS ]; +uint32_t batch[MAX_NUMBER_MOCS_REGISTERS *4 +4 ]; +uint32_t handle =gem_create (fd,4096 ); + +memset (reloc,0 ,sizeof (reloc)); +memset (gem_exec,0 ,sizeof (gem_exec)); +memset (&execbuf,0 ,sizeof (execbuf)); + + gem_exec[0 ].handle = dst_handle; +gem_set_domain (fd, dst_handle,I915_GEM_DOMAIN_CPU ,0 );
??????
Quoted 6 lines
tests/gem_mocs_settings.c new file +6
-0+ gem_exec[1 ].handle = handle; + gem_exec[1 ].relocation_count = size; + gem_exec[1 ].relocs_ptr = (uintptr_t ) reloc; + + execbuf.buffers_ptr = (uintptr_t )gem_exec; + execbuf.buffer_count =2 ;
tests/gem_mocs_settings.c line 254
Quoted 10 lines
tests/gem_mocs_settings.c new file +10
-0+ execbuf.batch_len =create_read_batch (reloc, + batch, + dst_handle, + size, + reg_base); + +gem_write (fd, handle,0 , batch, execbuf.batch_len); + +if (ctx_id !=0 ) +i915_execbuffer2_set_context_id (execbuf, ctx_id);
Just set it.
tests/gem_mocs_settings.c line 259
Quoted 5 lines
tests/gem_mocs_settings.c new file +5
-0+ + execbuf.flags =I915_EXEC_SECURE | engine_id; + +gem_execbuf (fd, &execbuf); +gem_sync (fd, handle);
^ Papering over a bug in your code.
Hint: did you tell anyone that you were writing into the buffer?
Quoted 72 lines
tests/gem_mocs_settings.c new file +72
-0+ +gem_close (fd, handle); +} + +#define LOCAL_MI_LOAD_REGISTER_IMM (0x22 << 23) + +static int create_write_batch (uint32_t *batch, +const uint32_t *values, +uint32_t size, +uint32_t reg_base) +{ +unsigned int i; +unsigned int offset =0 ; + + batch[offset++] =LOCAL_MI_LOAD_REGISTER_IMM | (size *2 -1 ); + +for (i =0 ; i < size; i++) { + batch[offset++] = reg_base + (i *4 ); + batch[offset++] = values[i]; + } + + batch[offset++] =0 ; + batch[offset++] =MI_BATCH_BUFFER_END ; + batch[offset++] =0 ; + +return offset *sizeof (uint32_t ); +} + +static void write_registers (int fd, +uint32_t ctx_id, +uint32_t reg_base, +const uint32_t *values, +uint32_t size, +uint32_t engine_id) +{ +struct drm_i915_gem_exec_object2 gem_exec; +struct drm_i915_gem_execbuffer2 execbuf; +uint32_t batch[MAX_NUMBER_MOCS_REGISTERS *4 +4 ]; +uint32_t handle =gem_create (fd,4096 ); + +memset (&gem_exec,0 ,sizeof (gem_exec)); +memset (&execbuf,0 ,sizeof (execbuf)); + + gem_exec.handle = handle; + + execbuf.buffers_ptr = (uintptr_t )&gem_exec; + execbuf.buffer_count =1 ; + execbuf.batch_len =create_write_batch (batch, values, size, reg_base); + +gem_write (fd, handle,0 , batch, execbuf.batch_len); + +if (ctx_id !=0 ) +i915_execbuffer2_set_context_id (execbuf, ctx_id); + + execbuf.flags =I915_EXEC_SECURE | engine_id; + +gem_execbuf (fd, &execbuf); +gem_sync (fd, handle); + +gem_close (fd, handle); +} + +static void check_control_registers (int fd, +const struct intel_execution_engine *engine, +uint32_t ctx_id, +bool dirty) +{ +uint32_t dst_handle =gem_create (fd,4096 ); +uint32_t reg_base =get_engine_base (engine->exec_id | engine->flags); +uint32_t *read_regs; +struct mocs_table table; +
tests/gem_mocs_settings.c line 341
Quoted 10 lines
tests/gem_mocs_settings.c new file +10
-0+igt_assert (get_mocs_settings (intel_get_drm_devid (fd), &table, dirty)); + +do_read_registers (fd, + ctx_id, + dst_handle, + reg_base, + table.size, + engine->exec_id | engine->flags); + + read_regs =gem_mmap__gtt (fd, dst_handle,4096 ,PROT_READ );
Missing set-domain. GTT for readback! I know we want some variety in test cases, but we shouldn't encourage people to use GTT for reads.
Quoted 29 lines
tests/gem_mocs_settings.c new file +29
-0+for (int index =0 ; index < table.size; index++) +igt_assert_eq (read_regs[index], + table.table[index].control_value); + +gem_close (fd, dst_handle); +} + +static void check_l3cc_registers (int fd, +const struct intel_execution_engine *engine, +uint32_t ctx_id, +bool dirty) +{ +struct mocs_table table; +uint32_t dst_handle =gem_create (fd,4096 ); +uint32_t *read_regs; +int index; + +igt_assert (get_mocs_settings (intel_get_drm_devid (fd), &table, dirty)); + +do_read_registers (fd, + ctx_id, + dst_handle, +GEN9_LNCFCMOCS0 , + (table.size +1 ) /2 , + engine->exec_id | engine->flags); + + read_regs =gem_mmap__gtt (fd, dst_handle,4096 ,PROT_READ ); + +for (index =0 ; index < table.size /2 ; index++) {
tests/gem_mocs_settings.c line 381
Quoted 10 lines
tests/gem_mocs_settings.c new file +10
-0+igt_assert_eq (read_regs[index] &0xffff , + table.table[index *2 ].l3cc_value); +igt_assert_eq (read_regs[index] >>16 , + table.table[index *2 +1 ].l3cc_value); + } + +if (table.size &0x01 ) +igt_assert_eq (read_regs[index] &0xffff , + table.table[index *2 ].l3cc_value); +
munmap()
Quoted 16 lines
tests/gem_mocs_settings.c new file +16
-0+gem_close (fd, dst_handle); +} + +static void test_context_mocs_values (int fd, +const struct intel_execution_engine *engine, +bool use_default) +{ +uint32_t ctx_id =0 ; + +if (!use_default) + ctx_id =gem_context_create (fd); + +check_control_registers (fd, engine, ctx_id, false); +check_l3cc_registers (fd, engine, ctx_id, false); + +if (!use_default)
tests/gem_mocs_settings.c line 407
Quoted 10 lines
tests/gem_mocs_settings.c new file +10
-0+gem_context_destroy (fd, ctx_id); +} + +static void non_context_tests (unsigned mode) +{ +int fd =drm_open_driver_master (DRIVER_INTEL ); +const int gen =intel_gen (intel_get_drm_devid (fd)); +const struct intel_execution_engine *e; + +igt_require (gen >=9 );
Make this a function like has_mocs() so that the automatic message is a little more explanatory.
Quoted 6 lines
tests/gem_mocs_settings.c new file +6
-0+ +igt_info ("Testing Non/Default Context Engines\n" ); +test_mocs_values (fd); + +switch (mode) { +case NONE :break ;
tests/gem_mocs_settings.c line 424
Quoted 10 lines
tests/gem_mocs_settings.c new file +10
-0+case RESET :igt_force_gpu_reset ();break ; +case SUSPEND :igt_system_suspend_autoresume ();break ; +case HIBERNATE :igt_system_hibernate_autoresume ();break ; + }; + +for (e = intel_execution_engines; e->name; e++) + +if (e->exec_id !=I915_EXEC_DEFAULT && +gem_has_ring (fd, e->exec_id | e->flags)) { +igt_info (" Engine: %s\n" , e->name);
Both of these are debug, not info.
tests/gem_mocs_settings.c line 430
Quoted 6 lines
tests/gem_mocs_settings.c new file +6
-0+test_context_mocs_values (fd, e, true); + } + +test_mocs_values (fd); + +drmDropMaster (fd);
Superfluous; here and everywhere else.
tests/gem_mocs_settings.c line 439
Quoted 9 lines
tests/gem_mocs_settings.c new file +9
-0+close (fd); +} + +static void context_save_restore_test (unsigned mode) +{ +int fd =drm_open_driver_master (DRIVER_INTEL ); +const int gen =intel_gen (intel_get_drm_devid (fd)); +const struct intel_execution_engine *e; +uint32_t ctx_id =gem_context_create (fd);
Should we not apply a little more stress here?
We need at least 2 active contexts in order to have one unpinned. Same for fds (the default context tests).
Quoted 28 lines
tests/gem_mocs_settings.c new file +28
-0+ +igt_require (gen >=9 ); + +igt_info ("Testing Save Restore\n" ); + +for (e = intel_execution_engines; e->name; e++) +if (e->exec_id ==I915_EXEC_RENDER ) { +check_control_registers (fd, e, ctx_id, false); +check_l3cc_registers (fd, e, ctx_id, false); + } + +switch (mode) { +case NONE :break ; +case RESET :igt_force_gpu_reset ();break ; +case SUSPEND :igt_system_suspend_autoresume ();break ; +case HIBERNATE :igt_system_hibernate_autoresume ();break ; + }; + +for (e = intel_execution_engines; e->name; e++) +if (e->exec_id ==I915_EXEC_RENDER ) { +check_control_registers (fd, e, ctx_id, false); +check_l3cc_registers (fd, e, ctx_id, false); + } + +gem_context_destroy (fd, ctx_id); +drmDropMaster (fd); +close (fd); +}
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 13 lines · Chris Wilson
tests/gem_mocs_settings.c line 201
Quoted 10 lines · Peter Antoine
tests/gem_mocs_settings.c new file +10
-0+static int create_read_batch (struct drm_i915_gem_relocation_entry *reloc, +uint32_t *batch, +uint32_t dst_handle, +uint32_t size, +uint32_t reg_base) +{ +unsigned int index; +unsigned int offset =0 ; + +for (index =0 , offset =0 ; index < size; index++, offset +=4 )offset = 0 twice
Ok will fix.
Quoted 12 lines
tests/gem_mocs_settings.c line 210
Quoted 10 lines
tests/gem_mocs_settings.c new file +9
-0+ { + batch[offset] =MI_STORE_REGISTER_MEM_64_BIT_ADDR ; + batch[offset+1 ] = reg_base + (index *sizeof (uint32_t )); + batch[offset+2 ] = index *sizeof (uint32_t );/* reloc */ + batch[offset+3 ] =0 ; + + reloc[index].offset = (offset +2 ) *sizeof (uint32_t ); + reloc[index].delta = index *sizeof (uint32_t ); + reloc[index].target_handle = dst_handle;Missed something.
Ok. See the domain is missing.
Quoted 11 lines
Quoted 11 lines
tests/gem_mocs_settings.c new file +10
-0+ } + + batch[offset++] =MI_BATCH_BUFFER_END ; + batch[offset++] =0 ; + +return offset *sizeof (uint32_t ); +} + +static void do_read_registers(int fd, + uint32_t ctx_id,
Quoted 8 lines
tests/gem_mocs_settings.c
Quoted 8 lines
tests/gem_mocs_settings.c new file +8
-0+uint32_t dst_handle, + uint32_t reg_base, + uint32_t size, + uint32_t engine_id) +{ + struct drm_i915_gem_execbuffer2 execbuf; +struct drm_i915_gem_exec_object2 gem_exec[2 ]; +struct drmB_i915_gem_relocation_entry
reloc[MAX_NUMBER_MOCS_REGISTERS];
Quoted 11 lines
tests/gem_mocs_settings.c line 237
Quoted 9 lines
tests/gem_mocs_settings.c new file +9
-0+uint32_t batch[MAX_NUMBER_MOCS_REGISTERS *4 +4 ]; +uint32_t handle =gem_create (fd,4096 ); + +memset (reloc,0 ,sizeof (reloc)); +memset (gem_exec,0 ,sizeof (gem_exec)); +memset (&execbuf,0 ,sizeof (execbuf)); + + gem_exec[0 ].handle = dst_handle; +gem_set_domain (fd, dst_handle,I915_GEM_DOMAIN_CPU ,0 );??????
Ok. Not required.
Quoted 8 lines
tests/gem_mocs_settings.c line 245
Quoted 8 lines
tests/gem_mocs_settings.c new file +7
-0+ gem_exec[1 ].handle = handle; + gem_exec[1 ].relocation_count = size; + gem_exec[1 ].relocs_ptr = (uintptr_t ) reloc; + + execbuf.buffers_ptr = (uintptr_t )gem_exec; + execbuf.buffer_count =2 ; + execbuf.batch_len = create_read_batch(reloc,
B>> + batch,
Quoted 10 lines
tests/gem_mocs_settings.c line 254
Quoted 8 lines
tests/gem_mocs_settings.c new file +8
-0+ dst_handle, + size, + reg_base); + +gem_write (fd, handle,0 , batch, execbuf.batch_len); + +if (ctx_id !=0 ) +i915_execbuffer2_set_context_id (execbuf, ctx_id);Just set it.
ok.
Quoted 10 lines
tests/gem_mocs_settings.c line 259
Quoted 6 lines
tests/gem_mocs_settings.c new file +5
-0+ + execbuf.flags =I915_EXEC_SECURE | engine_id; + +gem_execbuf (fd, &execbuf); +gem_sync (fd, handle);^ Papering over a bug in your code.
Hint: did you tell anyone that you were writing into the buffer?
Ok a write_domain and gem_wait.
Quoted 78 lines
Quoted 78 lines
tests/gem_mocs_settings.c new file +77
-0+ +gem_close (fd, handle); +} + +#define LOCAL_MI_LOAD_REGISTER_IMM (0x22 << 23) + +static int create_write_batch (uint32_t *batch, +const uint32_t *values, +uint32_t size, +uint32_t reg_base) +{ +unsigned int i; +unsigned int offset =0 ; + + batch[offset++] =LOCAL_MI_LOAD_REGISTER_IMM | (size *2 -1 ); + +for (i =0 ; i < size; i++) { + batch[offset++] = reg_base + (i *4 ); + batch[offset++] = values[i]; + } + + batch[offset++] =0 ; + batch[offset++] =MI_BATCH_BUFFER_END ; + batch[offset++] =0 ; + +return offset *sizeof (uint32_t ); +} + +static void write_registers (int fd, +uint32_t ctx_id, +uint32_t reg_base, +const uint32_t *values, +uint32_t size, +uint32_t engine_id) +{ +struct drm_i915_gem_exec_object2 gem_exec; +struct drm_i915_gem_execbuffer2 execbuf; +uint32_t batch[MAX_NUMBER_MOCS_REGISTERS *4 +4 ]; +uint32_t handle =gem_create (fd,4096 ); + +memset (&gem_exec,0 ,sizeof (gem_exec)); +memset (&execbuf,0 ,sizeof (execbuf)); + + gem_exec.handle = handle; + + execbuf.buffers_ptr = (uintptr_t )&gem_exec; + execbuf.buffer_count =1 ; + execbuf.batch_len =create_write_batch (batch, values, size, reg_base); + +gem_write (fd, handle,0 , batch, execbuf.batch_len); + +if (ctx_id !=0 ) +i915_execbuffer2_set_context_id (execbuf, ctx_id); + + execbuf.flags =I915_EXEC_SECURE | engine_id; + +gem_execbuf (fd, &execbuf); +gem_sync (fd, handle); + +gem_close (fd, handle); +} + +static void check_control_registers (int fd, +const struct intel_execution_engine *engine, +uint32_t ctx_id, +bool dirty) +{ +uint32_t dst_handle =gem_create (fd,4096 ); +uint32_t reg_base =get_engine_base (engine->exec_id | engine->flags); +uint32_t *read_regs; +struct mocs_table table; + +igt_assert (get_mocs_settings (intel_get_drm_devid (fd), &table, dirty)); + + do_read_registers(fd, + ctx_id, + dst_handle,
Quoted 8 lines
tests/gem_mocs_settings.c line 341
Quoted 5 lines
tests/gem_mocs_settings.c new file +5
-0+ reg_base, + table.size, + engine->exec_id | engine->flags); + + read_regs =gem_mmap__gtt (fd, dst_handle,4096 ,PROT_READ );Missing set-domain. GTT for readback! I know we want some variety in test cases, but we shouldn't encourage people to use GTT for reads.
Ok. moved to cpu.B
Quoted 34 lines
Quoted 34 lines
tests/gem_mocs_settings.c new file +33
-0+for (int index =0 ; index < table.size; index++) +igt_assert_eq (read_regs[index], + table.table[index].control_value); + +gem_close (fd, dst_handle); +} + +static void check_l3cc_registers (int fd, +const struct intel_execution_engine *engine, +uint32_t ctx_id, +bool dirty) +{ +struct mocs_table table; +uint32_t dst_handle =gem_create (fd,4096 ); +uint32_t *read_regs; +int index; + +igt_assert (get_mocs_settings (intel_get_drm_devid (fd), &table, dirty)); + +do_read_registers (fd, + ctx_id, + dst_handle, +GEN9_LNCFCMOCS0 , + (table.size +1 ) /2 , + engine->exec_id | engine->flags); + + read_regs =gem_mmap__gtt (fd, dst_handle,4096 ,PROT_READ ); + +for (index =0 ; index < table.size /2 ; index++) { +igt_assert_eq (read_regs[index] &0xffff , + table.table[index *2 ].l3cc_value); +igt_assert_eq (read_regs[index] >>16 , + table.table[index *2 +1 ].l3cc_value);
Quoted 8 lines
tests/gem_mocs_settings.c line 381
Quoted 6 lines
tests/gem_mocs_settings.c new file +6
-0+ } + +if (table.size &0x01 ) +igt_assert_eq (read_regs[index] &0xffff , + table.table[index *2 ].l3cc_value); +munmap()a
Ok.
Quoted 42 lines
Quoted 17 lines
tests/gem_mocs_settings.c new file +16
-0+gem_close (fd, dst_handle); +} + +static void test_context_mocs_values (int fd, +const struct intel_execution_engine *engine, +bool use_default) +{ +uint32_t ctx_id =0 ; + +if (!use_default) + ctx_id =gem_context_create (fd); + +check_control_registers (fd, engine, ctx_id, false); +check_l3cc_registers (fd, engine, ctx_id, false); + +if (!use_default)tests/gem_mocs_settings.c line 407
Quoted 10 lines
tests/gem_mocs_settings.c new file +10
-0+gem_context_destroy (fd, ctx_id); +} + +static void non_context_tests (unsigned mode) +{ +int fd =drm_open_driver_master (DRIVER_INTEL ); +const int gen =intel_gen (intel_get_drm_devid (fd)); +const struct intel_execution_engine *e; + +igt_require (gen >=9 );Make this a function like
has_mocs()so that the automatic message is a little more explanatory.Quoted 10 lines
tests/gem_mocs_settings.c new file +10
-0+ +igt_info ("Testing Non/Default Context Engines\n" ); +test_mocs_values (fd); + +switch (mode) { +case NONE :break ; +case RESET :igt_force_gpu_reset ();break ; +case SUSPEND :igt_system_suspend_autoresume ();break ; +case HIBERNATE :igt_system_hibernate_autoresume ();break ; + };
Quoted 8 lines
tests/gem_mocs_settings.c line 424
Quoted 6 lines
tests/gem_mocs_settings.c new file +6
-0+ +for (e = intel_execution_engines; e->name; e++) + +if (e->exec_id !=I915_EXEC_DEFAULT && +gem_has_ring (fd, e->exec_id | e->flags)) { +igt_info (" Engine: %s\n" , e->name);Both of these are debug, not info.
Ok.
Quoted 9 lines
tests/gem_mocs_settings.c line 430
Quoted 7 lines
tests/gem_mocs_settings.c new file +6
-0+test_context_mocs_values (fd, e, true); + } + +test_mocs_values (fd); + +drmDropMaster (fd);Superfluous; here and everywhere else.a
Ok.
Quoted 13 lines
tests/gem_mocs_settings.c line 439
Quoted 10 lines
tests/gem_mocs_settings.c new file +9
-0+close (fd); +} + +static void context_save_restore_test (unsigned mode) +{ +int fd =drm_open_driver_master (DRIVER_INTEL ); +const int gen =intel_gen (intel_get_drm_devid (fd)); +const struct intel_execution_engine *e; +uint32_t ctx_id =gem_context_create (fd);Should we not apply a little more stress here?
Quoted 2 lines
We need at least 2 active contexts in order to have one unpinned. Same for fds (the default context tests).
Don't think we need the extras testing. Just testing that the load the registers is good enough. We are not testing the context (per se) but the context loads do what they should do.
If the new fd sets the values correctly this is good enough.
Quoted 21 lines
Quoted 21 lines
tests/gem_mocs_settings.c new file +20
-0+ +igt_require (gen >=9 ); + +igt_info ("Testing Save Restore\n" ); + +for (e = intel_execution_engines; e->name; e++) +if (e->exec_id ==I915_EXEC_RENDER ) { +check_control_registers (fd, e, ctx_id, false); +check_l3cc_registers (fd, e, ctx_id, false); + } + +switch (mode) { +case NONE :break ; +case RESET :igt_force_gpu_reset ();break ; +case SUSPEND :igt_system_suspend_autoresume ();break ; +case HIBERNATE :igt_system_hibernate_autoresume ();break ; + }; + +for (e = intel_execution_engines; e->name; e++) +if (e->exec_id ==I915_EXEC_RENDER ) {
Quoted 10 lines
tests/gem_mocs_settings.c line 467
Quoted 8 lines
tests/gem_mocs_settings.c new file +8
-0+check_control_registers (fd, e, ctx_id, false); +check_l3cc_registers (fd, e, ctx_id, false); + } + +gem_context_destroy (fd, ctx_id); +drmDropMaster (fd); +close (fd); +}
--
Peter Antoine (Android Graphics Driver Software Engineer)
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
_______________________________________________
Intel-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 10 lines · Peter Antoine
Quoted 8 lines · Chris Wilson
tests/gem_mocs_settings.c line 259
Quoted 4 lines
tests/gem_mocs_settings.c new file +4
-0+ execbuf.flags =I915_EXEC_SECURE | engine_id; + +gem_execbuf (fd, &execbuf); +gem_sync (fd, handle);^ Papering over a bug in your code.
Hint: did you tell anyone that you were writing into the buffer?
Ok a
write_domainandgem_wait.
gem_wait isn't required, the order is enforced by gem_execbuf followed by gem_read or subsequent gem_set_domain (if using mmap interface). The API is geared towards explicit domain management. -Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 9 lines · Chris Wilson
Quoted 8 lines · Peter Antoine
Quoted 7 lines · Chris Wilson
tests/gem_mocs_settings.c line 259
Quoted 4 lines
tests/gem_mocs_settings.c new file +4
-0+ execbuf.flags =I915_EXEC_SECURE | engine_id; + +gem_execbuf (fd, &execbuf); +gem_sync (fd, handle);^ Papering over a bug in your code.
Quoted 7 lines
Quoted 2 lines
Quoted 1 line
Hint: did you tell anyone that you were writing into the buffer?
Ok a
write_domainandgem_wait.
gem_waitisn't required, the order is enforced bygem_execbuffollowed bygem_reador subsequentgem_set_domain(if using mmap interface). The API is geared towards explicit domain management. -Chris
Ok, done that. Will post a new version after you have had a chance to look at the version I just posted.
Peter.
Quoted 2 lines
--
Peter Antoine (Android Graphics Driver Software Engineer)
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
_______________________________________________
Intel-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx