Skip to contentSkip to conversation

staging: sm750fb: Replace printk() with pr_info().

PATCH Superseded Elise-Lennion 2 participants 2 messages Oct 4, 2016 – Oct 5, 2016

Subsystems (2)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: sm750fb: Replace printk() with pr_info().

Fix checkpatch warning:

WARNING: printk() should include KERN_ facility level

New checkpatch warning appears after including KERN_ facility level.

Fix checkpatch warning:

WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

v2: Fixed new checkpatch warning noted by Julia Lawall <[email protected]> Reworked to use pr_info() instead of printk()

---
 drivers/staging/sm750fb/ddk750_help.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/sm750fb/ddk750_help.c +1 -3
index 9637dd3..475a943 100644
@@ -11,7 +11,5 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
 	devId750 = devId;
 	revId750 = revId;
 	if (revId == 0xfe)
-		printk("found sm750le\n");
+		pr_info("found sm750le\n");
 }
-
-
Signature · 1 line
2.7.4
#1 lore raw
Quoted 6 lines · Elise-Lennion

Fix checkpatch warning:

WARNING: printk() should include KERN_ facility level

New checkpatch warning appears after including KERN_ facility level.

Quoted 8 lines

Fix checkpatch warning:

WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

v2: Fixed new checkpatch warning noted by Julia Lawall <[email protected]> Reworked to use pr_info() instead of printk()

v2 goes under the ---. The text above the --- is what goes into the git log. The text under the ---, up to the first diff, is dropped. The v2 information is not useful to keep in the code history, because the v1 is not there either.

You have the name properly in the signed off by line now, but it needs to match exactly the name in the From line, and that one still has the -.

julia

Quoted 28 lines
---
 drivers/staging/sm750fb/ddk750_help.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/sm750fb/ddk750_help.c +1 -4
index 9637dd3..475a943 100644
@@ -11,7 +11,5 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
 	devId750 = devId;
 	revId750 = revId;
 	if (revId == 0xfe)
-		printk("found sm750le\n");
+		pr_info("found sm750le\n");
 }
-
-
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161004225414.GA5712%40lennorien.com.
For more options, visit https://groups.google.com/d/optout.