irqchip: mxs: add missing set_handle_irq()
Subsystems (2)
PATCH 1/1 irqchip: mxs: add missing set_handle_irq()
this will fix IRQ related issues on Alphascale ASM9260
--- drivers/irqchip/irq-mxs.c | 1 + 1 file changed, 1 insertion(+)
drivers/irqchip/irq-mxs.c +1 -0
@@ -241,6 +241,7 @@ static int __init asm9260_of_init(struct device_node *np,writel (0 , icoll_priv.intr + i);icoll_add_domain (np,ASM9260_NUM_IRQS ); +set_handle_irq (icoll_handle_irq);return 0 ; }
Signature · 1 line
2.5.0
Quoted 1 line · Oleksij Rempel
this will fix IRQ related issues on Alphascale ASM9260
This really does not qualify as a changelog.
1) What's the problem and what consequences does it have
2) What's the fix.
Thanks,
tglx
Am 29.01.2016 um 09:33 schrieb Thomas Gleixner:
Quoted 6 lines · Oleksij Rempel
Quoted 2 lines
this will fix IRQ related issues on Alphascale ASM9260
This really does not qualify as a changelog.
Quoted 8 lines
1) What's the problem and what consequences does it have
2) What's the fix.
Thanks,
tglx
The driver provide this function:
asmlinkage void __exception_irq_entry icoll_handle_irq(struct pt_regs *regs)
{
u32 irqnr;
irqnr = __raw_readl(icoll_priv.stat);
__raw_writel(irqnr, icoll_priv.vector);
handle_domain_irq(icoll_domain, irqnr, regs);
}i assume at some late review point instead of move it to asm9260_of_init i removed it completely. As result, the driver was compilable but not working.
Should i put this explanation to changelog?
Signature · 2 lines
Regards, Oleksij
Quoted 26 lines · Oleksij Rempel
Am 29.01.2016 um 09:33 schrieb Thomas Gleixner:
Quoted 6 lines · Oleksij Rempel
Quoted 2 lines
this will fix IRQ related issues on Alphascale ASM9260
This really does not qualify as a changelog.
Quoted 8 lines
1) What's the problem and what consequences does it have
2) What's the fix.
Thanks,
tglx
The driver provide this function:
asmlinkage void__exception_irq_entryicoll_handle_irq(struct pt_regs *regs){ u32 irqnr; irqnr = __raw_readl(icoll_priv.stat); __raw_writel(irqnr, icoll_priv.vector); handle_domain_irq(icoll_domain, irqnr, regs); }
Quoted 4 lines
i assume at some late review point instead of move it to
asm9260_of_initi removed it completely. As result, the driver was compilable but not working.
Should i put this explanation to changelog?
So the problem is:
The rework of the driver missed to move the call to set_handle_irq() into asm9260_of_init(). As a consequence no interrupt entry point is installed and no interrupts are delivered (or whatever the outcome is, crash, explode ...)
Solution is:
Install the interrupt entry handler.
Right?
And that wants a tag:
So we can mark it for stable.
Thanks,
tglx
Am 29.01.2016 um 09:54 schrieb Thomas Gleixner:
Quoted 38 lines · Oleksij Rempel
Quoted 26 lines
Am 29.01.2016 um 09:33 schrieb Thomas Gleixner:
Quoted 6 lines · Oleksij Rempel
Quoted 2 lines
this will fix IRQ related issues on Alphascale ASM9260
This really does not qualify as a changelog.
Quoted 8 lines
1) What's the problem and what consequences does it have
2) What's the fix.
Thanks,
tglx
The driver provide this function:
asmlinkage void__exception_irq_entryicoll_handle_irq(struct pt_regs *regs){ u32 irqnr; irqnr = __raw_readl(icoll_priv.stat); __raw_writel(irqnr, icoll_priv.vector); handle_domain_irq(icoll_domain, irqnr, regs); }Quoted 4 lines
i assume at some late review point instead of move it to
asm9260_of_initi removed it completely. As result, the driver was compilable but not working.
Should i put this explanation to changelog?So the problem is:
The rework of the driver missed to move the call to
set_handle_irq()intoasm9260_of_init(). As a consequence no interrupt entry point is installed and no interrupts are delivered (or whatever the outcome is, crash, explode ...)
Quoted 5 lines
Solution is:
Install the interrupt entry handler.
Right?
Right.
Should i resend a patch with new comment?
Quoted 10 lines
And that wants a tag:
Fixes nnnnnnnnnnnn ("irqchip/......")So we can mark it for stable.
Thanks,
tglx
Signature · 2 lines
Regards, Oleksij
Quoted 1 line · Oleksij Rempel
Should i resend a patch with new comment?
Yes, please.
PATCH v2 1/1 irqchip: mxs: add missing set_handle_irq()
The rework of the driver missed to move the call to set_handle_irq() into asm9260_of_init(). As a consequence no interrupt entry point is installed and no interrupts are delivered
Solution is:
Install the interrupt entry handler.
--- drivers/irqchip/irq-mxs.c | 1 + 1 file changed, 1 insertion(+)
drivers/irqchip/irq-mxs.c +1 -0
@@ -241,6 +241,7 @@ static int __init asm9260_of_init(struct device_node *np,writel (0 , icoll_priv.intr + i);icoll_add_domain (np,ASM9260_NUM_IRQS ); +set_handle_irq (icoll_handle_irq);return 0 ; }
Signature · 1 line
2.5.0
tip-bot for Oleksij Rempel
merge bot[tip:irq/urgent] irqchip/mxs: Add missing set_handle_irq()
irqchip/mxs: Add missing set_handle_irq()
Commit-ID: c5b635203032462603c503ecce91a7021c1ad44a Gitweb: http://git.kernel.org/tip/c5b635203032462603c503ecce91a7021c1ad44a Author: Oleksij Rempel <[email protected]> AuthorDate: Fri, 29 Jan 2016 10:57:53 +0100 Committer: Thomas Gleixner <[email protected]> CommitDate: Fri, 29 Jan 2016 12:15:50 +0100
irqchip/mxs: Add missing set_handle_irq()
The rework of the driver missed to move the call to set_handle_irq() into asm9260_of_init(). As a consequence no interrupt entry point is installed and no interrupts are delivered
Solution is simple: Install the interrupt entry handler.
--- drivers/irqchip/irq-mxs.c | 1 + 1 file changed, 1 insertion(+)
drivers/irqchip/irq-mxs.c +1 -0
@@ -241,6 +241,7 @@ static int __init asm9260_of_init(struct device_node *np,writel (0 , icoll_priv.intr + i);icoll_add_domain (np,ASM9260_NUM_IRQS ); +set_handle_irq (icoll_handle_irq);return 0 ; }
Jason Cooper
AppliedQuoted 10 lines · Oleksij Rempel
The rework of the driver missed to move the call to
set_handle_irq()intoasm9260_of_init(). As a consequence no interrupt entry point is installed and no interrupts are deliveredSolution is:
Install the interrupt entry handler.
Quoted 7 lines
Fixes 7e4ac676ee ("irqchip/mxs: Add Alphascale ASM9260 support")Signed-off-by Oleksij Rempel <[email protected]>---
drivers/irqchip/irq-mxs.c| 1 +1 file changed, 1 insertion(+)
Applied to irqchip/urgent
Thx,
Jason.