Skip to contentSkip to conversation

Staging: ks7010: There should be no spaces at the start of a line

PATCH In review Arushi Singhal 4 participants 6 messages Feb 18, 2017 – Feb 19, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: ks7010: There should be no spaces at the start of a line

The following patch the checkpatch.pl warning:
drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the start of a line

---
 drivers/staging/ks7010/ks_hostif.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/ks7010/ks_hostif.c +2 -2
index 819e08b5fa91..3b2e28749b63 100644
@@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info)
 	}
 	DPRINTK(4, "\n    Link AP\n");
 	DPRINTK(4, "    bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \
-   essid=%s\n    rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n    channel=%d\n \
-   rssi=%d\n    sq=%d\n    capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability);
+essid=%s\n    rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n    channel=%d\n \
+rssi=%d\n    sq=%d\n    capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability);
 	DPRINTK(4, "\n    Link AP\n    rsn.mode=%d\n    rsn.size=%d\n",
 		ap_info->rsn_mode, ap_info->rsn.size);
 	DPRINTK(4, "\n    ext_rate_set_size=%d\n    rate_set_size=%d\n",
Signature · 1 line
2.11.0
maintainer
#1 lore raw
Quoted 14 lines · Arushi Singhal

The following patch the checkpatch.pl warning:
drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the start of a line

---
 drivers/staging/ks7010/ks_hostif.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/ks7010/ks_hostif.c +0 -0
index 819e08b5fa91..3b2e28749b63 100644

drivers/staging/ks7010/ks_hostif.c int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info) · line 195

Quoted 7 lines
drivers/staging/ks7010/ks_hostif.c +2 -2
@@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info)
 	}
 	DPRINTK(4, "\n    Link AP\n");
 	DPRINTK(4, "    bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \
-   essid=%s\n    rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n    channel=%d\n \
-   rssi=%d\n    sq=%d\n    capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability);
+essid=%s\n    rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n    channel=%d\n \
+rssi=%d\n    sq=%d\n    capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability);

So don't just remove the spaces, fix it correctly with the proper indentation please.

thanks,

greg k-h

#2 lore raw

Hi Greg
I think we cannot indent the text otherwise, the print statement will be different as it should be
Thanks

Quoted 45 lines · gregkh

Review

Quoted 10 lines · Arushi Singhal

The following patch the checkpatch.pl warning:
drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the start of a line

---

 drivers/staging/ks7010/ks_hostif.c | 4 ++-- 
 1 file changed, 2 insertions(+), 2 deletions(-) 
(quoted diff) +0 -0

b/drivers/staging/ks7010/ks_hostif.c

drivers/staging/ks7010/ks_hostif.c int get_current_ap(struct ks_wlan_private *priv,

Quoted 4 lines

index 819e08b5fa91..3b2e28749b63 100644

drivers/staging/ks7010/ks_hostif.c +0 -0
@@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private *priv, 

struct link_ap_info_t *ap_info)

drivers/staging/ks7010/ks_hostif.c int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info)

Quoted 4 lines
drivers/staging/ks7010/ks_hostif.c +0 -1
         } 
         DPRINTK(4, "\n    Link AP\n"); 
         DPRINTK(4, "    bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \ 
-   essid=%s\n    rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n   

channel=%d\n \

drivers/staging/ks7010/ks_hostif.c int get_current_ap(struct ks_wlan_private *priv, · line 195

Quoted 1 line
drivers/staging/ks7010/ks_hostif.c +0 -1
-   rssi=%d\n    sq=%d\n    capability=%04X\n", ap->bssid[0], 

ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability);

drivers/staging/ks7010/ks_hostif.c int get_current_ap(struct ks_wlan_private *priv, · line 194

Quoted 1 line
drivers/staging/ks7010/ks_hostif.c +1 -0
+essid=%s\n    rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n   

channel=%d\n \

drivers/staging/ks7010/ks_hostif.c int get_current_ap(struct ks_wlan_private *priv, · line 195

Quoted 1 line
drivers/staging/ks7010/ks_hostif.c +1 -0
+rssi=%d\n    sq=%d\n    capability=%04X\n", ap->bssid[0], ap->bssid[1], 

ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability);

So don't just remove the spaces, fix it correctly with the proper indentation please.

thanks,

greg k-h

#3 lore raw
Quoted 4 lines · Arushi Singhal

Hi Greg
I think we cannot indent the text otherwise, the print statement will be different as it should be

There are newlines in the printed string. I suspect that there is no need to print them all at once.

Actually, your change removed spaces inside a string, so it did change the form of the poutput.

Also, remember not to top post :)

julia

Quoted 67 lines

Thanks

On Saturday, February 18, 2017 at 10:27:19 PM UTC+5:30, gregkh wrote:

      On Sat, Feb 18, 2017 at 10:10:02PM +0530, Arushi Singhal wrote:
      > The following patch the checkpatch.pl warning:
      > drivers/staging/ks7010/ks_hostif.c warning: please, no spaces
      at the
      > start of a line
      >
      > Signed-off-by: Arushi Singhal <[email protected]>
      > ---
      >  drivers/staging/ks7010/ks_hostif.c | 4 ++--
      >  1 file changed, 2 insertions(+), 2 deletions(-)
      >
      > diff --git a/drivers/staging/ks7010/ks_hostif.c
      b/drivers/staging/ks7010/ks_hostif.c
      > index 819e08b5fa91..3b2e28749b63 100644
      > --- a/drivers/staging/ks7010/ks_hostif.c
      > +++ b/drivers/staging/ks7010/ks_hostif.c
      > @@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private
      *priv, struct link_ap_info_t *ap_info)
      >          }
      >          DPRINTK(4, "\n    Link AP\n");
      >          DPRINTK(4, "    bssid=%02X:%02X:%02X:%02X:%02X:%02X\n
      \
      > -   essid=%s\n  
       rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n  
       channel=%d\n \
      > -   rssi=%d\n    sq=%d\n    capability=%04X\n", ap->bssid[0],
      ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4],
      ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0],
      ap->rate_set.body[1], ap->rate_set.body[2],
      ap->rate_set.body[3], ap->rate_set.body[4],
      ap->rate_set.body[5], ap->rate_set.body[6],
      ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq,
      ap->capability);
      > +essid=%s\n  
       rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n  
       channel=%d\n \
      > +rssi=%d\n    sq=%d\n    capability=%04X\n", ap->bssid[0],
      ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4],
      ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0],
      ap->rate_set.body[1], ap->rate_set.body[2],
      ap->rate_set.body[3], ap->rate_set.body[4],
      ap->rate_set.body[5], ap->rate_set.body[6],
      ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq,
      ap->capability);

      So don't just remove the spaces, fix it correctly with the
      proper
      indentation please.

      thanks,

      greg k-h

--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/df1dbfa6-0823-4899-b1b7- 4358b18575be%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

#4 lore raw
In reply to Arushi Singhal
Quoted 14 lines · Arushi Singhal

The following patch the checkpatch.pl warning:
drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the start of a line

---
 drivers/staging/ks7010/ks_hostif.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/ks7010/ks_hostif.c +0 -0
index 819e08b5fa91..3b2e28749b63 100644

drivers/staging/ks7010/ks_hostif.c int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info) · line 195

Quoted 7 lines
drivers/staging/ks7010/ks_hostif.c +2 -2
@@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info)
 	}
 	DPRINTK(4, "\n    Link AP\n");
 	DPRINTK(4, "    bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \
-   essid=%s\n    rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n    channel=%d\n \
-   rssi=%d\n    sq=%d\n    capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability);
+essid=%s\n    rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n    channel=%d\n \
+rssi=%d\n    sq=%d\n    capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability);

The code looks like a mess. How about breaking up the call at the newlines, and then propagating the arguments to the appropriate calls.

There is also a checkpatch error about strings on more than one line, that this also violates.

julia

Quoted 13 lines
drivers/staging/ks7010/ks_hostif.c +0 -1
 	DPRINTK(4, "\n    Link AP\n    rsn.mode=%d\n    rsn.size=%d\n",
 		ap_info->rsn_mode, ap_info->rsn.size);
 	DPRINTK(4, "\n    ext_rate_set_size=%d\n    rate_set_size=%d\n",
--

2.11.0

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218164002.GA7269%40arushi-HP-Pavilion-Notebook.
For more options, visit https://groups.google.com/d/optout.

#5 lore raw
Quoted 4 lines · Julia Lawall
Quoted 3 lines · Arushi Singhal

The following patch the checkpatch.pl warning:
drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the start of a line

[]

Quoted 1 line

drivers/staging/ks7010/ks_hostif.c

Quoted 1 line
drivers/staging/ks7010/ks_hostif.c +0 -0

[]

Quoted 12 lines

drivers/staging/ks7010/ks_hostif.c int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info) · line 195

Quoted 8 lines
drivers/staging/ks7010/ks_hostif.c +2 -2
@@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info)
 	}
 	DPRINTK(4, "\n    Link AP\n");
 	DPRINTK(4, "    bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \
-   essid=%s\n    rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n    channel=%d\n \
-   rssi=%d\n    sq=%d\n    capability=%04X\n", ap->bssid
+essid=%s\n    rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n    channel=%d\n \
+rssi=%d\n    sq=%d\n    capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability);

The code looks like a mess. How about breaking up the call at the newlines, and then propagating the arguments to the appropriate calls.

Quoted 2 lines

There is also a checkpatch error about strings on more than one line, that this also violates.

There are also vsprintf %p<foo> extensions that would simplify the code for this output and for many others.

see Documentation/printk-formats.txt

something like:

	DPRINTK(4, "    bssid=%pM\n", ap->bssid);
	DPRINTK(4, "    essid=%s\n", ap->ssid.body);
	DPRINTK(4, "    rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n",
		ap->rate_set.body[0], ap->rate_set.body[1],
		ap->rate_set.body[2], ap->rate_set.body[3],
		ap->rate_set.body[4], ap->rate_set.body[5],
		ap->rate_set.body[6], ap->rate_set.body[7]);	
	DPRINTK(4, "    channel=%d\n", ap->channel);
	DPRINTK(4, "    rssi=%d\n", ap->rssi);
	DPRINTK(4, "    sq=%d\n", ap->sq);
	DPRINTK(4, "   

capability=%04X\n", ap->capability);