Skip to contentSkip to conversation

staging: xgifb: function prototype argument should have an identifier name

PATCH In review Arushi Singhal 3 participants 6 messages Feb 22, 2017 – Feb 25, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: xgifb: function prototype argument should have an identifier name

function prototype arguments like 'struct vb_device_info *','unsigned long' etc. should have an identifier name.

---
Changes in v3:
- By mistake one irrelevant line was added which is removed in this patch.
- write the changes done in previous version in correct format.
- make the commit subject more relevant and accurate.

---
 drivers/staging/xgifb/vb_setmode.h | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/staging/xgifb/vb_setmode.h +9 -9
index 6f082a7a5a4a..c6317ab00474 100644
@@ -1,14 +1,14 @@
 #ifndef _VBSETMODE_
 #define _VBSETMODE_
 
-void InitTo330Pointer(unsigned char, struct vb_device_info *);
-void XGI_UnLockCRT2(struct vb_device_info *);
-void XGI_LockCRT2(struct vb_device_info *);
-void XGI_DisplayOff(struct xgifb_video_info *,
-		    struct xgi_hw_device_info *,
-		    struct vb_device_info *);
-void XGI_GetVBType(struct vb_device_info *);
-void XGI_SenseCRT1(struct vb_device_info *);
+void InitTo330Pointer(unsigned char ChipType, struct vb_device_info *pVBInfo);
+void XGI_UnLockCRT2(struct vb_device_info *pVBInfo);
+void XGI_LockCRT2(struct vb_device_info *pVBInfo);
+void XGI_DisplayOff(struct xgifb_video_info *xgifb_info,
+		    struct xgi_hw_device_info *pXGIHWDE,
+		    struct vb_device_info *pVBInfo);
+void XGI_GetVBType(struct vb_device_info *pVBInfo);
+void XGI_SenseCRT1(struct vb_device_info *pVBInfo);
 unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info,
 			    struct xgi_hw_device_info *HwDeviceExtension,
 			    unsigned short ModeNo);
@@ -18,6 +18,6 @@ unsigned char XGI_SearchModeID(unsigned short ModeNo,
 unsigned short XGI_GetRatePtrCRT2(struct xgi_hw_device_info *pXGIHWDE,
 				  unsigned short ModeNo,
 				  unsigned short ModeIdIndex,
-				  struct vb_device_info *);
+				  struct vb_device_info *pVBInfo);
 
 #endif
Signature · 1 line
2.11.0
#1 lore raw
Quoted 10 lines · Arushi Singhal

function prototype arguments like 'struct vb_device_info *','unsigned long' etc. should have an identifier name.

---
Changes in v3:
- By mistake one irrelevant line was added which is removed in this patch.
- write the changes done in previous version in correct format.
- make the commit subject more relevant and accurate.

This patch doesn't apply to my tree at all :(

sorry,

greg k-h

#2 lore raw
Quoted 12 lines · Greg Kroah-Hartman
Quoted 10 lines · Arushi Singhal

function prototype arguments like 'struct vb_device_info *','unsigned long' etc. should have an identifier name.

---
Changes in v3:
- By mistake one irrelevant line was added which is removed in this patch.
- write the changes done in previous version in correct format.
- make the commit subject more relevant and accurate.

Quoted 3 lines

This patch doesn't apply to my tree at all :(

Why this is so?

thanks
Arushi

Quoted 4 lines

sorry,

greg k-h

#3 lore raw
Quoted 20 lines · Arushi Singhal

On Fri, Feb 24, 2017 at 10:01 PM, Greg Kroah-Hartman <[email protected]> wrote:
On Wed, Feb 22, 2017 at 04:49:19PM +0530, Arushi Singhal wrote:
> function prototype arguments like 'struct vb_device_info *','unsigned
> long' etc. should have an identifier name.
>
> Signed-off-by: Arushi Singhal <[email protected]>
> ---
> Changes in v3:
>   - By mistake one irrelevant line was added which is removed in this
>     patch.
>   - write the changes done in previous version in correct format.
>   - make the commit subject more relevant and accurate.

Quoted 3 lines

This patch doesn't apply to my tree at all :(

Why this is so?

Maybe someone else made a change on the same lines as yours. Check that your tree is up to date.

julia

Quoted 18 lines

thanks
Arushi
sorry,

greg k-h

--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF_sihk6_UhgLzUH6 FVSFMu02Vadp1tjatQft-UJ14SJeA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

#4 lore raw
Quoted 24 lines · Julia Lawall
Quoted 20 lines · Arushi Singhal

On Fri, Feb 24, 2017 at 10:01 PM, Greg Kroah-Hartman <[email protected]> wrote:
On Wed, Feb 22, 2017 at 04:49:19PM +0530, Arushi Singhal wrote:
> function prototype arguments like 'struct vb_device_info *','unsigned
> long' etc. should have an identifier name.
>
> Signed-off-by: Arushi Singhal <[email protected]>
> ---
> Changes in v3:
> - By mistake one irrelevant line was added which is removed
in this
> patch.
> - write the changes done in previous version in correct
format.
> - make the commit subject more relevant and accurate.

Quoted 7 lines
Quoted 3 lines
      This patch doesn't apply to my tree at all :(

Why this is so?

Maybe someone else made a change on the same lines as yours. Check that your tree is up to date.

Is all the changes being done by someone before?

Quoted 22 lines

julia

Quoted 7 lines

thanks
Arushi
sorry,

greg k-h

Quoted 7 lines

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected]. To view this discussion on the web visithttps://groups.google.

com/d/msgid/outreachy-kernel/CA%2BXqjF_sihk6_UhgLzUH6

Quoted 4 lines

FVSFMu02Vadp1tjatQft-UJ14SJeA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.

#5 lore raw
Quoted 36 lines · Arushi Singhal

On Fri, Feb 24, 2017 at 10:18 PM, Julia Lawall <[email protected]> wrote:

On Fri, 24 Feb 2017, Arushi Singhal wrote:

>
>
> On Fri, Feb 24, 2017 at 10:01 PM, Greg Kroah-Hartman > <[email protected]> wrote:
>       On Wed, Feb 22, 2017 at 04:49:19PM +0530, Arushi Singhal wrote:
>       > function prototype arguments like 'struct vb_device_info
>       *','unsigned
>       > long' etc. should have an identifier name. >       >
>       > Signed-off-by: Arushi Singhal
>       <[email protected]>
>       > ---
>       > Changes in v3:
>       >   - By mistake one irrelevant line was added which is removed
>       in this
>       >     patch.
>       >   - write the changes done in previous version in correct
>       format.
>       >   - make the commit subject more relevant and accurate.
>
>       This patch doesn't apply to my tree at all :( >
> Why this is so?

Quoted 5 lines

Maybe someone else made a change on the same lines as yours. Check that
your tree is up to date.

Is all the changes being done by someone before?

I don't know. Just update your tree and try to apply your patch again. Or look at the code that your patch should apply to. It should be easy to see what is wrong.

julia

Quoted 38 lines
      julia

      > thanks
      > Arushi
      >       sorry,
      >
      >       greg k-h
      >
      >
Quoted 2 lines

--
You received this message because you are subscribed to the Google

Groups

Quoted 2 lines

"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it,

send an

Quoted 2 lines

email to [email protected]. To post to this group, send email to

[email protected].

Quoted 1 line

To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF_sihk6_Uhg

LzUH6

Quoted 4 lines

FVSFMu02Vadp1tjatQft-UJ14SJeA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF91bd_er%2BidvUB PZCTYFHaxF6Mgf1oQ6vTz9gmk6ggC6Q%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.