Skip to contentSkip to conversation

drm/i915/cfl: Basic DDI plumbing for Coffee Lake. (fwd)

PATCH Julia Lawall 2 participants 2 messages Jun 11, 2017 – Jun 12, 2017

lore
Share & tools
lore
#0 lore raw

Hello,

There are two tests on IS_KBL_ULT on line 423. Please check on whether this is intentional.

thanks,
julia

---------- Forwarded message ----------
Date: Mon, 12 Jun 2017 01:20:56 +0800
From: kbuild test robot <[email protected]>
To: [email protected]
Cc: Julia Lawall <[email protected]>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/cfl: Basic DDI plumbing for Coffee
Lake.

CC: [email protected]
In-Reply-To: <[email protected]>
TO: Rodrigo Vivi <[email protected]>
CC: [email protected], Dhinakaran Pandiyan <[email protected]>, Rodrigo Vivi <[email protected]>
CC: Dhinakaran Pandiyan <[email protected]>, Rodrigo Vivi <[email protected]>

Hi Rodrigo,

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v4.12-rc4 next-20170609]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Rodrigo-Vivi/drm-i915-cfl-Basic-DDI-plumbing-for-Coffee-Lake/20170611-230941
base:   git://anongit.freedesktop.org/drm-intel for-linux-next

:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago

Quoted 1 line
Quoted 1 line

drivers/gpu/drm/i915/intel_ddi.c:423:37-57: duplicated argument to && or ||

git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 8ee2d3e5ef67af019c1db3062d9e9fbfca0fa616 vim +423 drivers/gpu/drm/i915/intel_ddi.c

8ee2d3e5 Rodrigo Vivi    2017-06-09  407  	} else if (IS_KBL_ULT(dev_priv) || IS_CFL_ULT(dev_priv)) {
0fdd4918 Rodrigo Vivi    2016-10-18  408  		*n_entries = ARRAY_SIZE(kbl_u_ddi_translations_dp);
0fdd4918 Rodrigo Vivi    2016-10-18  409  		return kbl_u_ddi_translations_dp;
0fdd4918 Rodrigo Vivi    2016-10-18  410  	} else {
0fdd4918 Rodrigo Vivi    2016-10-18  411  		*n_entries = ARRAY_SIZE(kbl_ddi_translations_dp);
0fdd4918 Rodrigo Vivi    2016-10-18  412  		return kbl_ddi_translations_dp;
0fdd4918 Rodrigo Vivi    2016-10-18  413  	}
0fdd4918 Rodrigo Vivi    2016-10-18  414  }
0fdd4918 Rodrigo Vivi    2016-10-18  415
0fdd4918 Rodrigo Vivi    2016-10-18  416  static const struct ddi_buf_trans *
78ab0bae Ville Syrjälä   2015-12-08  417  skl_get_buf_trans_edp(struct drm_i915_private *dev_priv, int *n_entries)
f8896f5d David Weinehall 2015-06-25  418  {
06411f08 Jani Nikula     2016-03-24  419  	if (dev_priv->vbt.edp.low_vswing) {
78ab0bae Ville Syrjälä   2015-12-08  420  		if (IS_SKL_ULX(dev_priv) || IS_KBL_ULX(dev_priv)) {
5f8b2531 Rodrigo Vivi    2015-08-24  421  			*n_entries = ARRAY_SIZE(skl_y_ddi_translations_edp);
acee2998 Ville Syrjälä   2015-12-08  422  			return skl_y_ddi_translations_edp;
8ee2d3e5 Rodrigo Vivi    2017-06-09 @423  		} else if (IS_SKL_ULT(dev_priv) || IS_KBL_ULT(dev_priv) ||
8ee2d3e5 Rodrigo Vivi    2017-06-09  424  			   IS_KBL_ULT(dev_priv)) {
f8896f5d David Weinehall 2015-06-25  425  			*n_entries = ARRAY_SIZE(skl_u_ddi_translations_edp);
acee2998 Ville Syrjälä   2015-12-08  426  			return skl_u_ddi_translations_edp;
f8896f5d David Weinehall 2015-06-25  427  		} else {
f8896f5d David Weinehall 2015-06-25  428  			*n_entries = ARRAY_SIZE(skl_ddi_translations_edp);
acee2998 Ville Syrjälä   2015-12-08  429  			return skl_ddi_translations_edp;
f8896f5d David Weinehall 2015-06-25  430  		}
f8896f5d David Weinehall 2015-06-25  431  	}

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#1 lore raw

Patch Merges to dinq, thanks for the reviews.

Julia,

DK had also pointed that out and the issue was addressed on latest version that got reviewed and merged.

I'm sorry but I only saw your comment after I had merged the patch, otherwise I'd have mentioned you also.

Quoted 89 lines · Julia Lawall

Hello,

There are two tests on IS_KBL_ULT on line 423. Please check on whether this is intentional.

thanks,
julia

---------- Forwarded message ----------
Date: Mon, 12 Jun 2017 01:20:56 +0800
From: kbuild test robot <[email protected]>
To: [email protected]
Cc: Julia Lawall <[email protected]>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/cfl: Basic DDI plumbing for Coffee
Lake.

CC: [email protected]
In-Reply-To: <[email protected]>
TO: Rodrigo Vivi <[email protected]>
CC: [email protected], Dhinakaran Pandiyan < [email protected]>, Rodrigo Vivi <[email protected]>
CC: Dhinakaran Pandiyan <[email protected]>, Rodrigo Vivi < [email protected]>

Hi Rodrigo,

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v4.12-rc4 next-20170609]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:
https://github.com/0day-ci/linux/commits/Rodrigo-Vivi/drm-i915-cfl-Basic-DDI-plumbing-for-Coffee-Lake/20170611-230941
base: git://anongit.freedesktop.org/drm-intel for-linux-next
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago

Quoted 1 line
Quoted 1 line

drivers/gpu/drm/i915/intel_ddi.c:423:37-57: duplicated argument to &&

or ||

git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 8ee2d3e5ef67af019c1db3062d9e9fbfca0fa616 vim +423 drivers/gpu/drm/i915/intel_ddi.c

8ee2d3e5 Rodrigo Vivi 2017-06-09 407 } else if
(IS_KBL_ULT(dev_priv) || IS_CFL_ULT(dev_priv)) {
0fdd4918 Rodrigo Vivi 2016-10-18 408 *n_entries =
ARRAY_SIZE(kbl_u_ddi_translations_dp);
0fdd4918 Rodrigo Vivi 2016-10-18 409 return
kbl_u_ddi_translations_dp;

0fdd4918 Rodrigo Vivi    2016-10-18  410        } else {
0fdd4918 Rodrigo Vivi    2016-10-18  411                *n_entries =
ARRAY_SIZE(kbl_ddi_translations_dp);
0fdd4918 Rodrigo Vivi    2016-10-18  412                return
kbl_ddi_translations_dp;
0fdd4918 Rodrigo Vivi    2016-10-18  413        }
0fdd4918 Rodrigo Vivi    2016-10-18  414  }
0fdd4918 Rodrigo Vivi    2016-10-18  415
0fdd4918 Rodrigo Vivi    2016-10-18  416  static const struct

ddi_buf_trans *
78ab0bae Ville Syrjälä 2015-12-08 417 skl_get_buf_trans_edp(struct
drm_i915_private *dev_priv, int *n_entries)
f8896f5d David Weinehall 2015-06-25 418 {
06411f08 Jani Nikula 2016-03-24 419 if
(dev_priv->vbt.edp.low_vswing) {
78ab0bae Ville Syrjälä 2015-12-08 420 if
(IS_SKL_ULX(dev_priv) || IS_KBL_ULX(dev_priv)) {
5f8b2531 Rodrigo Vivi 2015-08-24 421 *n_entries
= ARRAY_SIZE(skl_y_ddi_translations_edp);
acee2998 Ville Syrjälä 2015-12-08 422 return
skl_y_ddi_translations_edp;
8ee2d3e5 Rodrigo Vivi 2017-06-09 @423 } else if
(IS_SKL_ULT(dev_priv) || IS_KBL_ULT(dev_priv) ||
8ee2d3e5 Rodrigo Vivi 2017-06-09 424
IS_KBL_ULT(dev_priv)) {
f8896f5d David Weinehall 2015-06-25 425 *n_entries
= ARRAY_SIZE(skl_u_ddi_translations_edp);
acee2998 Ville Syrjälä 2015-12-08 426 return
skl_u_ddi_translations_edp;
f8896f5d David Weinehall 2015-06-25 427 } else {
f8896f5d David Weinehall 2015-06-25 428 *n_entries
= ARRAY_SIZE(skl_ddi_translations_edp);
acee2998 Ville Syrjälä 2015-12-08 429 return
skl_ddi_translations_edp;
f8896f5d David Weinehall 2015-06-25 430 }
f8896f5d David Weinehall 2015-06-25 431 }

Quoted 9 lines

---
0-DAY kernel test infrastructure Open Source Technology
Center
https://lists.01.org/pipermail/kbuild-all Intel
Corporation_______________________________________________ Intel-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx