Staging: ccree: ssi_cipher.c: Make comment more comprehensible.

PATCH In review Srishti Sharma 2 participants 5 messages Sep 6, 2017

Subsystems (2)

Staging Crypto API

lore

Share & tools

lore

Srishti Sharma

author

2017-09-06 20:56 UTC #0 lore raw

PATCH v2 1/1 Staging: ccree: ssi_cipher.c: Make comment more comprehensible.

Edited comment to make it more comprehensible.

Signed-off-by Srishti Sharma <[email protected]>

---
Changes in v2:
- Make comment more comprehensible , instead of just correcting typos.

 drivers/staging/ccree/ssi_cipher.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

drivers/staging/ccree/ssi_cipher.c +3 -1

index 99232b2..fec2faa 100644
@@ -702,7 +702,9 @@ static int ssi_blkcipher_complete(struct device *dev,
 
 	ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
 
-	/*Set the inflight counter value to local variable*/
+	/*
+	 * Save inflight_counter in a local variable.
+	 */
 	inflight_counter =  ctx_p->drvdata->inflight_counter;
 	/*Decrease the inflight counter*/
 	if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)

--
2.7.4

Julia Lawall

2017-09-06 20:58 UTC #1 lore raw

Quoted 14 lines · Srishti Sharma

Edited comment to make it more comprehensible.
Signed-off-by Srishti Sharma <[email protected]>
---
Changes in v2:
- Make comment more comprehensible , instead of just correcting typos.
 drivers/staging/ccree/ssi_cipher.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/ccree/ssi_cipher.c +0 -0
index 99232b2..fec2faa 100644

drivers/staging/ccree/ssi_cipher.c static int ssi_blkcipher_complete(struct device *dev, · line 707

Quoted 7 lines

drivers/staging/ccree/ssi_cipher.c +3 -1

@@ -702,7 +702,9 @@ static int ssi_blkcipher_complete(struct device *dev,
 
 	ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
 
-	/*Set the inflight counter value to local variable*/
+	/*
+	 * Save inflight_counter in a local variable.
+	 */

This is the format for multiline comments. Your comments is only one line. You just need to add spaces around the text, as compared to the original version.

julia

Quoted 13 lines

drivers/staging/ccree/ssi_cipher.c +0 -1
 	inflight_counter =  ctx_p->drvdata->inflight_counter;
 	/*Decrease the inflight counter*/
 	if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
--
2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504731390-9536-1-git-send-email-srishtishar%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Srishti Sharma

author

2017-09-06 21:00 UTC #2 lore raw

Quoted 30 lines · Julia Lawall

Quoted 14 lines · Srishti Sharma
Edited comment to make it more comprehensible.
Signed-off-by Srishti Sharma <[email protected]>
---
Changes in v2:
- Make comment more comprehensible , instead of just correcting typos.
 drivers/staging/ccree/ssi_cipher.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/ccree/ssi_cipher.c +0 -0
index 99232b2..fec2faa 100644
drivers/staging/ccree/ssi_cipher.c static int ssi_blkcipher_complete(struct device *dev, · line 707
Quoted 7 lines
drivers/staging/ccree/ssi_cipher.c +3 -1
@@ -702,7 +702,9 @@ static int ssi_blkcipher_complete(struct device *dev,
 
      ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
 
-     /*Set the inflight counter value to local variable*/
+     /*
+      * Save inflight_counter in a local variable.
+      */
This is the format for multiline comments. Your comments is only one line. You just need to add spaces around the text, as compared to the original version.

Quoted 15 lines

julia
Quoted 13 lines
drivers/staging/ccree/ssi_cipher.c +0 -1
      inflight_counter =  ctx_p->drvdata->inflight_counter;
      /*Decrease the inflight counter*/
      if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
--
2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504731390-9536-1-git-send-email-srishtishar%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Okay, Thanks I'll re-send it .

Regards,
Srishti

Julia Lawall

2017-09-06 21:02 UTC #3 lore raw

Quoted 47 lines · Srishti Sharma

Quoted 30 lines · Julia Lawall
Quoted 14 lines · Srishti Sharma
Edited comment to make it more comprehensible.
Signed-off-by Srishti Sharma <[email protected]>
---
Changes in v2:
- Make comment more comprehensible , instead of just correcting typos.
 drivers/staging/ccree/ssi_cipher.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/ccree/ssi_cipher.c +0 -0
index 99232b2..fec2faa 100644
drivers/staging/ccree/ssi_cipher.c static int ssi_blkcipher_complete(struct device *dev, · line 707
Quoted 7 lines
drivers/staging/ccree/ssi_cipher.c +3 -1
@@ -702,7 +702,9 @@ static int ssi_blkcipher_complete(struct device *dev,
 
      ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
 
-     /*Set the inflight counter value to local variable*/
+     /*
+      * Save inflight_counter in a local variable.
+      */
This is the format for multiline comments. Your comments is only one line. You just need to add spaces around the text, as compared to the original version.
Quoted 15 lines
julia
Quoted 13 lines
drivers/staging/ccree/ssi_cipher.c +0 -1
      inflight_counter =  ctx_p->drvdata->inflight_counter;
      /*Decrease the inflight counter*/
      if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
--
2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504731390-9536-1-git-send-email-srishtishar%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Quoted 1 line

Okay, Thanks I'll re-send it .

While it is good not to top post, you can put your response under my text, not all the way at the end of the message.

julia

Quoted 11 lines

Regards,
Srishti
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAB3L5owNmnR5poc9a3pH-fp%2Bm7us4yztzPs9dzNRjzYVEneRgA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Srishti Sharma

author

2017-09-06 21:09 UTC #4 lore raw

Quoted 51 lines · Julia Lawall

Quoted 47 lines · Srishti Sharma
Quoted 45 lines · Julia Lawall
Quoted 14 lines · Srishti Sharma
Edited comment to make it more comprehensible.
Signed-off-by Srishti Sharma <[email protected]>
---
Changes in v2:
- Make comment more comprehensible , instead of just correcting typos.
 drivers/staging/ccree/ssi_cipher.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/ccree/ssi_cipher.c +0 -0
index 99232b2..fec2faa 100644
drivers/staging/ccree/ssi_cipher.c static int ssi_blkcipher_complete(struct device *dev, · line 707
Quoted 7 lines
drivers/staging/ccree/ssi_cipher.c +3 -1
@@ -702,7 +702,9 @@ static int ssi_blkcipher_complete(struct device *dev,
 
      ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
 
-     /*Set the inflight counter value to local variable*/
+     /*
+      * Save inflight_counter in a local variable.
+      */
This is the format for multiline comments. Your comments is only one line. You just need to add spaces around the text, as compared to the original version.
julia
Quoted 13 lines
drivers/staging/ccree/ssi_cipher.c +0 -1
      inflight_counter =  ctx_p->drvdata->inflight_counter;
      /*Decrease the inflight counter*/
      if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
--
2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504731390-9536-1-git-send-email-srishtishar%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Quoted 4 lines

Quoted 1 line
Okay, Thanks I'll re-send it .
While it is good not to top post, you can put your response under my text, not all the way at the end of the message.

Okay, will take care !

Regards,
Srishti

Quoted 14 lines

julia
Quoted 11 lines
Regards,
Srishti
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAB3L5owNmnR5poc9a3pH-fp%2Bm7us4yztzPs9dzNRjzYVEneRgA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.