staging: Android: follow coding guidlines

PATCH In review Keerthi Reddy 3 participants 5 messages Sep 13, 2017 – Sep 15, 2017 Staging

lore

Share & tools

lore

Keerthi Reddy

author

2017-09-13 17:12 UTC #0 lore raw

PATCH 1/1 staging: Android: follow coding guidlines

- Add a new line after struct declaration
- remove extra new line.

Signed-off-by Keerthi Reddy <[email protected]>

---
 drivers/staging/android/ion/ion.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/android/ion/ion.h +1 -1

index 621e5f7..f5f9cd6 100644
@@ -86,6 +86,7 @@ struct ion_buffer {
 	struct sg_table *sg_table;
 	struct list_head attachments;
 };
+
 void ion_buffer_destroy(struct ion_buffer *buffer);
 
 /**

@@ -299,7 +300,6 @@ size_t ion_heap_freelist_shrink(struct ion_heap *heap,
  */
 size_t ion_heap_freelist_size(struct ion_heap *heap);
 
-
 /**
  * functions for creating and destroying a heap pool -- allows you
  * to keep a pool of pre allocated memory to use from your heap.  Keeping

Signature · 1 line

2.7.4

Julia Lawall

Acked-by on v1 1/1

2017-09-13 20:10 UTC #1 lore raw

Quoted 4 lines · Keerthi Reddy

- Add a new line after struct declaration
- remove extra new line.
Signed-off-by Keerthi Reddy <[email protected]>

Acked-by Julia Lawall <[email protected]>

Quoted 34 lines

---
 drivers/staging/android/ion/ion.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/android/ion/ion.h +1 -2
index 621e5f7..f5f9cd6 100644
@@ -86,6 +86,7 @@ struct ion_buffer {
 	struct sg_table *sg_table;
 	struct list_head attachments;
 };
+
 void ion_buffer_destroy(struct ion_buffer *buffer);
 
 /**
@@ -299,7 +300,6 @@ size_t ion_heap_freelist_shrink(struct ion_heap *heap,
  */
 size_t ion_heap_freelist_size(struct ion_heap *heap);
 
-
 /**
  * functions for creating and destroying a heap pool -- allows you
  * to keep a pool of pre allocated memory to use from your heap.  Keeping
--
2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170913171234.GA4052%40manoharreddy.
For more options, visit https://groups.google.com/d/optout.

Keerthi Reddy

author

2017-09-15 07:02 UTC #2 lore raw

I would like to ask will this patch be merged into Greg's Staging driver development tree? If not what kind of what of patches will be merged into Greg's tree?

Thanks,
Keerthi.

Quoted 55 lines · Julia Lawall

Quoted 4 lines · Keerthi Reddy
- Add a new line after struct declaration
- remove extra new line.
Signed-off-by Keerthi Reddy <[email protected] <javascript:>>
Acked-by Julia Lawall <[email protected] <javascript:>>
Review
Quoted 5 lines
---
 drivers/staging/android/ion/ion.h | 2 +- 
 1 file changed, 1 insertion(+), 1 deletion(-) 
(quoted diff) +0 -0
b/drivers/staging/android/ion/ion.h
drivers/staging/android/ion/ion.h size_t ion_heap_freelist_shrink(struct ion_heap
Quoted 12 lines
index 621e5f7..f5f9cd6 100644
drivers/staging/android/ion/ion.h +1 -0
@@ -86,6 +86,7 @@ struct ion_buffer { 
         struct sg_table *sg_table; 
         struct list_head attachments; 
 }; 
+ 
 void ion_buffer_destroy(struct ion_buffer *buffer); 
 
 /** 
@@ -299,7 +300,6 @@ size_t ion_heap_freelist_shrink(struct ion_heap 
*heap,
drivers/staging/android/ion/ion.h size_t ion_heap_freelist_shrink(struct ion_heap *heap,
Quoted 7 lines
drivers/staging/android/ion/ion.h +0 -1
  */ 
 size_t ion_heap_freelist_size(struct ion_heap *heap); 
 
- 
 /** 
  * functions for creating and destroying a heap pool -- allows you 
  * to keep a pool of pre allocated memory to use from your heap. 
Keeping
Quoted 5 lines
Signature · 4 lines
2.7.4 

-- 
You received this message because you are subscribed to the Google 
Groups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected] <javascript:>.
Quoted 1 line
To post to this group, send email to [email protected]
<javascript:>.
Quoted 1 line
To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/20170913171234.GA4052%40manoharreddy.
Quoted 2 lines
For more options, visit https://groups.google.com/d/optout.

Julia Lawall

2017-09-15 07:04 UTC #3 lore raw

Quoted 2 lines · Keerthi Reddy

I would like to ask will this patch be merged into Greg's Staging driver development tree?

Yes, normally it will, or if there is a problem you will get a message about it. If it is merged, you will get a message about that too.

julia

Quoted 71 lines

If not what kind of what of patches will be merged into Greg's tree?
Thanks,
Keerthi.

On Thursday, September 14, 2017 at 1:40:50 AM UTC+5:30, Julia Lawall wrote:

      On Wed, 13 Sep 2017, Keerthi Reddy wrote:

      > - Add a new line after struct declaration
      > - remove extra new line.
      >
      > Signed-off-by: Keerthi Reddy <[email protected]>

      Acked-by: Julia Lawall <[email protected]>

      > ---
      >  drivers/staging/android/ion/ion.h | 2 +-
      >  1 file changed, 1 insertion(+), 1 deletion(-)
      >
      > diff --git a/drivers/staging/android/ion/ion.h
      b/drivers/staging/android/ion/ion.h
      > index 621e5f7..f5f9cd6 100644
      > --- a/drivers/staging/android/ion/ion.h
      > +++ b/drivers/staging/android/ion/ion.h
      > @@ -86,6 +86,7 @@ struct ion_buffer {
      >          struct sg_table *sg_table;
      >          struct list_head attachments;
      >  };
      > +
      >  void ion_buffer_destroy(struct ion_buffer *buffer);
      >
      >  /**
      > @@ -299,7 +300,6 @@ size_t ion_heap_freelist_shrink(struct
      ion_heap *heap,
      >   */
      >  size_t ion_heap_freelist_size(struct ion_heap *heap);
      >
      > -
      >  /**
      >   * functions for creating and destroying a heap pool --
      allows you
      >   * to keep a pool of pre allocated memory to use from your
      heap.  Keeping
      > --
      > 2.7.4
      >
      > --
      > You received this message because you are subscribed to the
      Google Groups "outreachy-kernel" group.
      > To unsubscribe from this group and stop receiving emails from
      it, send an email to [email protected].
      > To post to this group, send email to
      [email protected].
      > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20170913171234.GA4052%40
      manoharreddy.
      > For more options, visit https://groups.google.com/d/optout.
      >

--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/df162e84-1763-4fc6-8d3d- 8aee1151f515%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Greg KH

maintainer

2017-09-15 16:50 UTC #4 lore raw

In reply to Keerthi Reddy

Quoted 3 lines · Keerthi Reddy

I would like to ask will this patchï¿½be merged into Greg's Staging driver development tree? If not what kind of what of patches will be merged into Greg's tree?

I am at a conference all this week so I will resume review of staging patches next week, sorry for the delay...

greg k-h