Staging: irda: Use !x instead of NULL comparison
Subsystems (3)
PATCH 1/1 Staging: irda: Use !x instead of NULL comparison
Test for NULL as !x where functions that return NULL on failure are used. Done using the following semantic patch by coccinelle.
@ is_null @
expression E;
statement S;
@@
E = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\| usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...));
(
if(!E)
S
|
-if(E==NULL)
+if(!E)
S
)
--- drivers/staging/irda/net/discovery.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/irda/net/discovery.c +2 -2
@@ -179,7 +179,7 @@ void irlmp_expire_discoveries(hashbin_t *log, __u32 saddr, int force)/* Create the client specific buffer */ n =HASHBIN_GET_SIZE (log); buffer =kmalloc (n *sizeof (struct irda_device_info ),GFP_ATOMIC ); -if (buffer ==NULL ) { +if (!buffer) {spin_unlock_irqrestore (&log->hb_spinlock, flags);return ; }
@@ -291,7 +291,7 @@ struct irda_device_info *irlmp_copy_discoveries(hashbin_t *log, int *pn,/* Create the client specific buffer */ n =HASHBIN_GET_SIZE (log); buffer =kmalloc (n *sizeof (struct irda_device_info ),GFP_ATOMIC ); -if (buffer ==NULL ) { +if (!buffer) {spin_unlock_irqrestore (&log->hb_spinlock, flags);return NULL ; }
Signature · 1 line
2.7.4
Quoted 20 lines · Srishti Sharma
Test for NULL as !x where functions that return NULL on failure are used. Done using the following semantic patch by coccinelle.
@
is_null@
expression E;
statement S;
@@E = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\| usb_alloc_urb\|alloc_netdev\|dev_alloc_skb\)(...));
(
if(!E)
S
|(quoted diff) +1
-1-if(E==NULL) +if(!E) S)
Quoted 1 line
Signed-off-by Srishti Sharma <[email protected]>
Quoted 36 lines
--- drivers/staging/irda/net/discovery.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/irda/net/discovery.c +2
-3@@ -179,7 +179,7 @@ void irlmp_expire_discoveries(hashbin_t *log, __u32 saddr, int force)/* Create the client specific buffer */ n =HASHBIN_GET_SIZE (log); buffer =kmalloc (n *sizeof (struct irda_device_info ),GFP_ATOMIC ); -if (buffer ==NULL ) { +if (!buffer) {spin_unlock_irqrestore (&log->hb_spinlock, flags);return ; }@@ -291,7 +291,7 @@ struct irda_device_info *irlmp_copy_discoveries(hashbin_t *log, int *pn,/* Create the client specific buffer */ n =HASHBIN_GET_SIZE (log); buffer =kmalloc (n *sizeof (struct irda_device_info ),GFP_ATOMIC ); -if (buffer ==NULL ) { +if (!buffer) {spin_unlock_irqrestore (&log->hb_spinlock, flags);return NULL ; } --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505543667-4670-1-git-send-email-srishtishar%40gmail.com.
For more options, visit https://groups.google.com/d/optout.