staging: wilc1000: Blank lines aren't necessary before a close brace '}'
PATCH 1/1 staging: wilc1000: Blank lines aren't necessary before a close brace '}'
Before closing the brace, the blank line is not needed. That blank line has not meaning here. so remove it.
--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +0 -1
@@ -1111,7 +1111,6 @@ static int del_key(struct wiphy *wiphy, struct net_device *netdev, g_key_gtk_params.key =NULL ;kfree (g_key_gtk_params.seq); g_key_gtk_params.seq =NULL ; - }if (key_index >=0 && key_index <=3 ) {
Signature · 1 line
2.7.4
Quoted 2 lines · Keerthi Reddy
Before closing the brace, the blank line is not needed. That blank line has not meaning here. so remove it.
This is on the same file as your previous patch, so they have to be put in a series.
julia
Quoted 28 lines
Signed-off-by Keerthi Reddy <[email protected]>--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 - 1 file changed, 1 deletion(-)drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +0
-2@@ -1111,7 +1111,6 @@ static int del_key(struct wiphy *wiphy, struct net_device *netdev, g_key_gtk_params.key =NULL ;kfree (g_key_gtk_params.seq); g_key_gtk_params.seq =NULL ; - }if (key_index >=0 && key_index <=3 ) { --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170923172108.GA8880%40manoharreddy.
For more options, visit https://groups.google.com/d/optout.
Quoted 2 lines · Julia Lawall
This is on the same file as your previous patch, so they have to be put in a series.
Can I update the patch previous patch into a patch set by combining this one the previous one?
Quoted 39 lines · Keerthi Reddy
Quoted 3 lines
Before closing the brace, the blank line is not needed. That blank line has not meaning here. so remove it.
This is on the same file as your previous patch, so they have to be put in a series.
julia
Quoted 28 lines
Signed-off-by Keerthi Reddy <[email protected]>--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 - 1 file changed, 1 deletion(-)drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +0
-2@@ -1111,7 +1111,6 @@ static int del_key(struct wiphy *wiphy, struct net_device *netdev, g_key_gtk_params.key =NULL ;kfree (g_key_gtk_params.seq); g_key_gtk_params.seq =NULL ; - }if (key_index >=0 && key_index <=3 ) { --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170923172108.GA8880%40manoharreddy.
For more options, visit https://groups.google.com/d/optout.
Quoted 6 lines · Keerthi Reddy
Quoted 2 lines · Julia Lawall
This is on the same file as your previous patch, so they have to be put in a series.
Can I update the patch previous patch into a patch set by combining this one the previous one?
I'm not sure to completely understand the question. Each patch should do only one thing. These are doing two different things, so they should not be in the same patch. You need to make a series, with one being 1/2 and the next being 2/2. How to do this is described in the tutorial.
julia
Quoted 40 lines
Quoted 39 lines · Keerthi Reddy
Quoted 3 lines
Before closing the brace, the blank line is not needed. That blank line has not meaning here. so remove it.
This is on the same file as your previous patch, so they have to be put in a series.
julia
Quoted 28 lines
Signed-off-by Keerthi Reddy <[email protected]>--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 - 1 file changed, 1 deletion(-)drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +0
-2@@ -1111,7 +1111,6 @@ static int del_key(struct wiphy *wiphy, struct net_device *netdev, g_key_gtk_params.key =NULL ;kfree (g_key_gtk_params.seq); g_key_gtk_params.seq =NULL ; - }if (key_index >=0 && key_index <=3 ) { --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170923172108.GA8880%40manoharreddy.
For more options, visit https://groups.google.com/d/optout.