staging: wilc1000: follow coding guidelines
cover staging: wilc1000: follow coding guidelines
This patch set fixes blank space related coding style
Keerthi Reddy (2):
staging: wilc1000: No space is necessary after a cast
staging: wilc1000: Blank lines aren't necessary before a close brace
'}'
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Signature · 1 line
2.7.4
PATCH 1/2 staging: wilc1000: No space is necessary after a cast
A space after type casting is not needed. All the other typecasts in this file don't put space after typecast. so remove space after typecast at this line.
checked with checkpatch.pl script
--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +1 -1
@@ -1617,7 +1617,7 @@ static int mgmt_tx(struct wiphy *wiphy, *cookie = (unsigned long )buf; priv->u64tx_cookie = *cookie; - mgmt = (const struct ieee80211_mgmt *) buf; + mgmt = (const struct ieee80211_mgmt *)buf;if (ieee80211_is_mgmt (mgmt->frame_control)) { mgmt_tx =kmalloc (sizeof (struct p2p_mgmt_data ),GFP_KERNEL );
Signature · 1 line
2.7.4
Re: [Outreachy kernel] [PATCH 1/2] staging: wilc1000: No space is necessary after a cast
Quoted 7 lines · Keerthi Reddy
A space after type casting is not needed. All the other typecasts in this file don't put space after typecast. so remove space after typecast at this line.
checked with checkpatch.pl script
Signed-off-by Keerthi Reddy <[email protected]>
Quoted 27 lines
--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +1
-2@@ -1617,7 +1617,7 @@ static int mgmt_tx(struct wiphy *wiphy, *cookie = (unsigned long )buf; priv->u64tx_cookie = *cookie; - mgmt = (const struct ieee80211_mgmt *) buf; + mgmt = (const struct ieee80211_mgmt *)buf;if (ieee80211_is_mgmt (mgmt->frame_control)) { mgmt_tx =kmalloc (sizeof (struct p2p_mgmt_data ),GFP_KERNEL ); --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/0a42225d2ac8416a7b74f2c9cea55bfd4d0521e8.1506192874.git.keerthigd4990%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
PATCH 2/2 staging: wilc1000: Blank lines aren't necessary before a close brace '}'
In reply to Keerthi ReddyBefore closing the brace, the blank line is not needed. That blank line has not meaning here. so remove it.
--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +0 -1
@@ -1111,7 +1111,6 @@ static int del_key(struct wiphy *wiphy, struct net_device *netdev, g_key_gtk_params.key =NULL ;kfree (g_key_gtk_params.seq); g_key_gtk_params.seq =NULL ; - }if (key_index >=0 && key_index <=3 ) {
Signature · 1 line
2.7.4
Re: [Outreachy kernel] [PATCH 2/2] staging: wilc1000: Blank lines aren't necessary before a close brace '}'
Quoted 4 lines · Keerthi Reddy
Before closing the brace, the blank line is not needed. That blank line has not meaning here. so remove it.
Signed-off-by Keerthi Reddy <[email protected]>
Quoted 26 lines
--- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 - 1 file changed, 1 deletion(-)drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +0
-2@@ -1111,7 +1111,6 @@ static int del_key(struct wiphy *wiphy, struct net_device *netdev, g_key_gtk_params.key =NULL ;kfree (g_key_gtk_params.seq); g_key_gtk_params.seq =NULL ; - }if (key_index >=0 && key_index <=3 ) { --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/366b2ad7e1bbc454659e73fda48ec695826ad673.1506192874.git.keerthigd4990%40gmail.com.
For more options, visit https://groups.google.com/d/optout.