Skip to contentSkip to conversation

time: clocksource: use setup_timer() helper.

PATCH In review Allen Pais 2 participants 2 messages Sep 21, 2017 – Oct 19, 2017 Timekeeping, clocksource core, NTP, alarmtimer

lore
Share & tools
lore

Allen Pais

author
#0 lore raw

PATCH 1/1 time: clocksource: use setup_timer() helper.

Use setup_timer function instead of initializing timer with the function and data fields.

---
 kernel/time/clocksource.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
kernel/time/clocksource.c +1 -2
index 03918a1..5b51d5b 100644
@@ -290,8 +290,7 @@ static inline void clocksource_start_watchdog(void)
 {
 	if (watchdog_running || !watchdog || list_empty(&watchdog_list))
 		return;
-	init_timer(&watchdog_timer);
-	watchdog_timer.function = clocksource_watchdog;
+	setup_timer(&watchdog_timer, clocksource_watchdog, 0UL);
 	watchdog_timer.expires = jiffies + WATCHDOG_INTERVAL;
 	add_timer_on(&watchdog_timer, cpumask_first(cpu_online_mask));
 	watchdog_running = 1;
Signature · 1 line
2.7.4
#1 lore raw
Quoted 13 lines · Allen Pais

Use setup_timer function instead of initializing timer with the function and data fields.

---
 kernel/time/clocksource.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
kernel/time/clocksource.c +0 -0
index 03918a1..5b51d5b 100644

kernel/time/clocksource.c static inline void clocksource_start_watchdog(void) · line 293

Quoted 6 lines
kernel/time/clocksource.c +1 -2
@@ -290,8 +290,7 @@ static inline void clocksource_start_watchdog(void)
 {
 	if (watchdog_running || !watchdog || list_empty(&watchdog_list))
 		return;
-	init_timer(&watchdog_timer);
-	watchdog_timer.function = clocksource_watchdog;
+	setup_timer(&watchdog_timer, clocksource_watchdog, 0UL);

We changed this to use the timer_setup() function. Please resend.

Thanks,

tglx