Skip to contentSkip to conversation

staging: rtl8188eu: Move a blank line

PATCH Superseded Dafna Hirschfeld 2 participants 2 messages Feb 15, 2018 – Feb 16, 2018 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: rtl8188eu: Move a blank line

Move a blank line from in the middle of a declaration list to after the declaration list, to improve readability.

Issue found by checkpatch.

---
Break commit body to two short lines.
Make commit body and description clearer.

 drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/hal/usb_halinit.c +1 -1
index 17967c9..c3bb183 100644
@@ -1516,8 +1516,8 @@ void rtw_hal_set_hwreg(struct adapter *Adapter, u8 variable, u8 *val)
 	case HW_VAR_CAM_WRITE:
 		{
 			u32 cmd;
-
 			u32 *cam_val = (u32 *)val;
+
 			usb_write32(Adapter, WCAMI, cam_val[0]);
 
 			cmd = CAM_POLLINIG | CAM_WRITE | cam_val[1];
Signature · 1 line
2.7.4
#1 lore raw
Quoted 9 lines · Dafna Hirschfeld

Move a blank line from in the middle of a declaration list to after the declaration list, to improve readability.

Issue found by checkpatch.

---
Break commit body to two short lines.
Make commit body and description clearer.

You could put v2: in front of this message. But I think it is clear enough as is.

julia

Quoted 28 lines
 drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/hal/usb_halinit.c +1 -2
index 17967c9..c3bb183 100644
@@ -1516,8 +1516,8 @@ void rtw_hal_set_hwreg(struct adapter *Adapter, u8 variable, u8 *val)
 	case HW_VAR_CAM_WRITE:
 		{
 			u32 cmd;
-
 			u32 *cam_val = (u32 *)val;
+
 			usb_write32(Adapter, WCAMI, cam_val[0]);
 
 			cmd = CAM_POLLINIG | CAM_WRITE | cam_val[1];
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180215223652.GA6741%40gmail.com.
For more options, visit https://groups.google.com/d/optout.