Skip to contentSkip to conversation

staging: comedi: Remove a newline inside a dereference

PATCH In review Eisha Chen-yen-su 3 participants 3 messages Feb 19, 2018 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: comedi: Remove a newline inside a dereference

Remove a new line inside a dereference so that it is not on multiple lines.
And avoid making the line go over 80 columns by moving the whole dma_alloc_coherent() call back 4 columns. Problem found with checkpatch.

---
Changes in v2:
- Change the commit log to mention what I have done.
- Remove the unnecessary cited lines from checkpatch inside the commit body.
Changes in v3:
- Rephrase completely the commit message.
- Move the whole dma_alloc_coherent() call back 4 columns in order to avoid making the line exceeding 80 characters length.

 drivers/staging/comedi/drivers/cb_pcidas64.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/staging/comedi/drivers/cb_pcidas64.c +4 -5
index b657beedd5ff..c00750054ae9 100644
@@ -1488,11 +1488,10 @@ static int alloc_and_init_dma_members(struct comedi_device *dev)
 	for (i = 0; i < AO_DMA_RING_COUNT; i++) {
 		if (ao_cmd_is_supported(board)) {
 			devpriv->ao_buffer[i] =
-				dma_alloc_coherent(&pcidev->dev,
-						   DMA_BUFFER_SIZE,
-						   &devpriv->
-						   ao_buffer_bus_addr[i],
-						   GFP_KERNEL);
+			    dma_alloc_coherent(&pcidev->dev,
+					       DMA_BUFFER_SIZE,
+					       &devpriv->ao_buffer_bus_addr[i],
+					       GFP_KERNEL);
 			if (!devpriv->ao_buffer[i])
 				return -ENOMEM;
 		}

--
2.14.3

Acked-by on v3 1/1
#1 lore raw
Quoted 7 lines · Eisha Chen-yen-su

Remove a new line inside a dereference so that it is not on multiple lines.
And avoid making the line go over 80 columns by moving the whole dma_alloc_coherent() call back 4 columns. Problem found with checkpatch.

Quoted 42 lines

---
Changes in v2:
- Change the commit log to mention what I have done.
- Remove the unnecessary cited lines from checkpatch inside the commit body.
Changes in v3:
- Rephrase completely the commit message.
- Move the whole dma_alloc_coherent() call back 4 columns in order to avoid making the line exceeding 80 characters length.

 drivers/staging/comedi/drivers/cb_pcidas64.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/staging/comedi/drivers/cb_pcidas64.c +4 -6
index b657beedd5ff..c00750054ae9 100644
@@ -1488,11 +1488,10 @@ static int alloc_and_init_dma_members(struct comedi_device *dev)
 	for (i = 0; i < AO_DMA_RING_COUNT; i++) {
 		if (ao_cmd_is_supported(board)) {
 			devpriv->ao_buffer[i] =
-				dma_alloc_coherent(&pcidev->dev,
-						   DMA_BUFFER_SIZE,
-						   &devpriv->
-						   ao_buffer_bus_addr[i],
-						   GFP_KERNEL);
+			    dma_alloc_coherent(&pcidev->dev,
+					       DMA_BUFFER_SIZE,
+					       &devpriv->ao_buffer_bus_addr[i],
+					       GFP_KERNEL);
 			if (!devpriv->ao_buffer[i])
 				return -ENOMEM;
 		}
--

2.14.3

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180219160422.27240-1-chenyensu0%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reviewed-by on v3 1/1
#2 lore raw
In reply to Eisha Chen-yen-su
Quoted 16 lines · Eisha Chen-yen-su

Remove a new line inside a dereference so that it is not on multiple lines.
And avoid making the line go over 80 columns by moving the whole dma_alloc_coherent() call back 4 columns. Problem found with checkpatch.

---
Changes in v2:
- Change the commit log to mention what I have done.
- Remove the unnecessary cited lines from checkpatch inside the commit body.
Changes in v3:
- Rephrase completely the commit message.
- Move the whole dma_alloc_coherent() call back 4 columns in order to avoid making the line exceeding 80 characters length.

Quoted 2 lines
  drivers/staging/comedi/drivers/cb_pcidas64.c | 9 ++++-----
  1 file changed, 4 insertions(+), 5 deletions(-)

Looks good. Thanks!

Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-