Skip to contentSkip to conversation

fs/proc/inode.c:382:3-9: preceding lock on line 378 (fwd)

PATCH In review Julia Lawall 2 participants 2 messages Feb 25, 2018 Memory management

lore
Share & tools
lore
#0 lore raw

PATCH 110/152 fs/proc/inode.c:382:3-9: preceding lock on line 378 (fwd)

Please check whether an unlock is missing before line 382.

julia

---------- Forwarded message ----------
Date: Mon, 26 Feb 2018 00:11:20 +0800
From: kbuild test robot <[email protected]>
To: [email protected]
Cc: Julia Lawall <[email protected]>
Subject: [mmotm:master 110/152] fs/proc/inode.c:382:3-9: preceding lock on line

    378

CC: [email protected]
TO: Alexey Dobriyan <[email protected]>
CC: Johannes Weiner <[email protected]>
CC: Andrew Morton <[email protected]>
CC: Linux Memory Management List <[email protected]>

tree:   git://git.cmpxchg.org/linux-mmotm.git master
head:   745388a34645dd2b69f5e7115ad47fea7a218726
commit: 2e2d47fa3e1f9dff0e77de6edb123f024bf7841b [110/152] proc: do less stuff under ->pde_unload_lock

:::::: branch date: 4 days ago
:::::: commit date: 4 days ago

Quoted 1 line
Quoted 1 line

fs/proc/inode.c:382:3-9: preceding lock on line 378

git remote add mmotm git://git.cmpxchg.org/linux-mmotm.git
git remote update mmotm
git checkout 2e2d47fa3e1f9dff0e77de6edb123f024bf7841b vim +382 fs/proc/inode.c

786d7e16 Alexey Dobriyan 2007-07-15  373
786d7e16 Alexey Dobriyan 2007-07-15  374  static int proc_reg_release(struct inode *inode, struct file *file)
786d7e16 Alexey Dobriyan 2007-07-15  375  {
786d7e16 Alexey Dobriyan 2007-07-15  376  	struct proc_dir_entry *pde = PDE(inode);
881adb85 Alexey Dobriyan 2008-07-25  377  	struct pde_opener *pdeo;
786d7e16 Alexey Dobriyan 2007-07-15 @378  	spin_lock(&pde->pde_unload_lock);
ca469f35 Al Viro         2013-04-03  379  	list_for_each_entry(pdeo, &pde->pde_openers, lh) {
ca469f35 Al Viro         2013-04-03  380  		if (pdeo->file == file) {
ca469f35 Al Viro         2013-04-03  381  			close_pdeo(pde, pdeo);
2e2d47fa Alexey Dobriyan 2018-02-21 @382  			return 0;
786d7e16 Alexey Dobriyan 2007-07-15  383  		}
881adb85 Alexey Dobriyan 2008-07-25  384  	}
786d7e16 Alexey Dobriyan 2007-07-15  385  	spin_unlock(&pde->pde_unload_lock);
ca469f35 Al Viro         2013-04-03  386  	return 0;
786d7e16 Alexey Dobriyan 2007-07-15  387  }

786d7e16 Alexey Dobriyan 2007-07-15 388

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#1 lore raw
Quoted 1 line · Julia Lawall

Please check whether an unlock is missing before line 382.

False positive.

Quoted 42 lines

---------- Forwarded message ----------
Date: Mon, 26 Feb 2018 00:11:20 +0800
From: kbuild test robot <[email protected]>
To: [email protected]
Cc: Julia Lawall <[email protected]>
Subject: [mmotm:master 110/152] fs/proc/inode.c:382:3-9: preceding lock on line

    378

CC: [email protected]
TO: Alexey Dobriyan <[email protected]>
CC: Johannes Weiner <[email protected]>
CC: Andrew Morton <[email protected]>
CC: Linux Memory Management List <[email protected]>

tree:   git://git.cmpxchg.org/linux-mmotm.git master
head:   745388a34645dd2b69f5e7115ad47fea7a218726
commit: 2e2d47fa3e1f9dff0e77de6edb123f024bf7841b [110/152] proc: do less stuff under ->pde_unload_lock

:::::: branch date: 4 days ago
:::::: commit date: 4 days ago

Quoted 1 line
Quoted 1 line

fs/proc/inode.c:382:3-9: preceding lock on line 378

git remote add mmotm git://git.cmpxchg.org/linux-mmotm.git
git remote update mmotm
git checkout 2e2d47fa3e1f9dff0e77de6edb123f024bf7841b vim +382 fs/proc/inode.c

786d7e16 Alexey Dobriyan 2007-07-15  373
786d7e16 Alexey Dobriyan 2007-07-15  374  static int proc_reg_release(struct inode *inode, struct file *file)
786d7e16 Alexey Dobriyan 2007-07-15  375  {
786d7e16 Alexey Dobriyan 2007-07-15  376  	struct proc_dir_entry *pde = PDE(inode);
881adb85 Alexey Dobriyan 2008-07-25  377  	struct pde_opener *pdeo;
786d7e16 Alexey Dobriyan 2007-07-15 @378  	spin_lock(&pde->pde_unload_lock);
ca469f35 Al Viro         2013-04-03  379  	list_for_each_entry(pdeo, &pde->pde_openers, lh) {
ca469f35 Al Viro         2013-04-03  380  		if (pdeo->file == file) {
ca469f35 Al Viro         2013-04-03  381  			close_pdeo(pde, pdeo);
2e2d47fa Alexey Dobriyan 2018-02-21 @382  			return 0;
786d7e16 Alexey Dobriyan 2007-07-15  383  		}
881adb85 Alexey Dobriyan 2008-07-25  384  	}
786d7e16 Alexey Dobriyan 2007-07-15  385  	spin_unlock(&pde->pde_unload_lock);
ca469f35 Al Viro         2013-04-03  386  	return 0;
786d7e16 Alexey Dobriyan 2007-07-15  387  }
Quoted 1 line

786d7e16 Alexey Dobriyan 2007-07-15 388

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>