Skip to contentSkip to conversation

Coccinelle: memdup: Fix typo in warning messages

PATCH In review Dafna Hirschfeld 4 participants 5 messages Feb 27, 2018 – Mar 2, 2018 Coccinelle/Semantic Patches (SmPL)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Coccinelle: memdup: Fix typo in warning messages

Replace 'kmemdep' with 'kmemdup' in warning messages.

---
 scripts/coccinelle/api/memdup.cocci | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/coccinelle/api/memdup.cocci +2 -2
index 1249b72..8fd6437 100644
@@ -56,10 +56,10 @@ statement S;
 p << r.p;
 @@
 
-coccilib.org.print_todo(p[0], "WARNING opportunity for kmemdep")
+coccilib.org.print_todo(p[0], "WARNING opportunity for kmemdup")
 
 @script:python depends on report@
 p << r.p;
 @@
 
-coccilib.report.print_report(p[0], "WARNING opportunity for kmemdep")
+coccilib.report.print_report(p[0], "WARNING opportunity for kmemdup")
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw
Quoted 1 line · Dafna Hirschfeld

Replace 'kmemdep' with 'kmemdup' in warning messages.

Thanks for the detailed commit log. Because I stared and stared at it and couldn't see the difference :)

Quoted 2 lines
Quoted 25 lines
---
 scripts/coccinelle/api/memdup.cocci | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/coccinelle/api/memdup.cocci +2 -3
index 1249b72..8fd6437 100644
@@ -56,10 +56,10 @@ statement S;
 p << r.p;
 @@
 
-coccilib.org.print_todo(p[0], "WARNING opportunity for kmemdep")
+coccilib.org.print_todo(p[0], "WARNING opportunity for kmemdup")
 
 @script:python depends on report@
 p << r.p;
 @@
 
-coccilib.report.print_report(p[0], "WARNING opportunity for kmemdep")
+coccilib.report.print_report(p[0], "WARNING opportunity for kmemdup")
--

2.7.4

#2 lore raw

Hi Dafna

Quoted 11 lines

-----Original Message-----
From: Julia Lawall [mailto:[email protected]]
Sent: Wednesday, February 28, 2018 4:58 PM
To: Dafna Hirschfeld <[email protected]>
Cc: Gilles Muller <[email protected]>; [email protected]; [email protected]; Yamada, Masahiro/山田 真弘 <[email protected]>; [email protected]
Subject: Re: [PATCH] Coccinelle: memdup: Fix typo in warning messages

Quoted 6 lines
Quoted 1 line · Dafna Hirschfeld

Replace 'kmemdep' with 'kmemdup' in warning messages.

Thanks for the detailed commit log. Because I stared and stared at it and couldn't see the difference :)

I could not find this patch in ML.

Please repost it with the following ML in To or CC.

[email protected]
[email protected]

That will be helpful because I usually pick up patches from patchwork.

Thanks!

Quoted 31 lines
Quoted 2 lines

Review

Quoted 5 lines
---
 scripts/coccinelle/api/memdup.cocci | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/scripts/coccinelle/api/memdup.cocci

Quoted 20 lines

index 1249b72..8fd6437 100644

scripts/coccinelle/api/memdup.cocci +2 -3
@@ -56,10 +56,10 @@ statement S;
 p << r.p;
 @@
 
-coccilib.org.print_todo(p[0], "WARNING opportunity for kmemdep")
+coccilib.org.print_todo(p[0], "WARNING opportunity for kmemdup")
 
 @script:python depends on report@
 p << r.p;
 @@
 
-coccilib.report.print_report(p[0], "WARNING opportunity for kmemdep")
+coccilib.report.print_report(p[0], "WARNING opportunity for kmemdup")
--

2.7.4

#3 lore raw
Quoted 17 lines · On Thu, 1 Mar 2018, [email protected] wrote:

Hi Dafna

Quoted 15 lines

-----Original Message-----
From: Julia Lawall [mailto:[email protected]]
Sent: Wednesday, February 28, 2018 4:58 PM
To: Dafna Hirschfeld <[email protected]>
Cc: Gilles Muller <[email protected]>; [email protected]; [email protected]; Yamada, Masahiro/山田 真弘 <[email protected]>; [email protected]
Subject: Re: [PATCH] Coccinelle: memdup: Fix typo in warning messages

Quoted 1 line · Dafna Hirschfeld

Replace 'kmemdep' with 'kmemdup' in warning messages.

Quoted 7 lines
Quoted 2 lines

Thanks for the detailed commit log. Because I stared and stared at it and couldn't see the difference :)

I could not find this patch in ML.

Please repost it with the following ML in To or CC.

Dafna,

When you repost, please add my ack.

thanks,
julia

Quoted 46 lines

[email protected]
[email protected]

That will be helpful because I usually pick up patches from patchwork.

Thanks!

Quoted 31 lines
Quoted 2 lines

Review

Quoted 5 lines
---
 scripts/coccinelle/api/memdup.cocci | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/scripts/coccinelle/api/memdup.cocci

Quoted 20 lines

index 1249b72..8fd6437 100644

scripts/coccinelle/api/memdup.cocci +2 -3
@@ -56,10 +56,10 @@ statement S;
 p << r.p;
 @@
 
-coccilib.org.print_todo(p[0], "WARNING opportunity for kmemdep")
+coccilib.org.print_todo(p[0], "WARNING opportunity for kmemdup")
 
 @script:python depends on report@
 p << r.p;
 @@
 
-coccilib.report.print_report(p[0], "WARNING opportunity for kmemdep")
+coccilib.report.print_report(p[0], "WARNING opportunity for kmemdup")
--

2.7.4

maintainer Acked-by on v1 1/1
#4 lore raw
In reply to Dafna Hirschfeld

Le 27/02/2018 à 22:59, Dafna Hirschfeld a écrit :

Quoted 3 lines

Replace 'kmemdep' with 'kmemdup' in warning messages.

Quoted 22 lines
---
  scripts/coccinelle/api/memdup.cocci | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
scripts/coccinelle/api/memdup.cocci +2 -2
index 1249b72..8fd6437 100644
@@ -56,10 +56,10 @@ statement S;
  p << r.p;
  @@
 
-coccilib.org.print_todo(p[0], "WARNING opportunity for kmemdep")
+coccilib.org.print_todo(p[0], "WARNING opportunity for kmemdup")
 
  @script:python depends on report@
  p << r.p;
  @@
 
-coccilib.report.print_report(p[0], "WARNING opportunity for kmemdep")
+coccilib.report.print_report(p[0], "WARNING opportunity for kmemdup")
Signature · 2 lines
Nicolas Palix
http://lig-membres.imag.fr/palix/