Skip to contentSkip to conversation

RFC: bus: fix semicolon.cocci warnings

PATCH In review Julia Lawall 2 participants 2 messages Jun 15, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RFC: bus: fix semicolon.cocci warnings

From: kbuild test robot <[email protected]>

Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes 7d8c3a62781b ("RFC: bus: 96boards Low-Speed Connector")

---
tree:
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-integrator.git ultra96

head:   27803f286226e1b5b5893aabfd55feec08b73bae
commit: 7d8c3a62781bbd8b42119b3af2c90f4d9eef3748 [20/21] RFC: bus:

96boards Low-Speed Connector

 96boards-secure96.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/bus/96boards-mezzanines/96boards-secure96.c +2 -2
@@ -223,7 +223,7 @@ out_unreg_leds:
 	platform_device_unregister(sec->leds_device);
 	for (i = 0; i < ARRAY_SIZE(ledinfos); i++) {
 		mezzanine_ls_put_gpiod(ls, sec->secure96_leds[i].gpiod);
-	};
+	}
 	return ERR_PTR(ret);
 }
 EXPORT_SYMBOL_GPL(secure96_populate);
@@ -244,6 +244,6 @@ void secure96_depopulate(void *data)
 	platform_device_unregister(sec->leds_device);
 	for (i = 0; i < ARRAY_SIZE(ledinfos); i++) {
 		mezzanine_ls_put_gpiod(sec->ls, sec->secure96_leds[i].gpiod);
-	};
+	}
 }
 EXPORT_SYMBOL_GPL(secure96_depopulate);
#1 lore raw
Quoted 3 lines · Julia Lawall

From: kbuild test robot <[email protected]>

Remove unneeded semicolon.

[]

Quoted 11 lines

+++ b/drivers/bus/96boards-mezzanines/96boards-secure96.c

drivers/bus/96boards-mezzanines/96boards-secure96.c +1 -1
@@ -223,7 +223,7 @@ out_unreg_leds:
 	platform_device_unregister(sec->leds_device);
 	for (i = 0; i < ARRAY_SIZE(ledinfos); i++) {
 		mezzanine_ls_put_gpiod(ls, sec->secure96_leds[i].gpiod);
-	};
+	}
 	return ERR_PTR(ret);
 }
 EXPORT_SYMBOL_GPL(secure96_populate);

drivers/bus/96boards-mezzanines/96boards-secure96.c void secure96_depopulate(void *data) · line 249

Quoted 7 lines
drivers/bus/96boards-mezzanines/96boards-secure96.c +1 -1
@@ -244,6 +244,6 @@ void secure96_depopulate(void *data)
 	platform_device_unregister(sec->leds_device);
 	for (i = 0; i < ARRAY_SIZE(ledinfos); i++) {
 		mezzanine_ls_put_gpiod(sec->ls, sec->secure96_leds[i].gpiod);
-	};
+	}
 }
 EXPORT_SYMBOL_GPL(secure96_depopulate);

While these are clearly correct, perhaps it would
be better to remove the braces too.